diff options
| author | Fredrik Roubert <roubert@google.com> | 2015-03-04 22:31:48 +0100 |
|---|---|---|
| committer | Fredrik Roubert <roubert@google.com> | 2015-03-19 18:00:10 +0100 |
| commit | 7b04e71ea31000eeb46db78c2d66014fa3981dbf (patch) | |
| tree | cac2d2a14a11c25c0f726afdc13259edd9ef5b31 /icu4c | |
| parent | 57751605fe600a4da709ea71ed581eb262ccb5fe (diff) | |
| download | android_external_icu-7b04e71ea31000eeb46db78c2d66014fa3981dbf.tar.gz android_external_icu-7b04e71ea31000eeb46db78c2d66014fa3981dbf.tar.bz2 android_external_icu-7b04e71ea31000eeb46db78c2d66014fa3981dbf.zip | |
Android patch: Revert layout engine change problematic for Tamil.
This change was introduced in Android by the ICU51.1 upgrade:
https://android.googlesource.com/platform/external/icu/+/8393335
Change-Id: Id7be3469139286fe11699559b9ffe4a675145cb7
Diffstat (limited to 'icu4c')
| -rw-r--r-- | icu4c/source/layout/OpenTypeLayoutEngine.cpp | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/icu4c/source/layout/OpenTypeLayoutEngine.cpp b/icu4c/source/layout/OpenTypeLayoutEngine.cpp index 948b36626..1c8123e6b 100644 --- a/icu4c/source/layout/OpenTypeLayoutEngine.cpp +++ b/icu4c/source/layout/OpenTypeLayoutEngine.cpp @@ -532,7 +532,11 @@ void OpenTypeLayoutEngine::adjustGlyphPositions(const LEUnicode chars[], le_int3 delete adjustments; } else { // if there was no GPOS table, maybe there's non-OpenType kerning we can use - LayoutEngine::adjustGlyphPositions(chars, offset, count, reverse, glyphStorage, success); + // Google Patch: disable this. Causes problems with Tamil. + // Umesh says layout is poor both with and without the change, but + // worse with the change. See ocean/imageprocessing/layout_test_unittest.cc + // Public ICU ticket for this problem is #7742 + // LayoutEngine::adjustGlyphPositions(chars, offset, count, reverse, glyphStorage, success); } LEGlyphID zwnj = fFontInstance->mapCharToGlyph(0x200C); |