diff options
Diffstat (limited to 'guava-testlib/src/com/google/common/collect/testing/testers/CollectionRemoveAllTester.java')
-rw-r--r-- | guava-testlib/src/com/google/common/collect/testing/testers/CollectionRemoveAllTester.java | 50 |
1 files changed, 15 insertions, 35 deletions
diff --git a/guava-testlib/src/com/google/common/collect/testing/testers/CollectionRemoveAllTester.java b/guava-testlib/src/com/google/common/collect/testing/testers/CollectionRemoveAllTester.java index f607916..1005307 100644 --- a/guava-testlib/src/com/google/common/collect/testing/testers/CollectionRemoveAllTester.java +++ b/guava-testlib/src/com/google/common/collect/testing/testers/CollectionRemoveAllTester.java @@ -18,12 +18,9 @@ package com.google.common.collect.testing.testers; import static com.google.common.collect.testing.features.CollectionFeature.ALLOWS_NULL_QUERIES; import static com.google.common.collect.testing.features.CollectionFeature.ALLOWS_NULL_VALUES; -import static com.google.common.collect.testing.features.CollectionFeature.FAILS_FAST_ON_CONCURRENT_MODIFICATION; -import static com.google.common.collect.testing.features.CollectionFeature.SUPPORTS_REMOVE; -import static com.google.common.collect.testing.features.CollectionSize.SEVERAL; +import static com.google.common.collect.testing.features.CollectionFeature.SUPPORTS_REMOVE_ALL; import static com.google.common.collect.testing.features.CollectionSize.ZERO; -import com.google.common.annotations.GwtCompatible; import com.google.common.collect.testing.AbstractCollectionTester; import com.google.common.collect.testing.MinimalCollection; import com.google.common.collect.testing.WrongType; @@ -31,8 +28,6 @@ import com.google.common.collect.testing.features.CollectionFeature; import com.google.common.collect.testing.features.CollectionSize; import java.util.Collections; -import java.util.ConcurrentModificationException; -import java.util.Iterator; /** * A generic JUnit test which tests {@code removeAll} operations on a @@ -45,23 +40,22 @@ import java.util.Iterator; * @author Chris Povirk */ @SuppressWarnings("unchecked") // too many "unchecked generic array creations" -@GwtCompatible public class CollectionRemoveAllTester<E> extends AbstractCollectionTester<E> { - @CollectionFeature.Require(SUPPORTS_REMOVE) + @CollectionFeature.Require(SUPPORTS_REMOVE_ALL) public void testRemoveAll_emptyCollection() { assertFalse("removeAll(emptyCollection) should return false", collection.removeAll(MinimalCollection.of())); expectUnchanged(); } - @CollectionFeature.Require(SUPPORTS_REMOVE) + @CollectionFeature.Require(SUPPORTS_REMOVE_ALL) public void testRemoveAll_nonePresent() { assertFalse("removeAll(disjointCollection) should return false", collection.removeAll(MinimalCollection.of(samples.e3))); expectUnchanged(); } - @CollectionFeature.Require(SUPPORTS_REMOVE) + @CollectionFeature.Require(SUPPORTS_REMOVE_ALL) @CollectionSize.Require(absent = ZERO) public void testRemoveAll_allPresent() { assertTrue("removeAll(intersectingCollection) should return true", @@ -69,7 +63,7 @@ public class CollectionRemoveAllTester<E> extends AbstractCollectionTester<E> { expectMissing(samples.e0); } - @CollectionFeature.Require(SUPPORTS_REMOVE) + @CollectionFeature.Require(SUPPORTS_REMOVE_ALL) @CollectionSize.Require(absent = ZERO) public void testRemoveAll_somePresent() { assertTrue("removeAll(intersectingCollection) should return true", @@ -77,24 +71,10 @@ public class CollectionRemoveAllTester<E> extends AbstractCollectionTester<E> { expectMissing(samples.e0); } - @CollectionFeature.Require({SUPPORTS_REMOVE, - FAILS_FAST_ON_CONCURRENT_MODIFICATION}) - @CollectionSize.Require(SEVERAL) - public void testRemoveAllSomePresentConcurrentWithIteration() { - try { - Iterator<E> iterator = collection.iterator(); - assertTrue(collection.removeAll(MinimalCollection.of(samples.e0, samples.e3))); - iterator.next(); - fail("Expected ConcurrentModificationException"); - } catch (ConcurrentModificationException expected) { - // success - } - } - /** * Trigger the other.size() >= this.size() case in AbstractSet.removeAll(). */ - @CollectionFeature.Require(SUPPORTS_REMOVE) + @CollectionFeature.Require(SUPPORTS_REMOVE_ALL) @CollectionSize.Require(absent = ZERO) public void testRemoveAll_somePresentLargeCollectionToRemove() { assertTrue("removeAll(largeIntersectingCollection) should return true", @@ -104,7 +84,7 @@ public class CollectionRemoveAllTester<E> extends AbstractCollectionTester<E> { expectMissing(samples.e0); } - @CollectionFeature.Require(absent = SUPPORTS_REMOVE) + @CollectionFeature.Require(absent = SUPPORTS_REMOVE_ALL) public void testRemoveAll_unsupportedEmptyCollection() { try { assertFalse("removeAll(emptyCollection) should return false or throw " @@ -115,7 +95,7 @@ public class CollectionRemoveAllTester<E> extends AbstractCollectionTester<E> { expectUnchanged(); } - @CollectionFeature.Require(absent = SUPPORTS_REMOVE) + @CollectionFeature.Require(absent = SUPPORTS_REMOVE_ALL) public void testRemoveAll_unsupportedNonePresent() { try { assertFalse("removeAll(disjointCollection) should return false or throw " @@ -126,7 +106,7 @@ public class CollectionRemoveAllTester<E> extends AbstractCollectionTester<E> { expectUnchanged(); } - @CollectionFeature.Require(absent = SUPPORTS_REMOVE) + @CollectionFeature.Require(absent = SUPPORTS_REMOVE_ALL) @CollectionSize.Require(absent = ZERO) public void testRemoveAll_unsupportedPresent() { try { @@ -146,7 +126,7 @@ public class CollectionRemoveAllTester<E> extends AbstractCollectionTester<E> { * suppress only the former. */ - @CollectionFeature.Require(SUPPORTS_REMOVE) + @CollectionFeature.Require(SUPPORTS_REMOVE_ALL) @CollectionSize.Require(ZERO) public void testRemoveAll_nullCollectionReferenceEmptySubject() { try { @@ -156,7 +136,7 @@ public class CollectionRemoveAllTester<E> extends AbstractCollectionTester<E> { } } - @CollectionFeature.Require(SUPPORTS_REMOVE) + @CollectionFeature.Require(SUPPORTS_REMOVE_ALL) @CollectionSize.Require(absent = ZERO) public void testRemoveAll_nullCollectionReferenceNonEmptySubject() { try { @@ -166,7 +146,7 @@ public class CollectionRemoveAllTester<E> extends AbstractCollectionTester<E> { } } - @CollectionFeature.Require(value = SUPPORTS_REMOVE, + @CollectionFeature.Require(value = SUPPORTS_REMOVE_ALL, absent = ALLOWS_NULL_QUERIES) public void testRemoveAll_containsNullNo() { MinimalCollection<?> containsNull = MinimalCollection.of((Object) null); @@ -178,7 +158,7 @@ public class CollectionRemoveAllTester<E> extends AbstractCollectionTester<E> { expectUnchanged(); } - @CollectionFeature.Require({SUPPORTS_REMOVE, ALLOWS_NULL_QUERIES}) + @CollectionFeature.Require({SUPPORTS_REMOVE_ALL, ALLOWS_NULL_QUERIES}) public void testRemoveAll_containsNullNoButAllowed() { MinimalCollection<?> containsNull = MinimalCollection.of((Object) null); assertFalse("removeAll(containsNull) should return false", @@ -186,7 +166,7 @@ public class CollectionRemoveAllTester<E> extends AbstractCollectionTester<E> { expectUnchanged(); } - @CollectionFeature.Require({SUPPORTS_REMOVE, ALLOWS_NULL_VALUES}) + @CollectionFeature.Require({SUPPORTS_REMOVE_ALL, ALLOWS_NULL_VALUES}) @CollectionSize.Require(absent = ZERO) public void testRemoveAll_containsNullYes() { initCollectionWithNullElement(); @@ -195,7 +175,7 @@ public class CollectionRemoveAllTester<E> extends AbstractCollectionTester<E> { // TODO: make this work with MinimalCollection } - @CollectionFeature.Require(SUPPORTS_REMOVE) + @CollectionFeature.Require(SUPPORTS_REMOVE_ALL) public void testRemoveAll_containsWrongType() { try { assertFalse("removeAll(containsWrongType) should return false or throw", |