diff options
| author | Ben Cheng <bccheng@android.com> | 2011-01-04 15:37:04 -0800 |
|---|---|---|
| committer | Ben Cheng <bccheng@android.com> | 2011-01-04 15:37:04 -0800 |
| commit | af5aa1f4ce7eecc1b47a4c038cebb67d33f08f18 (patch) | |
| tree | 3ceff6c58f8cdc8f1bcd6cc884215b62386be795 /vm/compiler/codegen/x86 | |
| parent | a85893356ac4d86ef7d7dd18807d7bef95d7dddb (diff) | |
| download | android_dalvik-af5aa1f4ce7eecc1b47a4c038cebb67d33f08f18.tar.gz android_dalvik-af5aa1f4ce7eecc1b47a4c038cebb67d33f08f18.tar.bz2 android_dalvik-af5aa1f4ce7eecc1b47a4c038cebb67d33f08f18.zip | |
Don't treat dvmJitToPatchPredictedChain as a Jit-to-Interp entry point.
It is just a native callout helper function.
Change-Id: I6398b6876f5ba579b76e732107157a4c99337796
Diffstat (limited to 'vm/compiler/codegen/x86')
| -rw-r--r-- | vm/compiler/codegen/x86/Assemble.c | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/vm/compiler/codegen/x86/Assemble.c b/vm/compiler/codegen/x86/Assemble.c index fbf53ca36..3895d7766 100644 --- a/vm/compiler/codegen/x86/Assemble.c +++ b/vm/compiler/codegen/x86/Assemble.c @@ -98,12 +98,8 @@ void* dvmJitChain(void* tgtAddr, u4* branchAddr) * rechain attempt to happen. * 2) Chain is not setup because the callee has not been created yet. Reset * the rechain count to a small number and retry in the near future. - * 3) Ask all other threads to stop before patching this chaining cell. - * This is required because another thread may have passed the class check - * but hasn't reached the chaining cell yet to follow the chain. If we - * patch the content before halting the other thread, there could be a - * small window for race conditions to happen that it may follow the new - * but wrong chain to invoke a different method. + * 3) Enqueue the new content for the chaining cell which will be appled in + * next safe point. */ const Method *dvmJitToPatchPredictedChain(const Method *method, InterpState *interpState, |