summaryrefslogtreecommitdiffstats
path: root/vm/compiler/codegen/x86
diff options
context:
space:
mode:
authorBill Buzbee <buzbee@google.com>2011-02-03 07:38:22 -0800
committerBill Buzbee <buzbee@google.com>2011-02-03 11:26:34 -0800
commit1b3da59fff0c63770e10684e243a36f3d0218637 (patch)
tree491847a477ea60ee154f47b0a9d374bb477428b7 /vm/compiler/codegen/x86
parent96915c3de9081d179599087c76ade237c929ceb9 (diff)
downloadandroid_dalvik-1b3da59fff0c63770e10684e243a36f3d0218637.tar.gz
android_dalvik-1b3da59fff0c63770e10684e243a36f3d0218637.tar.bz2
android_dalvik-1b3da59fff0c63770e10684e243a36f3d0218637.zip
[JIT] Fix for 3385583: Performance variance
Closes a window in which the "interpret-only" templace could get chained to an existing trace while the intended translation was under construction. Note that this CL also introduces some small, but fundamental changes in trace formation: 1. Previouosly, when an exception or other trace terminating event occurred during trace formation, the entire trace was abandoned. With this change, we instead end the trace at the last successful instruction. 2. We previously allowed multiple attempts (perhaps by multiple threads) to form a trace compilation request for a dalvik PC. This was done in an attempt to allow recovery from compiler failures. Now we enforce a new rule: only the thread that wins the race to allocate an entry in the JitTable will form the trace request. 3. In a (probably misguided) attempt avoid unnecessary contention, we previously allowed work order enqueue requests to be dropped if a requester did not aquire TableLock on first attempt (assuming that if the trace were hot, it would be requested again). Now we block on enqueue. Change-Id: I40ea4f1b012250219ca37d5c40c5f22cae2092f1
Diffstat (limited to 'vm/compiler/codegen/x86')
-rw-r--r--vm/compiler/codegen/x86/CodegenDriver.c5
1 files changed, 5 insertions, 0 deletions
diff --git a/vm/compiler/codegen/x86/CodegenDriver.c b/vm/compiler/codegen/x86/CodegenDriver.c
index 4f31563ea..e440e37ab 100644
--- a/vm/compiler/codegen/x86/CodegenDriver.c
+++ b/vm/compiler/codegen/x86/CodegenDriver.c
@@ -303,6 +303,11 @@ void *dvmCompilerGetInterpretTemplate()
templateEntryOffsets[TEMPLATE_INTERPRET]);
}
+JitInstructionSetType dvmCompilerGetInterpretTemplateSet()
+{
+ return DALVIK_JIT_X86;
+}
+
void dvmCompilerInitializeRegAlloc(CompilationUnit *cUnit)
{
}