summaryrefslogtreecommitdiffstats
path: root/vm/compiler/codegen/x86/ia32/ArchVariant.c
diff options
context:
space:
mode:
authorbuzbee <buzbee@google.com>2011-03-02 15:43:48 -0800
committerbuzbee <buzbee@google.com>2011-03-23 10:41:35 -0700
commit9a3147c7412f4794434b4c2604aa2ba784867774 (patch)
tree857eef2fd64a81a708d7c3b650b06b20794238e1 /vm/compiler/codegen/x86/ia32/ArchVariant.c
parentc28b465ea4d8d58d1bf3451b3f580a4197e52d9d (diff)
downloadandroid_dalvik-9a3147c7412f4794434b4c2604aa2ba784867774.tar.gz
android_dalvik-9a3147c7412f4794434b4c2604aa2ba784867774.tar.bz2
android_dalvik-9a3147c7412f4794434b4c2604aa2ba784867774.zip
Interpreter restructuring
This is a restructuring of the Dalvik ARM and x86 interpreters: o Combine the old portstd and portdbg interpreters into a single portable interpreter. o Add debug/profiling support to the fast (mterp) interpreters. o Delete old mechansim of switching between interpreters. Now, once you choose an interpreter at startup, you stick with it. o Allow JIT to co-exist with profiling & debugging (necessary for first-class support of debugging with the JIT active). o Adds single-step capability to the fast assembly interpreters without slowing them down (and, in fact, measurably improves their performance). o Remove old "polling for safe point" mechanism. Breakouts now achieved via modifying base of interpreter handler table. o Simplify interpeter control mechanism. o Allow thread-granularity control for profiling & debugging The primary motivation behind this change was to improve the responsiveness of debugging and profiling and to make it easier to add new debugging and profiling capabilities in the future. Instead of always bailing out to the slow debug portable interpreter, we can now stay in the fast interpreter. A nice side effect of the change is that the fast interpreters got a healthy speed boost because we were able to replace the polling safepoint check that involved a dozen or so instructions with a single table-base reload. When combined with the two earlier CLs related to this restructuring, we show a 5.6% performance improvement using libdvm_interp.so on the Checkers benchmark relative to Honeycomb. Change-Id: I8d37e866b3618def4e582fc73f1cf69ffe428f3c
Diffstat (limited to 'vm/compiler/codegen/x86/ia32/ArchVariant.c')
-rw-r--r--vm/compiler/codegen/x86/ia32/ArchVariant.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/vm/compiler/codegen/x86/ia32/ArchVariant.c b/vm/compiler/codegen/x86/ia32/ArchVariant.c
index 4ccd56f44..2abac8823 100644
--- a/vm/compiler/codegen/x86/ia32/ArchVariant.c
+++ b/vm/compiler/codegen/x86/ia32/ArchVariant.c
@@ -76,6 +76,9 @@ bool dvmCompilerArchVariantInit(void)
*/
assert((offsetof(Thread, jitToInterpEntries) +
sizeof(struct JitToInterpEntries)) <= 128);
+
+ // Make sure all threads have current values
+ dvmJitUpdateState();
return true;
}