diff options
author | Carl Shapiro <cshapiro@google.com> | 2011-06-07 17:32:01 -0700 |
---|---|---|
committer | Carl Shapiro <cshapiro@google.com> | 2011-06-07 17:32:01 -0700 |
commit | 0d92a4072c00434e95a03642a4944acf81a81cc3 (patch) | |
tree | 66ee19a61ed6c3f369e5c4bedfe99fffec13822c /vm/alloc/Verify.cpp | |
parent | a0f945f21dd38df48946fcea57d798a9692734b8 (diff) | |
download | android_dalvik-0d92a4072c00434e95a03642a4944acf81a81cc3.tar.gz android_dalvik-0d92a4072c00434e95a03642a4944acf81a81cc3.tar.bz2 android_dalvik-0d92a4072c00434e95a03642a4944acf81a81cc3.zip |
Favor Object* over void* for the heap bitmap interfaces.
Change-Id: I615dbff3e81a1128dc3ba43d6d426c370ae3abcf
Diffstat (limited to 'vm/alloc/Verify.cpp')
-rw-r--r-- | vm/alloc/Verify.cpp | 21 |
1 files changed, 10 insertions, 11 deletions
diff --git a/vm/alloc/Verify.cpp b/vm/alloc/Verify.cpp index 1a8307aff..6d830c7d7 100644 --- a/vm/alloc/Verify.cpp +++ b/vm/alloc/Verify.cpp @@ -38,16 +38,15 @@ static void dumpReferencesVisitor(void *pObj, void *arg) * Visitor applied to each bitmap element to search for things that * point to an object. Logs a message when a match is found. */ -static void dumpReferencesCallback(void *ptr, void *arg) +static void dumpReferencesCallback(Object *obj, void *arg) { - Object *obj = (Object *)arg; - if (ptr == obj) { + if (obj == (Object *)arg) { return; } - dvmVisitObject(dumpReferencesVisitor, (Object *)ptr, &obj); - if (obj == NULL) { - LOGD("Found %p in the heap @ %p", arg, ptr); - dvmDumpObject((Object *)ptr); + dvmVisitObject(dumpReferencesVisitor, obj, &arg); + if (arg == NULL) { + LOGD("Found %p in the heap @ %p", arg, obj); + dvmDumpObject(obj); } } @@ -108,8 +107,8 @@ static void verifyReference(void *addr, void *arg) */ void dvmVerifyObject(const Object *obj) { - Object *arg = (Object *)obj; - dvmVisitObject(verifyReference, (Object *)obj, &arg); + Object *arg = const_cast<Object*>(obj); + dvmVisitObject(verifyReference, arg, &arg); if (arg == NULL) { dumpReferences(obj); dvmAbort(); @@ -119,9 +118,9 @@ void dvmVerifyObject(const Object *obj) /* * Helper function to call dvmVerifyObject from a bitmap walker. */ -static void verifyBitmapCallback(void *ptr, void *arg) +static void verifyBitmapCallback(Object *obj, void *arg) { - dvmVerifyObject((Object *)ptr); + dvmVerifyObject(obj); } /* |