diff options
| author | Elliott Hughes <enh@google.com> | 2010-12-03 10:57:15 -0800 |
|---|---|---|
| committer | Elliott Hughes <enh@google.com> | 2010-12-03 10:57:15 -0800 |
| commit | 8a8286b2738f0e1cb2cc4cc0a76052cc965a8e38 (patch) | |
| tree | a3ba774190602e635f5f69af9138be2fdb1137b5 /vm/Native.c | |
| parent | c9cc157c98151966e1ddd3cc794416fd1efc39fd (diff) | |
| download | android_dalvik-8a8286b2738f0e1cb2cc4cc0a76052cc965a8e38.tar.gz android_dalvik-8a8286b2738f0e1cb2cc4cc0a76052cc965a8e38.tar.bz2 android_dalvik-8a8286b2738f0e1cb2cc4cc0a76052cc965a8e38.zip | |
Use dvmHumanReadableDescriptor in -Xjnitrace.
This made the output more readable while debugging a zlib issue.
Bug: 3220923
Change-Id: Ie360516a8a7a92b5b75fe70feb5c9722289bed78
Diffstat (limited to 'vm/Native.c')
| -rw-r--r-- | vm/Native.c | 21 |
1 files changed, 14 insertions, 7 deletions
diff --git a/vm/Native.c b/vm/Native.c index 1ebef2eed..8436e7f6b 100644 --- a/vm/Native.c +++ b/vm/Native.c @@ -848,27 +848,34 @@ void dvmLogNativeMethodEntry(const Method* method, const u4* args) *desc != '\0'); } + char* className = dvmHumanReadableDescriptor(method->clazz->descriptor); char* signature = dexProtoCopyMethodDescriptor(&method->prototype); - LOGI_NATIVE("-> %s.%s%s %s(%s)", method->clazz->descriptor, method->name, - signature, thisString, argsString); + LOGI_NATIVE("-> %s %s%s %s(%s)", className, method->name, signature, + thisString, argsString); + free(className); free(signature); } void dvmLogNativeMethodExit(const Method* method, Thread* self, const JValue returnValue) { + char* className = dvmHumanReadableDescriptor(method->clazz->descriptor); char* signature = dexProtoCopyMethodDescriptor(&method->prototype); if (dvmCheckException(self)) { Object* exception = dvmGetException(self); - LOGI_NATIVE("<- %s.%s%s threw %s", method->clazz->descriptor, - method->name, signature, exception->clazz->descriptor); + char* exceptionClassName = + dvmHumanReadableDescriptor(exception->clazz->descriptor); + LOGI_NATIVE("<- %s %s%s threw %s", className, + method->name, signature, exceptionClassName); + free(exceptionClassName); } else { char returnValueString[128] = { 0 }; char returnType = method->shorty[0]; appendValue(returnType, returnValue, - returnValueString, sizeof(returnValueString), false); - LOGI_NATIVE("<- %s.%s%s returned %s", method->clazz->descriptor, - method->name, signature, returnValueString); + returnValueString, sizeof(returnValueString), false); + LOGI_NATIVE("<- %s %s%s returned %s", className, + method->name, signature, returnValueString); } + free(className); free(signature); } |
