diff options
| author | Dan Willemsen <dwillemsen@google.com> | 2015-11-17 15:27:28 -0800 |
|---|---|---|
| committer | Dan Willemsen <dwillemsen@google.com> | 2015-11-17 19:05:07 -0800 |
| commit | c94a768a2a6998a34f76212912ce4013a7be47f5 (patch) | |
| tree | 0420066908ab1d2efaa14953a2a84282c18f4b33 /java/gen.go | |
| parent | 322a0a6b59dfe5d059b7075cd033dc0bcb49dc13 (diff) | |
| download | android_build_soong-c94a768a2a6998a34f76212912ce4013a7be47f5.tar.gz android_build_soong-c94a768a2a6998a34f76212912ce4013a7be47f5.tar.bz2 android_build_soong-c94a768a2a6998a34f76212912ce4013a7be47f5.zip | |
Use Rule-local implicit dependencies
Depends on https://github.com/google/blueprint/pull/78
This uses the new CommandDeps field to move implicit dependencies
embedded in the Command string next to the definition, instead of having
to specify them in every BuildParam struct. This should make it easier
to verify dependencies.
Change-Id: I2711b160920e22fa962a436e1f7041272166f50f
Diffstat (limited to 'java/gen.go')
| -rw-r--r-- | java/gen.go | 17 |
1 files changed, 9 insertions, 8 deletions
diff --git a/java/gen.go b/java/gen.go index 6e8313a9..f9898754 100644 --- a/java/gen.go +++ b/java/gen.go @@ -44,6 +44,7 @@ var ( aidl = pctx.StaticRule("aidl", blueprint.RuleParams{ Command: "$aidlCmd -d$depFile $aidlFlags $in $out", + CommandDeps: []string{"$aidlCmd"}, Description: "aidl $out", }, "depFile", "aidlFlags") @@ -51,12 +52,14 @@ var ( logtags = pctx.StaticRule("logtags", blueprint.RuleParams{ Command: "$logtagsCmd -o $out $in $allLogtagsFile", + CommandDeps: []string{"$logtagsCmd"}, Description: "logtags $out", }) mergeLogtags = pctx.StaticRule("mergeLogtags", blueprint.RuleParams{ Command: "$mergeLogtagsCmd -o $out $in", + CommandDeps: []string{"$mergeLogtagsCmd"}, Description: "merge logtags $out", }) ) @@ -68,10 +71,9 @@ func genAidl(ctx common.AndroidModuleContext, aidlFile, aidlFlags string) string depFile := javaFile + ".d" ctx.Build(pctx, blueprint.BuildParams{ - Rule: aidl, - Outputs: []string{javaFile}, - Inputs: []string{aidlFile}, - Implicits: []string{"$aidlCmd"}, + Rule: aidl, + Outputs: []string{javaFile}, + Inputs: []string{aidlFile}, Args: map[string]string{ "depFile": depFile, "aidlFlags": aidlFlags, @@ -87,10 +89,9 @@ func genLogtags(ctx common.AndroidModuleContext, logtagsFile string) string { javaFile = pathtools.ReplaceExtension(javaFile, "java") ctx.Build(pctx, blueprint.BuildParams{ - Rule: logtags, - Outputs: []string{javaFile}, - Inputs: []string{logtagsFile}, - Implicits: []string{"$logtagsCmd"}, + Rule: logtags, + Outputs: []string{javaFile}, + Inputs: []string{logtagsFile}, }) return javaFile |