Replace ReplaceExtension regexp with manual string operations

regexp is overkill for a simple extension replacement, just find
the last '.' and add the new extension after it.  Saves 5% cpu time
on one workload.

Change-Id: Ic299c9ec5132d15bbea2c9c7778c000d6fdf509a

1 files changed, 6 insertions, 6 deletions

diff --git a/pathtools/lists.go b/pathtools/lists.go
index 36be1e7..fbde88a 100644
--- a/pathtools/lists.go
+++ b/pathtools/lists.go
@@ -16,11 +16,7 @@ package pathtools
 
 import (
 	"path/filepath"
-	"regexp"
-)
-
-var (
-	replaceRegexp = regexp.MustCompile(`\.[^\.]+$`)
+	"strings"
 )
 
 // PrefixPaths returns a list of paths consisting of prefix joined with each
@@ -43,5 +39,9 @@ func ReplaceExtensions(paths []string, extension string) []string {
 }
 
 func ReplaceExtension(path string, extension string) string {
-	return replaceRegexp.ReplaceAllString(path, "."+extension)
+	dot := strings.LastIndex(path, ".")
+	if dot == -1 {
+		return path
+	}
+	return path[:dot+1] + extension
 }