diff options
author | Elliott Hughes <enh@google.com> | 2013-10-15 11:23:57 -0700 |
---|---|---|
committer | Elliott Hughes <enh@google.com> | 2013-10-15 11:23:57 -0700 |
commit | 19e62325c268a668692e2b65fde2284079f369aa (patch) | |
tree | 364b827a4b7504b5f00c18a2f1bafc5b7d1d83b8 /libc/bionic/pthread_sigmask.cpp | |
parent | abeafbd6d5e11044dd305e48134bc3d84319a3da (diff) | |
download | android_bionic-19e62325c268a668692e2b65fde2284079f369aa.tar.gz android_bionic-19e62325c268a668692e2b65fde2284079f369aa.tar.bz2 android_bionic-19e62325c268a668692e2b65fde2284079f369aa.zip |
Clean up the sigprocmask/pthread_sigmask implementation.
Let's have both use rt_sigprocmask, like in glibc. The 64-bit ABIs
can share the same code as the 32-bit ABIs.
Also, let's test the return side of these calls, not just the
setting.
Bug: 11069919
Change-Id: I11da99f85b5b481870943c520d05ec929b15eddb
Diffstat (limited to 'libc/bionic/pthread_sigmask.cpp')
-rw-r--r-- | libc/bionic/pthread_sigmask.cpp | 28 |
1 files changed, 3 insertions, 25 deletions
diff --git a/libc/bionic/pthread_sigmask.cpp b/libc/bionic/pthread_sigmask.cpp index e4e1b2b98..79f31a145 100644 --- a/libc/bionic/pthread_sigmask.cpp +++ b/libc/bionic/pthread_sigmask.cpp @@ -31,31 +31,9 @@ #include <signal.h> #include "private/ErrnoRestorer.h" -#include "private/kernel_sigset_t.h" -extern "C" int __rt_sigprocmask(int, const kernel_sigset_t*, kernel_sigset_t*, size_t); - -int pthread_sigmask(int how, const sigset_t* iset, sigset_t* oset) { +int pthread_sigmask(int how, const sigset_t* new_set, sigset_t* old_set) { ErrnoRestorer errno_restorer; - - // 'in_set_ptr' is the second parameter to __rt_sigprocmask. It must be NULL - // if 'set' is NULL to ensure correct semantics (which in this case would - // be to ignore 'how' and return the current signal set into 'oset'). - kernel_sigset_t in_set; - kernel_sigset_t* in_set_ptr = NULL; - if (iset != NULL) { - in_set.set(iset); - in_set_ptr = &in_set; - } - - kernel_sigset_t out_set; - if (__rt_sigprocmask(how, in_set_ptr, &out_set, sizeof(out_set)) == -1) { - return errno; - } - - if (oset != NULL) { - *oset = out_set.bionic; - } - - return 0; + int result = sigprocmask(how, new_set, old_set); + return (result == -1) ? errno : 0; } |