diff options
| author | Mathieu Chartier <mathieuc@google.com> | 2014-08-29 18:16:58 -0700 |
|---|---|---|
| committer | Mathieu Chartier <mathieuc@google.com> | 2014-09-02 14:39:49 -0700 |
| commit | cdfd39f579574a75b98e7ad48c69826b00361b27 (patch) | |
| tree | 0f057472d19bf290766e20ea3ad63d0b28ee83a1 /runtime/transaction.h | |
| parent | 9a4f02722051955e536d6aacb776d637a6713545 (diff) | |
| download | android_art-cdfd39f579574a75b98e7ad48c69826b00361b27.tar.gz android_art-cdfd39f579574a75b98e7ad48c69826b00361b27.tar.bz2 android_art-cdfd39f579574a75b98e7ad48c69826b00361b27.zip | |
Change intern table to unordered set.
Intern table active used bytes goes from 430k to 317k on system
server. Similar %wise savings on other apps.
Bug: 16238192
(cherry picked from commit d910fcef539e12ab181e56ec80684f39c4e95733)
Change-Id: Ic70395124435c6f420a77e6d8639404a160f395a
Diffstat (limited to 'runtime/transaction.h')
| -rw-r--r-- | runtime/transaction.h | 13 |
1 files changed, 6 insertions, 7 deletions
diff --git a/runtime/transaction.h b/runtime/transaction.h index 63900493a5..21d3c98054 100644 --- a/runtime/transaction.h +++ b/runtime/transaction.h @@ -69,16 +69,16 @@ class Transaction { SHARED_LOCKS_REQUIRED(Locks::mutator_lock_); // Record intern string table changes. - void RecordStrongStringInsertion(mirror::String* s, uint32_t hash_code) + void RecordStrongStringInsertion(mirror::String* s) EXCLUSIVE_LOCKS_REQUIRED(Locks::intern_table_lock_) LOCKS_EXCLUDED(log_lock_); - void RecordWeakStringInsertion(mirror::String* s, uint32_t hash_code) + void RecordWeakStringInsertion(mirror::String* s) EXCLUSIVE_LOCKS_REQUIRED(Locks::intern_table_lock_) LOCKS_EXCLUDED(log_lock_); - void RecordStrongStringRemoval(mirror::String* s, uint32_t hash_code) + void RecordStrongStringRemoval(mirror::String* s) EXCLUSIVE_LOCKS_REQUIRED(Locks::intern_table_lock_) LOCKS_EXCLUDED(log_lock_); - void RecordWeakStringRemoval(mirror::String* s, uint32_t hash_code) + void RecordWeakStringRemoval(mirror::String* s) EXCLUSIVE_LOCKS_REQUIRED(Locks::intern_table_lock_) LOCKS_EXCLUDED(log_lock_); @@ -163,8 +163,8 @@ class Transaction { kInsert, kRemove }; - InternStringLog(mirror::String* s, uint32_t hash_code, StringKind kind, StringOp op) - : str_(s), hash_code_(hash_code), string_kind_(kind), string_op_(op) { + InternStringLog(mirror::String* s, StringKind kind, StringOp op) + : str_(s), string_kind_(kind), string_op_(op) { DCHECK(s != nullptr); } @@ -175,7 +175,6 @@ class Transaction { private: mirror::String* str_; - uint32_t hash_code_; StringKind string_kind_; StringOp string_op_; }; |