diff options
| author | Mathieu Chartier <mathieuc@google.com> | 2015-01-14 14:55:47 -0800 |
|---|---|---|
| committer | Mathieu Chartier <mathieuc@google.com> | 2015-01-15 12:23:28 -0800 |
| commit | e34fa1df67fbe0173b4ea9abddcc3ae3d0537037 (patch) | |
| tree | a5148f079b5671a95f60910c41981ebf91db3a02 /runtime/thread_list.h | |
| parent | 9f06b1946ae3ef1d2fd75bbf7f0a288bc611fe58 (diff) | |
| download | android_art-e34fa1df67fbe0173b4ea9abddcc3ae3d0537037.tar.gz android_art-e34fa1df67fbe0173b4ea9abddcc3ae3d0537037.tar.bz2 android_art-e34fa1df67fbe0173b4ea9abddcc3ae3d0537037.zip | |
Print more info in MarkSweep::VerifyRoot
Refactored old root callback to use a new class called RootInfo.
RootInfo contains all the relevant info related to the root
associated with the callback. The MarkSweep::VerifyRoot function
now uses this info to print the StackVisitor's described location
if the GC root is of the type kRootJavaFrame.
Some other cleanup.
Example output:
E/art (12167): Tried to mark 0x123 not contained by any spaces
E/art (12167): Attempting see if it's a bad root
E/art (12167): Found invalid root: 0x123 with type RootJavaFrame
E/art (12167): Location=Visiting method
'void java.lang.Runtime.gc()' at dex PC 0xffffffff (native PC 0x0)
vreg=0
(cherry picked from commit 12f7423a2bb4bfab76700d84eb6d4338d211983a)
Bug: 18588862
Change-Id: Ic5a2781f704e931265ffb3621c2eab4b2e25f60f
Diffstat (limited to 'runtime/thread_list.h')
| -rw-r--r-- | runtime/thread_list.h | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/runtime/thread_list.h b/runtime/thread_list.h index 43c065ae0a..6751bf5a86 100644 --- a/runtime/thread_list.h +++ b/runtime/thread_list.h @@ -19,6 +19,7 @@ #include "base/histogram.h" #include "base/mutex.h" +#include "gc_root.h" #include "jni.h" #include "object_callbacks.h" @@ -125,9 +126,6 @@ class ThreadList { void VisitRoots(RootCallback* callback, void* arg) const SHARED_LOCKS_REQUIRED(Locks::mutator_lock_); - void VerifyRoots(VerifyRootCallback* callback, void* arg) const - SHARED_LOCKS_REQUIRED(Locks::mutator_lock_); - // Return a copy of the thread list. std::list<Thread*> GetList() EXCLUSIVE_LOCKS_REQUIRED(Locks::thread_list_lock_) { return list_; |