diff options
author | Andreas Gampe <agampe@google.com> | 2014-09-09 19:53:48 -0700 |
---|---|---|
committer | Andreas Gampe <agampe@google.com> | 2014-09-10 15:50:42 -0700 |
commit | 928f72bd75c385ba2708c58521171a77264d4486 (patch) | |
tree | 86f7fa7a21e3f6d21c9cab2d4fffe4aaa42dc458 /runtime/runtime.h | |
parent | dab9ed52f2df7189b81ccf3237b030ff638a492a (diff) | |
download | android_art-928f72bd75c385ba2708c58521171a77264d4486.tar.gz android_art-928f72bd75c385ba2708c58521171a77264d4486.tar.bz2 android_art-928f72bd75c385ba2708c58521171a77264d4486.zip |
ART: Fix things for valgrind
Wire up valgrind gtests. Add valgrind-test-art-host, currently
only depending on valgrind-test-art-host-gtest32.
Fix an Alloc setting to allow running valgrind.
Refactor the fault handler to manage (and correctly release) the
handlers.
Fix minor failure-case leaks exposed by tests.
Failing tests:
The optimizing compiler is leaking non-arena-ed structures
(e.g., assembler buffers), as code generators are not destroyed.
The solution has been moved to a follow-up CL.
Note: All 64b tests are failing as we cannot allocate a heap.
Change-Id: I7f854cfd098d9f68107ce492363e7dba9a82b9fa
Diffstat (limited to 'runtime/runtime.h')
-rw-r--r-- | runtime/runtime.h | 13 |
1 files changed, 1 insertions, 12 deletions
diff --git a/runtime/runtime.h b/runtime/runtime.h index a0993ca91e..9df14538e9 100644 --- a/runtime/runtime.h +++ b/runtime/runtime.h @@ -463,16 +463,8 @@ class Runtime { void AddCurrentRuntimeFeaturesAsDex2OatArguments(std::vector<std::string>* arg_vector) const; - bool ExplicitNullChecks() const { - return null_pointer_handler_ == nullptr; - } - - bool ExplicitSuspendChecks() const { - return suspend_handler_ == nullptr; - } - bool ExplicitStackOverflowChecks() const { - return stack_overflow_handler_ == nullptr; + return !implicit_so_checks_; } bool IsVerificationEnabled() const { @@ -636,9 +628,6 @@ class Runtime { // Transaction used for pre-initializing classes at compilation time. Transaction* preinitialization_transaction_; - NullPointerHandler* null_pointer_handler_; - SuspensionHandler* suspend_handler_; - StackOverflowHandler* stack_overflow_handler_; // If false, verification is disabled. True by default. bool verify_; |