diff options
author | Mathieu Chartier <mathieuc@google.com> | 2015-03-27 14:35:38 -0700 |
---|---|---|
committer | Mathieu Chartier <mathieuc@google.com> | 2015-04-10 12:57:27 -0700 |
commit | c785344b87221f5e4e6473e5b762e4e61fe65dcf (patch) | |
tree | cd32ad2c2604596a18926f04d4c313dab255ecfd /runtime/mirror/dex_cache-inl.h | |
parent | a29d93b380c9aeb8270e281aefbdd0c77a430d43 (diff) | |
download | android_art-c785344b87221f5e4e6473e5b762e4e61fe65dcf.tar.gz android_art-c785344b87221f5e4e6473e5b762e4e61fe65dcf.tar.bz2 android_art-c785344b87221f5e4e6473e5b762e4e61fe65dcf.zip |
Move ArtField to native
Add linear alloc. Moved ArtField to be native object. Changed image
writer to put ArtFields after the mirror section.
Savings:
2MB on low ram devices
4MB on normal devices
Total PSS measurements before (normal N5, 95s after shell start):
Image size: 7729152 bytes
23112 kB: .NonMoving
23212 kB: .NonMoving
22868 kB: .NonMoving
23072 kB: .NonMoving
22836 kB: .NonMoving
19618 kB: .Zygote
19850 kB: .Zygote
19623 kB: .Zygote
19924 kB: .Zygote
19612 kB: .Zygote
Avg: 42745.4 kB
After:
Image size: 7462912 bytes
17440 kB: .NonMoving
16776 kB: .NonMoving
16804 kB: .NonMoving
17812 kB: .NonMoving
16820 kB: .NonMoving
18788 kB: .Zygote
18856 kB: .Zygote
19064 kB: .Zygote
18841 kB: .Zygote
18629 kB: .Zygote
3499 kB: .LinearAlloc
3408 kB: .LinearAlloc
3424 kB: .LinearAlloc
3600 kB: .LinearAlloc
3436 kB: .LinearAlloc
Avg: 39439.4 kB
No reflection performance changes.
Bug: 19264997
Bug: 17643507
Change-Id: I10c73a37913332080aeb978c7c94713bdfe4fe1c
Diffstat (limited to 'runtime/mirror/dex_cache-inl.h')
-rw-r--r-- | runtime/mirror/dex_cache-inl.h | 38 |
1 files changed, 33 insertions, 5 deletions
diff --git a/runtime/mirror/dex_cache-inl.h b/runtime/mirror/dex_cache-inl.h index 6758e22a20..1cb437e8ea 100644 --- a/runtime/mirror/dex_cache-inl.h +++ b/runtime/mirror/dex_cache-inl.h @@ -19,6 +19,7 @@ #include "dex_cache.h" +#include "art_field-inl.h" #include "base/logging.h" #include "mirror/class.h" #include "runtime.h" @@ -35,12 +36,11 @@ inline ArtMethod* DexCache::GetResolvedMethod(uint32_t method_idx) SHARED_LOCKS_REQUIRED(Locks::mutator_lock_) { ArtMethod* method = GetResolvedMethods()->Get(method_idx); // Hide resolution trampoline methods from the caller - if (method != NULL && method->IsRuntimeMethod()) { - DCHECK(method == Runtime::Current()->GetResolutionMethod()); - return NULL; - } else { - return method; + if (method != nullptr && method->IsRuntimeMethod()) { + DCHECK_EQ(method, Runtime::Current()->GetResolutionMethod()); + return nullptr; } + return method; } inline void DexCache::SetResolvedType(uint32_t type_idx, Class* resolved) { @@ -49,6 +49,34 @@ inline void DexCache::SetResolvedType(uint32_t type_idx, Class* resolved) { GetResolvedTypes()->Set(type_idx, resolved); } +inline ArtField* DexCache::GetResolvedField(uint32_t idx, size_t ptr_size) { + ArtField* field = nullptr; + if (ptr_size == 8) { + field = reinterpret_cast<ArtField*>( + static_cast<uintptr_t>(GetResolvedFields()->AsLongArray()->GetWithoutChecks(idx))); + } else { + DCHECK_EQ(ptr_size, 4u); + field = reinterpret_cast<ArtField*>( + static_cast<uintptr_t>(GetResolvedFields()->AsIntArray()->GetWithoutChecks(idx))); + } + if (field == nullptr || field->GetDeclaringClass()->IsErroneous()) { + return nullptr; + } + return field; +} + +inline void DexCache::SetResolvedField(uint32_t idx, ArtField* field, size_t ptr_size) { + if (ptr_size == 8) { + GetResolvedFields()->AsLongArray()->Set( + idx, static_cast<uint64_t>(reinterpret_cast<uintptr_t>(field))); + } else { + DCHECK_EQ(ptr_size, 4u); + CHECK_LE(reinterpret_cast<uintptr_t>(field), 0xFFFFFFFF); + GetResolvedFields()->AsIntArray()->Set( + idx, static_cast<uint32_t>(reinterpret_cast<uintptr_t>(field))); + } +} + } // namespace mirror } // namespace art |