diff options
| author | Ian Rogers <irogers@google.com> | 2013-10-31 12:37:54 -0700 |
|---|---|---|
| committer | Ian Rogers <irogers@google.com> | 2013-10-31 12:37:54 -0700 |
| commit | cf5077ac14f0922b6104a8a03fd66d97a490a3dd (patch) | |
| tree | e5a4c42b87f06dcf5dd8bce1de992d3e2a2430fa /runtime/dex_file.h | |
| parent | 1b8cb967143d5c46db1db8ac940a73d111be3628 (diff) | |
| download | android_art-cf5077ac14f0922b6104a8a03fd66d97a490a3dd.tar.gz android_art-cf5077ac14f0922b6104a8a03fd66d97a490a3dd.tar.bz2 android_art-cf5077ac14f0922b6104a8a03fd66d97a490a3dd.zip | |
Remove unused length from DexFile GetString calls.
Address extra review comments from commit
dfb325e0ddd746cd8f7c2e3723b3a573eb7cc111.
Change-Id: If76e81e7af5870431901de0bf561e0f827435fe3
Diffstat (limited to 'runtime/dex_file.h')
| -rw-r--r-- | runtime/dex_file.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/runtime/dex_file.h b/runtime/dex_file.h index 7901ea7447..a9c24e66c1 100644 --- a/runtime/dex_file.h +++ b/runtime/dex_file.h @@ -575,6 +575,7 @@ class DexFile { return StringDataByIdx(GetProtoId(method_id.proto_idx_).shorty_idx_); } const char* GetMethodShorty(const MethodId& method_id, uint32_t* length) const { + // Using the UTF16 length is safe here as shorties are guaranteed to be ASCII characters. return StringDataAndUtf16LengthByIdx(GetProtoId(method_id.proto_idx_).shorty_idx_, length); } // Returns the number of class definitions in the .dex file. |