diff options
| author | Vladimir Marko <vmarko@google.com> | 2014-05-02 14:40:15 +0100 |
|---|---|---|
| committer | Vladimir Marko <vmarko@google.com> | 2014-05-13 11:43:22 +0100 |
| commit | 7624d25dad2d1ba25969ae704fccf68649103ae5 (patch) | |
| tree | de72194b76a4e23e0b15ec4085447ae7e4425815 /runtime/arch | |
| parent | e1910f1d802dff79bba5ef61e1c4fd0b95f6e5b0 (diff) | |
| download | android_art-7624d25dad2d1ba25969ae704fccf68649103ae5.tar.gz android_art-7624d25dad2d1ba25969ae704fccf68649103ae5.tar.bz2 android_art-7624d25dad2d1ba25969ae704fccf68649103ae5.zip | |
Move quick frame info to OatQuickMethodHeader.
Rename OatMethodHeader to OatQuickMethodHeader, move frame
info from OatMethodOffsets to OatQuickMethodHeader. Retrieve
the info from other places for non-quick methods (portable
compiled bytecode or jni stub, generic jni, runtime,
abstract and proxy).
This change has a libcore/ companion CL
"Remove ArtMethod's quick fields for frame size and spills."
https://android-review.googlesource.com/94164
Bug: 11767815
Change-Id: I0e31a7875d76732e1ec479c86b9b5ca01203507f
Diffstat (limited to 'runtime/arch')
| -rw-r--r-- | runtime/arch/arch_test.cc | 12 | ||||
| -rw-r--r-- | runtime/arch/arm/context_arm.cc | 20 | ||||
| -rw-r--r-- | runtime/arch/arm/quick_method_frame_info_arm.h | 68 | ||||
| -rw-r--r-- | runtime/arch/arm64/context_arm64.cc | 21 | ||||
| -rw-r--r-- | runtime/arch/arm64/quick_method_frame_info_arm64.h | 89 | ||||
| -rw-r--r-- | runtime/arch/mips/context_mips.cc | 20 | ||||
| -rw-r--r-- | runtime/arch/mips/quick_method_frame_info_mips.h | 56 | ||||
| -rw-r--r-- | runtime/arch/stub_test.cc | 3 | ||||
| -rw-r--r-- | runtime/arch/x86/context_x86.cc | 14 | ||||
| -rw-r--r-- | runtime/arch/x86/quick_method_frame_info_x86.h | 51 | ||||
| -rw-r--r-- | runtime/arch/x86_64/context_x86_64.cc | 20 | ||||
| -rw-r--r-- | runtime/arch/x86_64/quick_method_frame_info_x86_64.h | 63 |
12 files changed, 384 insertions, 53 deletions
diff --git a/runtime/arch/arch_test.cc b/runtime/arch/arch_test.cc index c285088fe4..b957d58601 100644 --- a/runtime/arch/arch_test.cc +++ b/runtime/arch/arch_test.cc @@ -18,6 +18,7 @@ #include "common_runtime_test.h" #include "mirror/art_method.h" +#include "quick/quick_method_frame_info.h" namespace art { @@ -30,10 +31,13 @@ class ArchTest : public CommonRuntimeTest { Thread* t = Thread::Current(); t->TransitionFromSuspendedToRunnable(); // So we can create callee-save methods. - mirror::ArtMethod* save_method = r->CreateCalleeSaveMethod(isa, type); - EXPECT_EQ(save_method->GetFrameSizeInBytes(), save_size) << "Expected and real size differs for " - << type << " core spills=" << std::hex << save_method->GetCoreSpillMask() << " fp spills=" - << save_method->GetFpSpillMask() << std::dec; + r->SetInstructionSet(isa); + mirror::ArtMethod* save_method = r->CreateCalleeSaveMethod(type); + r->SetCalleeSaveMethod(save_method, type); + QuickMethodFrameInfo frame_info = save_method->GetQuickFrameInfo(); + EXPECT_EQ(frame_info.FrameSizeInBytes(), save_size) << "Expected and real size differs for " + << type << " core spills=" << std::hex << frame_info.CoreSpillMask() << " fp spills=" + << frame_info.FpSpillMask() << std::dec; t->TransitionFromRunnableToSuspended(ThreadState::kNative); // So we can shut down. } diff --git a/runtime/arch/arm/context_arm.cc b/runtime/arch/arm/context_arm.cc index 0e1b25eb85..6a337b3038 100644 --- a/runtime/arch/arm/context_arm.cc +++ b/runtime/arch/arm/context_arm.cc @@ -16,8 +16,9 @@ #include "context_arm.h" -#include "mirror/art_method.h" +#include "mirror/art_method-inl.h" #include "mirror/object-inl.h" +#include "quick/quick_method_frame_info.h" #include "stack.h" #include "thread.h" @@ -42,17 +43,15 @@ void ArmContext::Reset() { void ArmContext::FillCalleeSaves(const StackVisitor& fr) { mirror::ArtMethod* method = fr.GetMethod(); - uint32_t core_spills = method->GetCoreSpillMask(); - uint32_t fp_core_spills = method->GetFpSpillMask(); - size_t spill_count = POPCOUNT(core_spills); - size_t fp_spill_count = POPCOUNT(fp_core_spills); - size_t frame_size = method->GetFrameSizeInBytes(); + const QuickMethodFrameInfo frame_info = method->GetQuickFrameInfo(); + size_t spill_count = POPCOUNT(frame_info.CoreSpillMask()); + size_t fp_spill_count = POPCOUNT(frame_info.FpSpillMask()); if (spill_count > 0) { // Lowest number spill is farthest away, walk registers and fill into context int j = 1; for (size_t i = 0; i < kNumberOfCoreRegisters; i++) { - if (((core_spills >> i) & 1) != 0) { - gprs_[i] = fr.CalleeSaveAddress(spill_count - j, frame_size); + if (((frame_info.CoreSpillMask() >> i) & 1) != 0) { + gprs_[i] = fr.CalleeSaveAddress(spill_count - j, frame_info.FrameSizeInBytes()); j++; } } @@ -61,8 +60,9 @@ void ArmContext::FillCalleeSaves(const StackVisitor& fr) { // Lowest number spill is farthest away, walk registers and fill into context int j = 1; for (size_t i = 0; i < kNumberOfSRegisters; i++) { - if (((fp_core_spills >> i) & 1) != 0) { - fprs_[i] = fr.CalleeSaveAddress(spill_count + fp_spill_count - j, frame_size); + if (((frame_info.FpSpillMask() >> i) & 1) != 0) { + fprs_[i] = fr.CalleeSaveAddress(spill_count + fp_spill_count - j, + frame_info.FrameSizeInBytes()); j++; } } diff --git a/runtime/arch/arm/quick_method_frame_info_arm.h b/runtime/arch/arm/quick_method_frame_info_arm.h new file mode 100644 index 0000000000..8d08190dc7 --- /dev/null +++ b/runtime/arch/arm/quick_method_frame_info_arm.h @@ -0,0 +1,68 @@ +/* + * Copyright (C) 2014 The Android Open Source Project + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#ifndef ART_RUNTIME_ARCH_ARM_QUICK_METHOD_FRAME_INFO_ARM_H_ +#define ART_RUNTIME_ARCH_ARM_QUICK_METHOD_FRAME_INFO_ARM_H_ + +#include "quick/quick_method_frame_info.h" +#include "registers_arm.h" +#include "runtime.h" // for Runtime::CalleeSaveType. + +namespace art { +namespace arm { + +static constexpr uint32_t kArmCalleeSaveRefSpills = + (1 << art::arm::R5) | (1 << art::arm::R6) | (1 << art::arm::R7) | (1 << art::arm::R8) | + (1 << art::arm::R10) | (1 << art::arm::R11); +static constexpr uint32_t kArmCalleeSaveArgSpills = + (1 << art::arm::R1) | (1 << art::arm::R2) | (1 << art::arm::R3); +static constexpr uint32_t kArmCalleeSaveAllSpills = + (1 << art::arm::R4) | (1 << art::arm::R9); +static constexpr uint32_t kArmCalleeSaveFpAllSpills = + (1 << art::arm::S0) | (1 << art::arm::S1) | (1 << art::arm::S2) | (1 << art::arm::S3) | + (1 << art::arm::S4) | (1 << art::arm::S5) | (1 << art::arm::S6) | (1 << art::arm::S7) | + (1 << art::arm::S8) | (1 << art::arm::S9) | (1 << art::arm::S10) | (1 << art::arm::S11) | + (1 << art::arm::S12) | (1 << art::arm::S13) | (1 << art::arm::S14) | (1 << art::arm::S15) | + (1 << art::arm::S16) | (1 << art::arm::S17) | (1 << art::arm::S18) | (1 << art::arm::S19) | + (1 << art::arm::S20) | (1 << art::arm::S21) | (1 << art::arm::S22) | (1 << art::arm::S23) | + (1 << art::arm::S24) | (1 << art::arm::S25) | (1 << art::arm::S26) | (1 << art::arm::S27) | + (1 << art::arm::S28) | (1 << art::arm::S29) | (1 << art::arm::S30) | (1 << art::arm::S31); + +constexpr uint32_t ArmCalleeSaveCoreSpills(Runtime::CalleeSaveType type) { + return kArmCalleeSaveRefSpills | (type == Runtime::kRefsAndArgs ? kArmCalleeSaveArgSpills : 0) | + (type == Runtime::kSaveAll ? kArmCalleeSaveAllSpills : 0) | (1 << art::arm::LR); +} + +constexpr uint32_t ArmCalleeSaveFpSpills(Runtime::CalleeSaveType type) { + return type == Runtime::kSaveAll ? kArmCalleeSaveFpAllSpills : 0; +} + +constexpr uint32_t ArmCalleeSaveFrameSize(Runtime::CalleeSaveType type) { + return RoundUp((POPCOUNT(ArmCalleeSaveCoreSpills(type)) /* gprs */ + + POPCOUNT(ArmCalleeSaveFpSpills(type)) /* fprs */ + + 1 /* Method* */) * kArmPointerSize, kStackAlignment); +} + +constexpr QuickMethodFrameInfo ArmCalleeSaveMethodFrameInfo(Runtime::CalleeSaveType type) { + return QuickMethodFrameInfo(ArmCalleeSaveFrameSize(type), + ArmCalleeSaveCoreSpills(type), + ArmCalleeSaveFpSpills(type)); +} + +} // namespace arm +} // namespace art + +#endif // ART_RUNTIME_ARCH_ARM_QUICK_METHOD_FRAME_INFO_ARM_H_ diff --git a/runtime/arch/arm64/context_arm64.cc b/runtime/arch/arm64/context_arm64.cc index 0890fa9d33..fae44af3ce 100644 --- a/runtime/arch/arm64/context_arm64.cc +++ b/runtime/arch/arm64/context_arm64.cc @@ -18,8 +18,9 @@ #include "context_arm64.h" -#include "mirror/art_method.h" +#include "mirror/art_method-inl.h" #include "mirror/object-inl.h" +#include "quick/quick_method_frame_info.h" #include "stack.h" #include "thread.h" @@ -45,18 +46,15 @@ void Arm64Context::Reset() { void Arm64Context::FillCalleeSaves(const StackVisitor& fr) { mirror::ArtMethod* method = fr.GetMethod(); - uint32_t core_spills = method->GetCoreSpillMask(); - uint32_t fp_core_spills = method->GetFpSpillMask(); - size_t spill_count = POPCOUNT(core_spills); - size_t fp_spill_count = POPCOUNT(fp_core_spills); - size_t frame_size = method->GetFrameSizeInBytes(); - + const QuickMethodFrameInfo frame_info = method->GetQuickFrameInfo(); + size_t spill_count = POPCOUNT(frame_info.CoreSpillMask()); + size_t fp_spill_count = POPCOUNT(frame_info.FpSpillMask()); if (spill_count > 0) { // Lowest number spill is farthest away, walk registers and fill into context. int j = 1; for (size_t i = 0; i < kNumberOfCoreRegisters; i++) { - if (((core_spills >> i) & 1) != 0) { - gprs_[i] = fr.CalleeSaveAddress(spill_count - j, frame_size); + if (((frame_info.CoreSpillMask() >> i) & 1) != 0) { + gprs_[i] = fr.CalleeSaveAddress(spill_count - j, frame_info.FrameSizeInBytes()); j++; } } @@ -66,8 +64,9 @@ void Arm64Context::FillCalleeSaves(const StackVisitor& fr) { // Lowest number spill is farthest away, walk registers and fill into context. int j = 1; for (size_t i = 0; i < kNumberOfDRegisters; i++) { - if (((fp_core_spills >> i) & 1) != 0) { - fprs_[i] = fr.CalleeSaveAddress(spill_count + fp_spill_count - j, frame_size); + if (((frame_info.FpSpillMask() >> i) & 1) != 0) { + fprs_[i] = fr.CalleeSaveAddress(spill_count + fp_spill_count - j, + frame_info.FrameSizeInBytes()); j++; } } diff --git a/runtime/arch/arm64/quick_method_frame_info_arm64.h b/runtime/arch/arm64/quick_method_frame_info_arm64.h new file mode 100644 index 0000000000..cb830acdea --- /dev/null +++ b/runtime/arch/arm64/quick_method_frame_info_arm64.h @@ -0,0 +1,89 @@ +/* + * Copyright (C) 2014 The Android Open Source Project + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#ifndef ART_RUNTIME_ARCH_ARM64_QUICK_METHOD_FRAME_INFO_ARM64_H_ +#define ART_RUNTIME_ARCH_ARM64_QUICK_METHOD_FRAME_INFO_ARM64_H_ + +#include "quick/quick_method_frame_info.h" +#include "registers_arm64.h" +#include "runtime.h" // for Runtime::CalleeSaveType. + +namespace art { +namespace arm64 { + +// Callee saved registers +static constexpr uint32_t kArm64CalleeSaveRefSpills = + (1 << art::arm64::X19) | (1 << art::arm64::X20) | (1 << art::arm64::X21) | + (1 << art::arm64::X22) | (1 << art::arm64::X23) | (1 << art::arm64::X24) | + (1 << art::arm64::X25) | (1 << art::arm64::X26) | (1 << art::arm64::X27) | + (1 << art::arm64::X28); +// X0 is the method pointer. Not saved. +static constexpr uint32_t kArm64CalleeSaveArgSpills = + (1 << art::arm64::X1) | (1 << art::arm64::X2) | (1 << art::arm64::X3) | + (1 << art::arm64::X4) | (1 << art::arm64::X5) | (1 << art::arm64::X6) | + (1 << art::arm64::X7); +// TODO This is conservative. Only ALL should include the thread register. +// The thread register is not preserved by the aapcs64. +// LR is always saved. +static constexpr uint32_t kArm64CalleeSaveAllSpills = 0; // (1 << art::arm64::LR); + +// Save callee-saved floating point registers. Rest are scratch/parameters. +static constexpr uint32_t kArm64CalleeSaveFpArgSpills = + (1 << art::arm64::D0) | (1 << art::arm64::D1) | (1 << art::arm64::D2) | + (1 << art::arm64::D3) | (1 << art::arm64::D4) | (1 << art::arm64::D5) | + (1 << art::arm64::D6) | (1 << art::arm64::D7); +static constexpr uint32_t kArm64CalleeSaveFpRefSpills = + (1 << art::arm64::D8) | (1 << art::arm64::D9) | (1 << art::arm64::D10) | + (1 << art::arm64::D11) | (1 << art::arm64::D12) | (1 << art::arm64::D13) | + (1 << art::arm64::D14) | (1 << art::arm64::D15); +static constexpr uint32_t kArm64FpAllSpills = + kArm64CalleeSaveFpArgSpills | + (1 << art::arm64::D16) | (1 << art::arm64::D17) | (1 << art::arm64::D18) | + (1 << art::arm64::D19) | (1 << art::arm64::D20) | (1 << art::arm64::D21) | + (1 << art::arm64::D22) | (1 << art::arm64::D23) | (1 << art::arm64::D24) | + (1 << art::arm64::D25) | (1 << art::arm64::D26) | (1 << art::arm64::D27) | + (1 << art::arm64::D28) | (1 << art::arm64::D29) | (1 << art::arm64::D30) | + (1 << art::arm64::D31); + +constexpr uint32_t Arm64CalleeSaveCoreSpills(Runtime::CalleeSaveType type) { + return kArm64CalleeSaveRefSpills | + (type == Runtime::kRefsAndArgs ? kArm64CalleeSaveArgSpills : 0) | + (type == Runtime::kSaveAll ? kArm64CalleeSaveAllSpills : 0) | (1 << art::arm64::FP) | + (1 << art::arm64::X18) | (1 << art::arm64::LR); +} + +constexpr uint32_t Arm64CalleeSaveFpSpills(Runtime::CalleeSaveType type) { + return kArm64CalleeSaveFpRefSpills | + (type == Runtime::kRefsAndArgs ? kArm64CalleeSaveFpArgSpills: 0) | + (type == Runtime::kSaveAll ? kArm64FpAllSpills : 0); +} + +constexpr uint32_t Arm64CalleeSaveFrameSize(Runtime::CalleeSaveType type) { + return RoundUp((POPCOUNT(Arm64CalleeSaveCoreSpills(type)) /* gprs */ + + POPCOUNT(Arm64CalleeSaveFpSpills(type)) /* fprs */ + + 1 /* Method* */) * kArm64PointerSize, kStackAlignment); +} + +constexpr QuickMethodFrameInfo Arm64CalleeSaveMethodFrameInfo(Runtime::CalleeSaveType type) { + return QuickMethodFrameInfo(Arm64CalleeSaveFrameSize(type), + Arm64CalleeSaveCoreSpills(type), + Arm64CalleeSaveFpSpills(type)); +} + +} // namespace arm64 +} // namespace art + +#endif // ART_RUNTIME_ARCH_ARM64_QUICK_METHOD_FRAME_INFO_ARM64_H_ diff --git a/runtime/arch/mips/context_mips.cc b/runtime/arch/mips/context_mips.cc index 0950e7122d..ad2889135a 100644 --- a/runtime/arch/mips/context_mips.cc +++ b/runtime/arch/mips/context_mips.cc @@ -16,8 +16,9 @@ #include "context_mips.h" -#include "mirror/art_method.h" +#include "mirror/art_method-inl.h" #include "mirror/object-inl.h" +#include "quick/quick_method_frame_info.h" #include "stack.h" namespace art { @@ -41,17 +42,15 @@ void MipsContext::Reset() { void MipsContext::FillCalleeSaves(const StackVisitor& fr) { mirror::ArtMethod* method = fr.GetMethod(); - uint32_t core_spills = method->GetCoreSpillMask(); - uint32_t fp_core_spills = method->GetFpSpillMask(); - size_t spill_count = POPCOUNT(core_spills); - size_t fp_spill_count = POPCOUNT(fp_core_spills); - size_t frame_size = method->GetFrameSizeInBytes(); + const QuickMethodFrameInfo frame_info = method->GetQuickFrameInfo(); + size_t spill_count = POPCOUNT(frame_info.CoreSpillMask()); + size_t fp_spill_count = POPCOUNT(frame_info.FpSpillMask()); if (spill_count > 0) { // Lowest number spill is farthest away, walk registers and fill into context. int j = 1; for (size_t i = 0; i < kNumberOfCoreRegisters; i++) { - if (((core_spills >> i) & 1) != 0) { - gprs_[i] = fr.CalleeSaveAddress(spill_count - j, frame_size); + if (((frame_info.CoreSpillMask() >> i) & 1) != 0) { + gprs_[i] = fr.CalleeSaveAddress(spill_count - j, frame_info.FrameSizeInBytes()); j++; } } @@ -60,8 +59,9 @@ void MipsContext::FillCalleeSaves(const StackVisitor& fr) { // Lowest number spill is farthest away, walk registers and fill into context. int j = 1; for (size_t i = 0; i < kNumberOfFRegisters; i++) { - if (((fp_core_spills >> i) & 1) != 0) { - fprs_[i] = fr.CalleeSaveAddress(spill_count + fp_spill_count - j, frame_size); + if (((frame_info.FpSpillMask() >> i) & 1) != 0) { + fprs_[i] = fr.CalleeSaveAddress(spill_count + fp_spill_count - j, + frame_info.FrameSizeInBytes()); j++; } } diff --git a/runtime/arch/mips/quick_method_frame_info_mips.h b/runtime/arch/mips/quick_method_frame_info_mips.h new file mode 100644 index 0000000000..2a8bcf0b37 --- /dev/null +++ b/runtime/arch/mips/quick_method_frame_info_mips.h @@ -0,0 +1,56 @@ +/* + * Copyright (C) 2014 The Android Open Source Project + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#ifndef ART_RUNTIME_ARCH_MIPS_QUICK_METHOD_FRAME_INFO_MIPS_H_ +#define ART_RUNTIME_ARCH_MIPS_QUICK_METHOD_FRAME_INFO_MIPS_H_ + +#include "quick/quick_method_frame_info.h" +#include "registers_mips.h" +#include "runtime.h" // for Runtime::CalleeSaveType. + +namespace art { +namespace mips { + +static constexpr uint32_t kMipsCalleeSaveRefSpills = + (1 << art::mips::S2) | (1 << art::mips::S3) | (1 << art::mips::S4) | (1 << art::mips::S5) | + (1 << art::mips::S6) | (1 << art::mips::S7) | (1 << art::mips::GP) | (1 << art::mips::FP); +static constexpr uint32_t kMipsCalleeSaveArgSpills = + (1 << art::mips::A1) | (1 << art::mips::A2) | (1 << art::mips::A3); +static constexpr uint32_t kMipsCalleeSaveAllSpills = + (1 << art::mips::S0) | (1 << art::mips::S1); + +constexpr uint32_t MipsCalleeSaveCoreSpills(Runtime::CalleeSaveType type) { + return kMipsCalleeSaveRefSpills | + (type == Runtime::kRefsAndArgs ? kMipsCalleeSaveArgSpills : 0) | + (type == Runtime::kSaveAll ? kMipsCalleeSaveAllSpills : 0) | (1 << art::mips::RA); +} + +constexpr uint32_t MipsCalleeSaveFrameSize(Runtime::CalleeSaveType type) { + return RoundUp((POPCOUNT(MipsCalleeSaveCoreSpills(type)) /* gprs */ + + (type == Runtime::kRefsAndArgs ? 0 : 3) + 1 /* Method* */) * + kMipsPointerSize, kStackAlignment); +} + +constexpr QuickMethodFrameInfo MipsCalleeSaveMethodFrameInfo(Runtime::CalleeSaveType type) { + return QuickMethodFrameInfo(MipsCalleeSaveFrameSize(type), + MipsCalleeSaveCoreSpills(type), + 0u); +} + +} // namespace mips +} // namespace art + +#endif // ART_RUNTIME_ARCH_MIPS_QUICK_METHOD_FRAME_INFO_MIPS_H_ diff --git a/runtime/arch/stub_test.cc b/runtime/arch/stub_test.cc index 1d055400a1..5e8edf0571 100644 --- a/runtime/arch/stub_test.cc +++ b/runtime/arch/stub_test.cc @@ -33,10 +33,11 @@ class StubTest : public CommonRuntimeTest { { // Create callee-save methods ScopedObjectAccess soa(Thread::Current()); + runtime_->SetInstructionSet(kRuntimeISA); for (int i = 0; i < Runtime::kLastCalleeSaveType; i++) { Runtime::CalleeSaveType type = Runtime::CalleeSaveType(i); if (!runtime_->HasCalleeSaveMethod(type)) { - runtime_->SetCalleeSaveMethod(runtime_->CreateCalleeSaveMethod(kRuntimeISA, type), type); + runtime_->SetCalleeSaveMethod(runtime_->CreateCalleeSaveMethod(type), type); } } } diff --git a/runtime/arch/x86/context_x86.cc b/runtime/arch/x86/context_x86.cc index c68d76a471..8c98d910c5 100644 --- a/runtime/arch/x86/context_x86.cc +++ b/runtime/arch/x86/context_x86.cc @@ -16,8 +16,9 @@ #include "context_x86.h" -#include "mirror/art_method.h" +#include "mirror/art_method-inl.h" #include "mirror/object-inl.h" +#include "quick/quick_method_frame_info.h" #include "stack.h" namespace art { @@ -37,16 +38,15 @@ void X86Context::Reset() { void X86Context::FillCalleeSaves(const StackVisitor& fr) { mirror::ArtMethod* method = fr.GetMethod(); - uint32_t core_spills = method->GetCoreSpillMask(); - size_t spill_count = POPCOUNT(core_spills); - DCHECK_EQ(method->GetFpSpillMask(), 0u); - size_t frame_size = method->GetFrameSizeInBytes(); + const QuickMethodFrameInfo frame_info = method->GetQuickFrameInfo(); + size_t spill_count = POPCOUNT(frame_info.CoreSpillMask()); + DCHECK_EQ(frame_info.FpSpillMask(), 0u); if (spill_count > 0) { // Lowest number spill is farthest away, walk registers and fill into context. int j = 2; // Offset j to skip return address spill. for (int i = 0; i < kNumberOfCpuRegisters; i++) { - if (((core_spills >> i) & 1) != 0) { - gprs_[i] = fr.CalleeSaveAddress(spill_count - j, frame_size); + if (((frame_info.CoreSpillMask() >> i) & 1) != 0) { + gprs_[i] = fr.CalleeSaveAddress(spill_count - j, frame_info.FrameSizeInBytes()); j++; } } diff --git a/runtime/arch/x86/quick_method_frame_info_x86.h b/runtime/arch/x86/quick_method_frame_info_x86.h new file mode 100644 index 0000000000..b9dc0d8b19 --- /dev/null +++ b/runtime/arch/x86/quick_method_frame_info_x86.h @@ -0,0 +1,51 @@ +/* + * Copyright (C) 2014 The Android Open Source Project + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#ifndef ART_RUNTIME_ARCH_X86_QUICK_METHOD_FRAME_INFO_X86_H_ +#define ART_RUNTIME_ARCH_X86_QUICK_METHOD_FRAME_INFO_X86_H_ + +#include "quick/quick_method_frame_info.h" +#include "registers_x86.h" +#include "runtime.h" // for Runtime::CalleeSaveType. + +namespace art { +namespace x86 { + +static constexpr uint32_t kX86CalleeSaveRefSpills = + (1 << art::x86::EBP) | (1 << art::x86::ESI) | (1 << art::x86::EDI); +static constexpr uint32_t kX86CalleeSaveArgSpills = + (1 << art::x86::ECX) | (1 << art::x86::EDX) | (1 << art::x86::EBX); + +constexpr uint32_t X86CalleeSaveCoreSpills(Runtime::CalleeSaveType type) { + return kX86CalleeSaveRefSpills | (type == Runtime::kRefsAndArgs ? kX86CalleeSaveArgSpills : 0) | + (1 << art::x86::kNumberOfCpuRegisters); // fake return address callee save +} + +constexpr uint32_t X86CalleeSaveFrameSize(Runtime::CalleeSaveType type) { + return RoundUp((POPCOUNT(X86CalleeSaveCoreSpills(type)) /* gprs */ + + 1 /* Method* */) * kX86PointerSize, kStackAlignment); +} + +constexpr QuickMethodFrameInfo X86CalleeSaveMethodFrameInfo(Runtime::CalleeSaveType type) { + return QuickMethodFrameInfo(X86CalleeSaveFrameSize(type), + X86CalleeSaveCoreSpills(type), + 0u); +} + +} // namespace x86 +} // namespace art + +#endif // ART_RUNTIME_ARCH_X86_QUICK_METHOD_FRAME_INFO_X86_H_ diff --git a/runtime/arch/x86_64/context_x86_64.cc b/runtime/arch/x86_64/context_x86_64.cc index 29a706593c..810ef9455a 100644 --- a/runtime/arch/x86_64/context_x86_64.cc +++ b/runtime/arch/x86_64/context_x86_64.cc @@ -16,8 +16,9 @@ #include "context_x86_64.h" -#include "mirror/art_method.h" +#include "mirror/art_method-inl.h" #include "mirror/object-inl.h" +#include "quick/quick_method_frame_info.h" #include "stack.h" namespace art { @@ -40,17 +41,15 @@ void X86_64Context::Reset() { void X86_64Context::FillCalleeSaves(const StackVisitor& fr) { mirror::ArtMethod* method = fr.GetMethod(); - uint32_t core_spills = method->GetCoreSpillMask(); - uint32_t fp_core_spills = method->GetFpSpillMask(); - size_t spill_count = POPCOUNT(core_spills); - size_t fp_spill_count = POPCOUNT(fp_core_spills); - size_t frame_size = method->GetFrameSizeInBytes(); + const QuickMethodFrameInfo frame_info = method->GetQuickFrameInfo(); + size_t spill_count = POPCOUNT(frame_info.CoreSpillMask()); + size_t fp_spill_count = POPCOUNT(frame_info.FpSpillMask()); if (spill_count > 0) { // Lowest number spill is farthest away, walk registers and fill into context. size_t j = 2; // Offset j to skip return address spill. for (size_t i = 0; i < kNumberOfCpuRegisters; ++i) { - if (((core_spills >> i) & 1) != 0) { - gprs_[i] = fr.CalleeSaveAddress(spill_count - j, frame_size); + if (((frame_info.CoreSpillMask() >> i) & 1) != 0) { + gprs_[i] = fr.CalleeSaveAddress(spill_count - j, frame_info.FrameSizeInBytes()); j++; } } @@ -59,8 +58,9 @@ void X86_64Context::FillCalleeSaves(const StackVisitor& fr) { // Lowest number spill is farthest away, walk registers and fill into context. size_t j = 2; // Offset j to skip return address spill. for (size_t i = 0; i < kNumberOfFloatRegisters; ++i) { - if (((fp_core_spills >> i) & 1) != 0) { - fprs_[i] = fr.CalleeSaveAddress(spill_count + fp_spill_count - j, frame_size); + if (((frame_info.FpSpillMask() >> i) & 1) != 0) { + fprs_[i] = fr.CalleeSaveAddress(spill_count + fp_spill_count - j, + frame_info.FrameSizeInBytes()); j++; } } diff --git a/runtime/arch/x86_64/quick_method_frame_info_x86_64.h b/runtime/arch/x86_64/quick_method_frame_info_x86_64.h new file mode 100644 index 0000000000..618390903b --- /dev/null +++ b/runtime/arch/x86_64/quick_method_frame_info_x86_64.h @@ -0,0 +1,63 @@ +/* + * Copyright (C) 2014 The Android Open Source Project + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#ifndef ART_RUNTIME_ARCH_X86_64_QUICK_METHOD_FRAME_INFO_X86_64_H_ +#define ART_RUNTIME_ARCH_X86_64_QUICK_METHOD_FRAME_INFO_X86_64_H_ + +#include "quick/quick_method_frame_info.h" +#include "registers_x86_64.h" +#include "runtime.h" // for Runtime::CalleeSaveType. + +namespace art { +namespace x86_64 { + +static constexpr uint32_t kX86_64CalleeSaveRefSpills = + (1 << art::x86_64::RBX) | (1 << art::x86_64::RBP) | (1 << art::x86_64::R12) | + (1 << art::x86_64::R13) | (1 << art::x86_64::R14) | (1 << art::x86_64::R15); +static constexpr uint32_t kX86_64CalleeSaveArgSpills = + (1 << art::x86_64::RSI) | (1 << art::x86_64::RDX) | (1 << art::x86_64::RCX) | + (1 << art::x86_64::R8) | (1 << art::x86_64::R9); +static constexpr uint32_t kX86_64CalleeSaveFpArgSpills = + (1 << art::x86_64::XMM0) | (1 << art::x86_64::XMM1) | (1 << art::x86_64::XMM2) | + (1 << art::x86_64::XMM3) | (1 << art::x86_64::XMM4) | (1 << art::x86_64::XMM5) | + (1 << art::x86_64::XMM6) | (1 << art::x86_64::XMM7); + +constexpr uint32_t X86_64CalleeSaveCoreSpills(Runtime::CalleeSaveType type) { + return kX86_64CalleeSaveRefSpills | + (type == Runtime::kRefsAndArgs ? kX86_64CalleeSaveArgSpills : 0) | + (1 << art::x86_64::kNumberOfCpuRegisters); // fake return address callee save; +} + +constexpr uint32_t X86_64CalleeSaveFpSpills(Runtime::CalleeSaveType type) { + return (type == Runtime::kRefsAndArgs ? kX86_64CalleeSaveFpArgSpills : 0); +} + +constexpr uint32_t X86_64CalleeSaveFrameSize(Runtime::CalleeSaveType type) { + return RoundUp((POPCOUNT(X86_64CalleeSaveCoreSpills(type)) /* gprs */ + + POPCOUNT(X86_64CalleeSaveFpSpills(type)) /* fprs */ + + 1 /* Method* */) * kX86_64PointerSize, kStackAlignment); +} + +constexpr QuickMethodFrameInfo X86_64CalleeSaveMethodFrameInfo(Runtime::CalleeSaveType type) { + return QuickMethodFrameInfo(X86_64CalleeSaveFrameSize(type), + X86_64CalleeSaveCoreSpills(type), + X86_64CalleeSaveFpSpills(type)); +} + +} // namespace x86_64 +} // namespace art + +#endif // ART_RUNTIME_ARCH_X86_64_QUICK_METHOD_FRAME_INFO_X86_64_H_ |
