diff options
author | Ian Rogers <irogers@google.com> | 2014-10-24 14:20:06 -0700 |
---|---|---|
committer | Ian Rogers <irogers@google.com> | 2014-10-24 14:23:42 -0700 |
commit | 2c4257be8191c5eefde744e8965fcefc80a0a97d (patch) | |
tree | 9db3e1f1c60f2df29638ba3ce9d5d5bb8b26ca2c /compiler/utils | |
parent | 98c271d517bc4d25fc6879b4b8e35ea93885d9e2 (diff) | |
download | android_art-2c4257be8191c5eefde744e8965fcefc80a0a97d.tar.gz android_art-2c4257be8191c5eefde744e8965fcefc80a0a97d.tar.bz2 android_art-2c4257be8191c5eefde744e8965fcefc80a0a97d.zip |
Tidy logging code not using UNIMPLEMENTED.
Change-Id: I7a79c1671a6ff8b2040887133b3e0925ef9a3cfe
Diffstat (limited to 'compiler/utils')
-rw-r--r-- | compiler/utils/arena_object.h | 1 | ||||
-rw-r--r-- | compiler/utils/arm/assembler_arm.cc | 12 | ||||
-rw-r--r-- | compiler/utils/arm/assembler_arm32.cc | 2 | ||||
-rw-r--r-- | compiler/utils/arm/assembler_thumb2.cc | 2 |
4 files changed, 11 insertions, 6 deletions
diff --git a/compiler/utils/arena_object.h b/compiler/utils/arena_object.h index 50909f7532..8f6965edc5 100644 --- a/compiler/utils/arena_object.h +++ b/compiler/utils/arena_object.h @@ -31,6 +31,7 @@ class ArenaObject { void operator delete(void*, size_t) { LOG(FATAL) << "UNREACHABLE"; + UNREACHABLE(); } }; diff --git a/compiler/utils/arm/assembler_arm.cc b/compiler/utils/arm/assembler_arm.cc index b430c7ee97..db42b4620d 100644 --- a/compiler/utils/arm/assembler_arm.cc +++ b/compiler/utils/arm/assembler_arm.cc @@ -324,7 +324,7 @@ bool Address::CanHoldLoadOffsetArm(LoadOperandType type, int offset) { return IsAbsoluteUint(10, offset); // VFP addressing mode. default: LOG(FATAL) << "UNREACHABLE"; - return false; + UNREACHABLE(); } } @@ -342,7 +342,7 @@ bool Address::CanHoldStoreOffsetArm(StoreOperandType type, int offset) { return IsAbsoluteUint(10, offset); // VFP addressing mode. default: LOG(FATAL) << "UNREACHABLE"; - return false; + UNREACHABLE(); } } @@ -359,9 +359,9 @@ bool Address::CanHoldLoadOffsetThumb(LoadOperandType type, int offset) { return IsAbsoluteUint(10, offset); // VFP addressing mode. case kLoadWordPair: return IsAbsoluteUint(10, offset); - default: + default: LOG(FATAL) << "UNREACHABLE"; - return false; + UNREACHABLE(); } } @@ -377,9 +377,9 @@ bool Address::CanHoldStoreOffsetThumb(StoreOperandType type, int offset) { return IsAbsoluteUint(10, offset); // VFP addressing mode. case kStoreWordPair: return IsAbsoluteUint(10, offset); - default: + default: LOG(FATAL) << "UNREACHABLE"; - return false; + UNREACHABLE(); } } diff --git a/compiler/utils/arm/assembler_arm32.cc b/compiler/utils/arm/assembler_arm32.cc index 6af69c86ce..3d46617079 100644 --- a/compiler/utils/arm/assembler_arm32.cc +++ b/compiler/utils/arm/assembler_arm32.cc @@ -1356,6 +1356,7 @@ void Arm32Assembler::LoadFromOffset(LoadOperandType type, break; default: LOG(FATAL) << "UNREACHABLE"; + UNREACHABLE(); } } @@ -1427,6 +1428,7 @@ void Arm32Assembler::StoreToOffset(StoreOperandType type, break; default: LOG(FATAL) << "UNREACHABLE"; + UNREACHABLE(); } } diff --git a/compiler/utils/arm/assembler_thumb2.cc b/compiler/utils/arm/assembler_thumb2.cc index 7968a7774e..37478c4ac1 100644 --- a/compiler/utils/arm/assembler_thumb2.cc +++ b/compiler/utils/arm/assembler_thumb2.cc @@ -2406,6 +2406,7 @@ void Thumb2Assembler::LoadFromOffset(LoadOperandType type, break; default: LOG(FATAL) << "UNREACHABLE"; + UNREACHABLE(); } } @@ -2477,6 +2478,7 @@ void Thumb2Assembler::StoreToOffset(StoreOperandType type, break; default: LOG(FATAL) << "UNREACHABLE"; + UNREACHABLE(); } } |