summaryrefslogtreecommitdiffstats
path: root/compiler/optimizing/builder.cc
diff options
context:
space:
mode:
authorNicolas Geoffray <ngeoffray@google.com>2014-11-26 14:45:52 +0000
committerNicolas Geoffray <ngeoffray@google.com>2014-11-26 14:45:52 +0000
commit799f506b8d48bcceef5e6cf50f3f5eb6bcea05e1 (patch)
tree078cd0518627673566727494b003fa671c027dc8 /compiler/optimizing/builder.cc
parentcea28ec4b9e94ec942899acf1dbf20f8999b36b4 (diff)
downloadandroid_art-799f506b8d48bcceef5e6cf50f3f5eb6bcea05e1.tar.gz
android_art-799f506b8d48bcceef5e6cf50f3f5eb6bcea05e1.tar.bz2
android_art-799f506b8d48bcceef5e6cf50f3f5eb6bcea05e1.zip
Revert "[optimizing compiler] Add CMP{L,G}_{FLOAT,DOUBLE}"
Fails on x86_64 and target. This reverts commit cea28ec4b9e94ec942899acf1dbf20f8999b36b4. Change-Id: I30c1d188c7ecfe765f137a307022ede84f15482c
Diffstat (limited to 'compiler/optimizing/builder.cc')
-rw-r--r--compiler/optimizing/builder.cc31
1 files changed, 1 insertions, 30 deletions
diff --git a/compiler/optimizing/builder.cc b/compiler/optimizing/builder.cc
index 1be6e00938..b261460690 100644
--- a/compiler/optimizing/builder.cc
+++ b/compiler/optimizing/builder.cc
@@ -313,15 +313,6 @@ void HGraphBuilder::Binop_23x_shift(const Instruction& instruction,
UpdateLocal(instruction.VRegA(), current_block_->GetLastInstruction());
}
-void HGraphBuilder::Binop_23x_cmp(const Instruction& instruction,
- Primitive::Type type,
- HCompare::Bias bias) {
- HInstruction* first = LoadLocal(instruction.VRegB(), type);
- HInstruction* second = LoadLocal(instruction.VRegC(), type);
- current_block_->AddInstruction(new (arena_) HCompare(type, first, second, bias));
- UpdateLocal(instruction.VRegA(), current_block_->GetLastInstruction());
-}
-
template<typename T>
void HGraphBuilder::Binop_12x(const Instruction& instruction, Primitive::Type type) {
HInstruction* first = LoadLocal(instruction.VRegA(), type);
@@ -1501,27 +1492,7 @@ bool HGraphBuilder::AnalyzeDexInstruction(const Instruction& instruction, uint32
break;
case Instruction::CMP_LONG: {
- Binop_23x_cmp(instruction, Primitive::kPrimLong, HCompare::kNoBias);
- break;
- }
-
- case Instruction::CMPG_FLOAT: {
- Binop_23x_cmp(instruction, Primitive::kPrimFloat, HCompare::kGtBias);
- break;
- }
-
- case Instruction::CMPG_DOUBLE: {
- Binop_23x_cmp(instruction, Primitive::kPrimDouble, HCompare::kGtBias);
- break;
- }
-
- case Instruction::CMPL_FLOAT: {
- Binop_23x_cmp(instruction, Primitive::kPrimFloat, HCompare::kLtBias);
- break;
- }
-
- case Instruction::CMPL_DOUBLE: {
- Binop_23x_cmp(instruction, Primitive::kPrimDouble, HCompare::kLtBias);
+ Binop_23x<HCompare>(instruction, Primitive::kPrimLong);
break;
}