diff options
author | Zheng Xu <zheng.xu@arm.com> | 2014-10-23 18:29:55 +0800 |
---|---|---|
committer | Ian Rogers <irogers@google.com> | 2014-10-24 16:27:22 -0700 |
commit | 5667fdbb6e441dee7534ade18b628ed396daf593 (patch) | |
tree | a06fe0a79b3465571556d13f509daf1f664fc614 /compiler/dex/quick/gen_invoke.cc | |
parent | b62ff579cd870b0bf213765b07d7b404d15ece7b (diff) | |
download | android_art-5667fdbb6e441dee7534ade18b628ed396daf593.tar.gz android_art-5667fdbb6e441dee7534ade18b628ed396daf593.tar.bz2 android_art-5667fdbb6e441dee7534ade18b628ed396daf593.zip |
ARM: Use hardfp calling convention between java to java call.
This patch default to use hardfp calling convention. Softfp can be enabled
by setting kArm32QuickCodeUseSoftFloat to true.
We get about -1 ~ +5% performance improvement with different benchmark
tests. Hopefully, we should be able to get more performance by address the left
TODOs, as some part of the code takes the original assumption which is not
optimal.
DONE:
1. Interpreter to quick code
2. Quick code to interpreter
3. Transition assembly and callee-saves
4. Trampoline(generic jni, resolution, invoke with access check and etc.)
5. Pass fp arg reg following aapcs(gpr and stack do not follow aapcs)
6. Quick helper assembly routines to handle ABI differences
7. Quick code method entry
8. Quick code method invocation
9. JNI compiler
TODO:
10. Rework ArgMap, FlushIn, GenDalvikArgs and affected common code.
11. Rework CallRuntimeHelperXXX().
Change-Id: I9965d8a007f4829f2560b63bcbbde271bdcf6ec2
Diffstat (limited to 'compiler/dex/quick/gen_invoke.cc')
-rwxr-xr-x | compiler/dex/quick/gen_invoke.cc | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/compiler/dex/quick/gen_invoke.cc b/compiler/dex/quick/gen_invoke.cc index 2bef7c53c5..bc4d00b6cd 100755 --- a/compiler/dex/quick/gen_invoke.cc +++ b/compiler/dex/quick/gen_invoke.cc @@ -248,13 +248,13 @@ void Mir2Lir::CallRuntimeHelperRegLocationRegLocation(QuickEntrypointEnum trampo if (cu_->instruction_set == kMips) { LoadValueDirectFixed(arg1, TargetReg(arg1.fp ? kFArg2 : kArg1, kNotWide)); } else { - LoadValueDirectFixed(arg1, TargetReg(kArg1, kNotWide)); + LoadValueDirectFixed(arg1, TargetReg(arg1.fp ? kFArg1 : kArg1, kNotWide)); } } else { if (cu_->instruction_set == kMips) { LoadValueDirectWideFixed(arg1, TargetReg(arg1.fp ? kFArg2 : kArg2, kWide)); } else { - LoadValueDirectWideFixed(arg1, TargetReg(kArg1, kWide)); + LoadValueDirectWideFixed(arg1, TargetReg(arg1.fp ? kFArg1 : kArg1, kWide)); } } } else { @@ -365,6 +365,7 @@ void Mir2Lir::CallRuntimeHelperRegLocationRegLocationRegLocation( * ArgLocs is an array of location records describing the incoming arguments * with one location record per word of argument. */ +// TODO: Support 64-bit argument registers. void Mir2Lir::FlushIns(RegLocation* ArgLocs, RegLocation rl_method) { /* * Dummy up a RegLocation for the incoming StackReference<mirror::ArtMethod> |