diff options
| author | Xianyuan Jia <xianyuanjia@google.com> | 2020-02-27 16:31:58 -0800 |
|---|---|---|
| committer | Xianyuan Jia <xianyuanjia@google.com> | 2020-03-02 18:55:38 +0000 |
| commit | 09db79ba8ae5dc91aa22efa846f65ce8da1938bf (patch) | |
| tree | 74849d58b9e822caa3f9032f539a84c0cabc9753 /tools/proto_check.py | |
| parent | 6c7c3c1a7ced2c75a5797d226222707583ad11bf (diff) | |
| download | platform_tools_test_connectivity-09db79ba8ae5dc91aa22efa846f65ce8da1938bf.tar.gz platform_tools_test_connectivity-09db79ba8ae5dc91aa22efa846f65ce8da1938bf.tar.bz2 platform_tools_test_connectivity-09db79ba8ae5dc91aa22efa846f65ce8da1938bf.zip | |
In proto_check, do not attempt to verify unpaired *_pb2.py files.
It is reasonable to expect that a user would not submit a change
to a generated file, without changing the underlying proto,
except for the below situations:
1. The file is generated for the first time.
2. The file is deleted.
In both situations, proto_check would fail because it did not detect
a corresponding change to a base proto file.
Bug: None
Test: preupload
Change-Id: I1ff1d3bbbe3c487ae7fbad6934caeb753bbe5955
Diffstat (limited to 'tools/proto_check.py')
| -rwxr-xr-x | tools/proto_check.py | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/tools/proto_check.py b/tools/proto_check.py index cda0e3a081..6dafcedbf4 100755 --- a/tools/proto_check.py +++ b/tools/proto_check.py @@ -89,12 +89,6 @@ def verify_protos_update_generated_files(proto_files, proto_gen_files): '\n%s' % protoc_command) success = False - # fail if there are unpaired gen_files - if gen_files: - logging.error('Generated *_pb2.py files modified without updating ' - 'source .proto files: \n\t%s' % '\n\t'.join(gen_files)) - success = False - return success |