diff options
| author | Remi NGUYEN VAN <reminv@google.com> | 2020-04-09 06:14:12 +0000 |
|---|---|---|
| committer | Gerrit Code Review <noreply-gerritcodereview@google.com> | 2020-04-09 06:14:12 +0000 |
| commit | a9068317c96a3f0ed50d125a791ac9c550f31dfe (patch) | |
| tree | b97a0f51ae08927a204beaab9603acbf8f9662a4 /res | |
| parent | ddeb0c17e227c55bdab215702621fc4898cb9c8e (diff) | |
| parent | 4915fafdca98152e80e22c4a8daa538d850f1403 (diff) | |
| download | platform_packages_modules_NetworkStack-a9068317c96a3f0ed50d125a791ac9c550f31dfe.tar.gz platform_packages_modules_NetworkStack-a9068317c96a3f0ed50d125a791ac9c550f31dfe.tar.bz2 platform_packages_modules_NetworkStack-a9068317c96a3f0ed50d125a791ac9c550f31dfe.zip | |
Merge "Do not detect portals when DNS returns private IPs"
Diffstat (limited to 'res')
| -rw-r--r-- | res/values/config.xml | 8 | ||||
| -rw-r--r-- | res/values/overlayable.xml | 8 |
2 files changed, 16 insertions, 0 deletions
diff --git a/res/values/config.xml b/res/values/config.xml index a2f39594..8bd8eff5 100644 --- a/res/values/config.xml +++ b/res/values/config.xml @@ -59,4 +59,12 @@ <integer name="config_nud_steadystate_solicit_interval">750</integer> <integer name="config_nud_postroaming_solicit_num">5</integer> <integer name="config_nud_postroaming_solicit_interval">750</integer> + + <!-- Whether to force considering DNS probes returning private IP addresses as failed + when attempting to detect captive portals. + The impact of this feature will be evaluated separately through experiments. + Force-enabling the feature regardless of the experiment results is not advised, as it + could result in valid captive portals being incorrectly classified as having no + connectivity.--> + <bool name="config_force_dns_probe_private_ip_no_internet">false</bool> </resources> diff --git a/res/values/overlayable.xml b/res/values/overlayable.xml index 052266d2..ed86814f 100644 --- a/res/values/overlayable.xml +++ b/res/values/overlayable.xml @@ -44,6 +44,14 @@ <item type="integer" name="config_nud_steadystate_solicit_interval"/> <item type="integer" name="config_nud_postroaming_solicit_num"/> <item type="integer" name="config_nud_postroaming_solicit_interval"/> + + <!-- Whether to force considering DNS probes returning private IP addresses as failed + when attempting to detect captive portals. + The impact of this feature will be evaluated separately through experiments. + Force-enabling the feature regardless of the experiment results is not advised, as it + could result in valid captive portals being incorrectly classified as having no + connectivity.--> + <item type="bool" name="config_force_dns_probe_private_ip_no_internet"/> </policy> </overlayable> </resources> |