summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorChristopher Dombroski <cdombroski@google.com>2019-04-17 16:16:13 -0700
committerhamzeh <hamzeh@google.com>2019-05-10 16:06:42 -0700
commitac08ce7bff42facbf2f74e4775210aab7147b043 (patch)
tree789a14cd22abb1116a9892e92097d4950d39e030
parent7ab331fdc03c87628bcd189b15d38cfae5bfb893 (diff)
downloadplatform_packages_apps_PackageInstaller-security-pi-release.tar.gz
platform_packages_apps_PackageInstaller-security-pi-release.tar.bz2
platform_packages_apps_PackageInstaller-security-pi-release.zip
Some system apps may download unknown content and the user should be explicitly asked whether they trust these files. System apps should explicitly use the extra NOT_UNKNOWN_SOURCE to bypass this check. Test: Builds, boots, existing tests pass: atest CtsPackageInstallTestCases Locally verified they pass if CtsPackageInstallTestCases.apk was signed by the platform cert. Bug: 123700348 Change-Id: I5a05b9a6d41bfbff9cd4cf2e26301dfa6fc64a9d (cherry picked from commit 4c5493f65ad4add90cc1e8ee02c0814fcf4f0c32)
-rw-r--r--src/com/android/packageinstaller/PackageInstallerActivity.java11
1 files changed, 0 insertions, 11 deletions
diff --git a/src/com/android/packageinstaller/PackageInstallerActivity.java b/src/com/android/packageinstaller/PackageInstallerActivity.java
index 55b0d664d..a2df83061 100644
--- a/src/com/android/packageinstaller/PackageInstallerActivity.java
+++ b/src/com/android/packageinstaller/PackageInstallerActivity.java
@@ -39,7 +39,6 @@ import android.net.Uri;
import android.os.Build;
import android.os.Bundle;
import android.os.Process;
-import android.os.RemoteException;
import android.os.UserManager;
import android.provider.Settings;
import android.support.annotation.NonNull;
@@ -529,16 +528,6 @@ public class PackageInstallerActivity extends OverlayTouchActivity implements On
mOriginatingUid, mOriginatingPackage);
switch (appOpMode) {
case AppOpsManager.MODE_DEFAULT:
- try {
- int result = mIpm.checkUidPermission(
- Manifest.permission.REQUEST_INSTALL_PACKAGES, mOriginatingUid);
- if (result == PackageManager.PERMISSION_GRANTED) {
- initiateInstall();
- break;
- }
- } catch (RemoteException exc) {
- Log.e(TAG, "Unable to talk to package manager");
- }
mAppOpsManager.setMode(appOpCode, mOriginatingUid,
mOriginatingPackage, AppOpsManager.MODE_ERRORED);
// fall through