summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHangyu Kuang <hkuang@google.com>2019-05-24 02:27:29 -0700
committerandroid-build-merger <android-build-merger@google.com>2019-05-24 02:27:29 -0700
commit22f7811f592fec6c7c035f99ec3c7034c8579b4f (patch)
treebc6251404f318e4fa3a52844091d82b763dce6d3
parent1e8f1449a0646a8f723f07f06832e87360b4cdcf (diff)
parent535da9f3138bae5af3bdd8fd0718e5a10978e7c6 (diff)
downloadplatform_hardware_google_av-22f7811f592fec6c7c035f99ec3c7034c8579b4f.tar.gz
platform_hardware_google_av-22f7811f592fec6c7c035f99ec3c7034c8579b4f.tar.bz2
platform_hardware_google_av-22f7811f592fec6c7c035f99ec3c7034c8579b4f.zip
[ECOService] Fix the failure of removing listener and provider. am: 839b7e1988
am: 535da9f313 Change-Id: I9db4e197c75f22463a8d7ef77a7ed380c3d8eaea
-rw-r--r--media/eco/ECOSession.cpp6
1 files changed, 4 insertions, 2 deletions
diff --git a/media/eco/ECOSession.cpp b/media/eco/ECOSession.cpp
index 1bdfa61..e52ad55 100644
--- a/media/eco/ECOSession.cpp
+++ b/media/eco/ECOSession.cpp
@@ -407,8 +407,9 @@ Status ECOSession::removeStatsProvider(
const sp<::android::media::eco::IECOServiceStatsProvider>& provider, bool* status) {
std::scoped_lock<std::mutex> lock(mSessionLock);
// Check if the provider is the same as current provider for the session.
- if (provider.get() != mProvider.get()) {
+ if (IInterface::asBinder(provider) != IInterface::asBinder(mProvider)) {
*status = false;
+ ECOLOGE("Failed to remove provider");
return STATUS_ERROR(ERROR_ILLEGAL_ARGUMENT, "Provider does not match");
}
@@ -484,8 +485,9 @@ Status ECOSession::removeInfoListener(
const sp<::android::media::eco::IECOServiceInfoListener>& listener, bool* _aidl_return) {
std::scoped_lock<std::mutex> lock(mSessionLock);
// Check if the listener is the same as current listener for the session.
- if (listener.get() != mListener.get()) {
+ if (IInterface::asBinder(listener) != IInterface::asBinder(mListener)) {
*_aidl_return = false;
+ ECOLOGE("Failed to remove listener");
return STATUS_ERROR(ERROR_ILLEGAL_ARGUMENT, "Listener does not match");
}