diff options
| author | Kuldeep Singh <kuldeep.singh@nxp.com> | 2020-09-11 16:36:48 +0530 |
|---|---|---|
| committer | Priyanka Jain <priyanka.jain@nxp.com> | 2020-09-24 20:57:32 +0530 |
| commit | 63d534461555c7948eeddf6250f76019b329b15a (patch) | |
| tree | f7e887385562a93eb2affd84afd387554c08a906 | |
| parent | 450d491293bb600cd16ccadbe947d977b1f2142f (diff) | |
| download | platform_external_u-boot-63d534461555c7948eeddf6250f76019b329b15a.tar.gz platform_external_u-boot-63d534461555c7948eeddf6250f76019b329b15a.tar.bz2 platform_external_u-boot-63d534461555c7948eeddf6250f76019b329b15a.zip | |
net: pfe_eth: Fix resoure leak in pfe_spi_flash_init
Fix Coverity issue: RESOURCE_LEAK.
leaked_storage: Variable addr going out of scope leaks the storage it
points to.
Fixes: e0152dbed683 ("net: pfe_eth: Use spi_flash_read API to access
flash memory")
Signed-off-by: Kuldeep Singh <kuldeep.singh@nxp.com>
Reviewed-by: Priyanka Jain <priyanka.jain@nxp.com>
| -rw-r--r-- | drivers/net/pfe_eth/pfe_firmware.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/net/pfe_eth/pfe_firmware.c b/drivers/net/pfe_eth/pfe_firmware.c index 55e661c0e1..4ad09dda1c 100644 --- a/drivers/net/pfe_eth/pfe_firmware.c +++ b/drivers/net/pfe_eth/pfe_firmware.c @@ -170,6 +170,9 @@ int pfe_spi_flash_init(void) int ret = 0; void *addr = malloc(CONFIG_SYS_QE_FMAN_FW_LENGTH); + if (!addr) + return -ENOMEM; + #ifdef CONFIG_DM_SPI_FLASH struct udevice *new; @@ -186,6 +189,7 @@ int pfe_spi_flash_init(void) #endif if (!pfe_flash) { printf("SF: probe for pfe failed\n"); + free(addr); return -ENODEV; } |