diff options
| author | reed <reed@google.com> | 2015-10-06 11:12:23 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-10-06 11:12:23 -0700 |
| commit | 80a6dcaa1b757826ed7414f64b035d512d9ccbf8 (patch) | |
| tree | b77fa8cf50e6954995bf8e53cf0bf07ba72e6544 /src | |
| parent | 85f0d5d6e6a8ae2d5bdfb784fdf426a89dad2c0e (diff) | |
| download | platform_external_skqp-80a6dcaa1b757826ed7414f64b035d512d9ccbf8.tar.gz platform_external_skqp-80a6dcaa1b757826ed7414f64b035d512d9ccbf8.tar.bz2 platform_external_skqp-80a6dcaa1b757826ed7414f64b035d512d9ccbf8.zip | |
factories should return baseclass, allowing the impl to specialize
waiting on https://codereview.chromium.org/1386163002/# to land
BUG=skia:4424
Review URL: https://codereview.chromium.org/1390523005
Diffstat (limited to 'src')
| -rw-r--r-- | src/effects/SkRectShaderImageFilter.cpp | 4 | ||||
| -rw-r--r-- | src/effects/SkTileImageFilter.cpp | 4 |
2 files changed, 4 insertions, 4 deletions
diff --git a/src/effects/SkRectShaderImageFilter.cpp b/src/effects/SkRectShaderImageFilter.cpp index f9e70705c5..14837d02b1 100644 --- a/src/effects/SkRectShaderImageFilter.cpp +++ b/src/effects/SkRectShaderImageFilter.cpp @@ -13,7 +13,7 @@ #include "SkWriteBuffer.h" #include "SkShader.h" -SkRectShaderImageFilter* SkRectShaderImageFilter::Create(SkShader* s, const SkRect& rect) { +SkImageFilter* SkRectShaderImageFilter::Create(SkShader* s, const SkRect& rect) { SkASSERT(s); uint32_t flags = CropRect::kHasAll_CropEdge; if (rect.width() == 0 || rect.height() == 0) { @@ -23,7 +23,7 @@ SkRectShaderImageFilter* SkRectShaderImageFilter::Create(SkShader* s, const SkRe return s ? new SkRectShaderImageFilter(s, &cropRect) : nullptr; } -SkRectShaderImageFilter* SkRectShaderImageFilter::Create(SkShader* s, const CropRect* cropRect) { +SkImageFilter* SkRectShaderImageFilter::Create(SkShader* s, const CropRect* cropRect) { SkASSERT(s); return s ? new SkRectShaderImageFilter(s, cropRect) : nullptr; } diff --git a/src/effects/SkTileImageFilter.cpp b/src/effects/SkTileImageFilter.cpp index 5e633a3556..c3eb2f301a 100644 --- a/src/effects/SkTileImageFilter.cpp +++ b/src/effects/SkTileImageFilter.cpp @@ -16,8 +16,8 @@ #include "SkShader.h" #include "SkValidationUtils.h" -SkTileImageFilter* SkTileImageFilter::Create(const SkRect& srcRect, const SkRect& dstRect, - SkImageFilter* input) { +SkImageFilter* SkTileImageFilter::Create(const SkRect& srcRect, const SkRect& dstRect, + SkImageFilter* input) { if (!SkIsValidRect(srcRect) || !SkIsValidRect(dstRect)) { return nullptr; } |