aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMike Reed <reed@google.com>2019-01-03 10:51:55 -0500
committerSkia Commit-Bot <skia-commit-bot@chromium.org>2019-01-03 16:19:40 +0000
commit352057b7fc2dcf527998c5707a56d2953212a5d0 (patch)
treeb2c207ff2208d647d417c2f97ce5befb6e1a7889
parent31c4bcb210bd1232ce8c15ff659b6807b9437466 (diff)
downloadplatform_external_skqp-352057b7fc2dcf527998c5707a56d2953212a5d0.tar.gz
platform_external_skqp-352057b7fc2dcf527998c5707a56d2953212a5d0.tar.bz2
platform_external_skqp-352057b7fc2dcf527998c5707a56d2953212a5d0.zip
remove legacy fontmetrics flag
Bug: skia: Change-Id: I83715c95c42f18e2dc4f60e802b898734885c215 Reviewed-on: https://skia-review.googlesource.com/c/180922 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com> Auto-Submit: Mike Reed <reed@google.com>
-rw-r--r--fuzz/FuzzCanvas.cpp6
-rw-r--r--include/core/SkPaint.h19
2 files changed, 0 insertions, 25 deletions
diff --git a/fuzz/FuzzCanvas.cpp b/fuzz/FuzzCanvas.cpp
index 7d6e7e5c93..21918d9f04 100644
--- a/fuzz/FuzzCanvas.cpp
+++ b/fuzz/FuzzCanvas.cpp
@@ -974,12 +974,6 @@ static SkTDArray<uint8_t> make_fuzz_text(Fuzz* fuzz, const SkFont& font, SkTextE
return array;
}
-#ifdef SK_SUPPORT_LEGACY_FONTMETRICS_IN_PAINT
-static SkTDArray<uint8_t> make_fuzz_text(Fuzz* fuzz, const SkPaint& paint) {
- return make_fuzz_text(fuzz, SkFont::LEGACY_ExtractFromPaint(paint), paint.getTextEncoding());
-}
-#endif
-
static sk_sp<SkTextBlob> make_fuzz_textblob(Fuzz* fuzz) {
SkTextBlobBuilder textBlobBuilder;
int8_t runCount;
diff --git a/include/core/SkPaint.h b/include/core/SkPaint.h
index 455e73d1d3..c5ebb646b8 100644
--- a/include/core/SkPaint.h
+++ b/include/core/SkPaint.h
@@ -907,25 +907,6 @@ public:
#ifdef SK_SUPPORT_LEGACY_PAINT_TEXTMEASURE
-#ifdef SK_SUPPORT_LEGACY_FONTMETRICS_IN_PAINT
- /**
- SkFontMetrics is filled out by getFontMetrics(). SkFontMetrics contents reflect the values
- computed by font manager using SkTypeface. Values are set to zero if they are
- not available.
-
- All vertical values are relative to the baseline, on a y-axis pointing down.
- Zero is on the baseline, negative values are above the baseline, and positive
- values are below the baseline.
-
- fUnderlineThickness and fUnderlinePosition have a bit set in fFlags if their values
- are valid, since their value may be zero.
-
- fStrikeoutThickness and fStrikeoutPosition have a bit set in fFlags if their values
- are valid, since their value may be zero.
- */
- typedef SkFontMetrics FontMetrics;
-#endif
-
/** Returns SkFontMetrics associated with SkTypeface.
The return value is the recommended spacing between lines: the sum of metrics
descent, ascent, and leading.