diff options
| author | Kristen Kozak <sebright@google.com> | 2017-12-28 12:27:22 -0800 |
|---|---|---|
| committer | Kristen Kozak <sebright@google.com> | 2017-12-30 19:53:44 -0800 |
| commit | 3c526065eb3b7e713475c11226a5e2d8a8f0826e (patch) | |
| tree | 36683ebef383b37544ff0d951ab32e356de4b627 /contrib | |
| parent | 1049f48ff933720506a70099bea8f9df23e2d993 (diff) | |
| download | platform_external_opencensus-java-3c526065eb3b7e713475c11226a5e2d8a8f0826e.tar.gz platform_external_opencensus-java-3c526065eb3b7e713475c11226a5e2d8a8f0826e.tar.bz2 platform_external_opencensus-java-3c526065eb3b7e713475c11226a5e2d8a8f0826e.zip | |
Add Checker Framework stub file for Guava (fixes #920).
This commit adds a stub file as described in
https://checkerframework.org/manual/#stub. The initial file contains
annotations for com.google.common.base.Strings.isNullOrEmpty.
Diffstat (limited to 'contrib')
| -rw-r--r-- | contrib/zpages/src/main/java/io/opencensus/contrib/zpages/TraceConfigzZPageHandler.java | 14 |
1 files changed, 2 insertions, 12 deletions
diff --git a/contrib/zpages/src/main/java/io/opencensus/contrib/zpages/TraceConfigzZPageHandler.java b/contrib/zpages/src/main/java/io/opencensus/contrib/zpages/TraceConfigzZPageHandler.java index 5257960d..9b075b30 100644 --- a/contrib/zpages/src/main/java/io/opencensus/contrib/zpages/TraceConfigzZPageHandler.java +++ b/contrib/zpages/src/main/java/io/opencensus/contrib/zpages/TraceConfigzZPageHandler.java @@ -16,6 +16,8 @@ package io.opencensus.contrib.zpages; +import static com.google.common.base.Strings.isNullOrEmpty; + import com.google.common.base.Charsets; import io.opencensus.trace.config.TraceConfig; import io.opencensus.trace.config.TraceParams; @@ -25,11 +27,6 @@ import java.io.OutputStream; import java.io.OutputStreamWriter; import java.io.PrintWriter; import java.util.Map; -import javax.annotation.Nullable; - -/*>>> -import org.checkerframework.checker.nullness.qual.EnsuresNonNullIf; -*/ // TODO(bdrutu): Add tests. /** @@ -170,13 +167,6 @@ final class TraceConfigzZPageHandler extends ZPageHandler { } } - // TODO(sebright): Try to use a Checker Framework stub file for the Guava Strings class and use - // Strings.isNullOrEmpty instead. - /*>>> @EnsuresNonNullIf(result = false, expression = "#1") */ - private static boolean isNullOrEmpty(@Nullable String str) { - return str == null || str.isEmpty(); - } - // Prints a table to a PrintWriter that shows existing trace parameters. private static void emitTraceParamsTable(TraceParams params, PrintWriter out) { out.write( |
