aboutsummaryrefslogtreecommitdiffstats
path: root/contrib
diff options
context:
space:
mode:
authorsavaki <matt.ho@gmail.com>2018-07-19 19:29:12 -0700
committersavaki <matt.ho@gmail.com>2018-07-21 07:44:40 -0700
commit14936be783e11ed2cb0e5e55152dc49cdcd68efd (patch)
treea68f7d6d70f7a6c15153f1768b4e2ba805b0c187 /contrib
parent3866e97508c36b77f8c875aed597cd8f336cedf0 (diff)
downloadplatform_external_opencensus-java-14936be783e11ed2cb0e5e55152dc49cdcd68efd.tar.gz
platform_external_opencensus-java-14936be783e11ed2cb0e5e55152dc49cdcd68efd.tar.bz2
platform_external_opencensus-java-14936be783e11ed2cb0e5e55152dc49cdcd68efd.zip
removed test prefix from test methods; updated readme
Diffstat (limited to 'contrib')
-rw-r--r--contrib/spring/README.md9
-rw-r--r--contrib/spring/src/test/java/io/opencensus/contrib/spring/aop/CensusSpringAspectTest.java12
2 files changed, 15 insertions, 6 deletions
diff --git a/contrib/spring/README.md b/contrib/spring/README.md
index 590921e3..27551930 100644
--- a/contrib/spring/README.md
+++ b/contrib/spring/README.md
@@ -149,3 +149,12 @@ span name to be specified.
[appveyor-url]: https://ci.appveyor.com/project/opencensusjavateam/opencensus-java/branch/master
[maven-image]: https://maven-badges.herokuapp.com/maven-central/io.opencensus/opencensus-contrib-spring/badge.svg
[maven-url]: https://maven-badges.herokuapp.com/maven-central/io.opencensus/opencensus-contrib-spring
+
+#### Java Versions
+
+Java 6 or above is required for using this artifact.
+
+#### About the `aop` package
+
+`opencensus-contrib-spring` makes heavy use of Aspect Oriented Programming [AOP](https://en.wikipedia.org/wiki/Aspect-oriented_programming) to
+add behavior to annotations. Fortunately, Spring supports this natively so we can leverage the capabilities they've already built in.
diff --git a/contrib/spring/src/test/java/io/opencensus/contrib/spring/aop/CensusSpringAspectTest.java b/contrib/spring/src/test/java/io/opencensus/contrib/spring/aop/CensusSpringAspectTest.java
index 3a3d3d67..3e4415cf 100644
--- a/contrib/spring/src/test/java/io/opencensus/contrib/spring/aop/CensusSpringAspectTest.java
+++ b/contrib/spring/src/test/java/io/opencensus/contrib/spring/aop/CensusSpringAspectTest.java
@@ -78,7 +78,7 @@ public class CensusSpringAspectTest {
}
@Test
- public void testTracedUsesMethodAsSpanName() throws Exception {
+ public void tracedUsesMethodAsSpanName() throws Exception {
// When
Sample sample = (Sample) context.getBean("sample");
sample.call(100);
@@ -91,7 +91,7 @@ public class CensusSpringAspectTest {
}
@Test
- public void testTracedAcceptsCustomSpanName() throws Exception {
+ public void tracedAcceptsCustomSpanName() throws Exception {
// When
Sample sample = (Sample) context.getBean("sample");
sample.custom(100);
@@ -104,7 +104,7 @@ public class CensusSpringAspectTest {
}
@Test
- public void testHandlesException() {
+ public void handlesException() {
// When
Sample sample = (Sample) context.getBean("sample");
try {
@@ -131,7 +131,7 @@ public class CensusSpringAspectTest {
}
@Test
- public void testSqlExecute() throws Exception {
+ public void sqlExecute() throws Exception {
// When
String sql = "select 1";
Sample sample = (Sample) context.getBean("sample");
@@ -149,7 +149,7 @@ public class CensusSpringAspectTest {
}
@Test
- public void testSqlQuery() throws Exception {
+ public void sqlQuery() throws Exception {
// When
String sql = "select 2";
Sample sample = (Sample) context.getBean("sample");
@@ -168,7 +168,7 @@ public class CensusSpringAspectTest {
}
@Test
- public void testSqlUpdate() throws Exception {
+ public void sqlUpdate() throws Exception {
// When
String sql = "update content set value = 1";
Sample sample = (Sample) context.getBean("sample");