diff options
| author | Bogdan Drutu <bdrutu@google.com> | 2017-06-30 11:12:56 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2017-06-30 11:12:56 -0700 |
| commit | 07d69996286f6800be2d3977571cac0a80bb4e7c (patch) | |
| tree | 0411a46146d208b253c5bb633203905b6f84dda1 /benchmarks | |
| parent | 1989720ea57fc40a4a2aaedcfb09fe988e9b186d (diff) | |
| download | platform_external_opencensus-java-07d69996286f6800be2d3977571cac0a80bb4e7c.tar.gz platform_external_opencensus-java-07d69996286f6800be2d3977571cac0a80bb4e7c.tar.bz2 platform_external_opencensus-java-07d69996286f6800be2d3977571cac0a80bb4e7c.zip | |
Change API to remove the "Option" logic and keep only Builder. (#380)
Diffstat (limited to 'benchmarks')
3 files changed, 8 insertions, 9 deletions
diff --git a/benchmarks/src/jmh/java/io/opencensus/trace/RecordTraceEventsNonSampledSpanBenchmark.java b/benchmarks/src/jmh/java/io/opencensus/trace/RecordTraceEventsNonSampledSpanBenchmark.java index 3013e764..06a1412f 100644 --- a/benchmarks/src/jmh/java/io/opencensus/trace/RecordTraceEventsNonSampledSpanBenchmark.java +++ b/benchmarks/src/jmh/java/io/opencensus/trace/RecordTraceEventsNonSampledSpanBenchmark.java @@ -36,9 +36,9 @@ public class RecordTraceEventsNonSampledSpanBenchmark { private static final String ATTRIBUTE_KEY = "MyAttributeKey"; private static final String ATTRIBUTE_VALUE = "MyAttributeValue"; private Span linkedSpan = - tracer.spanBuilder(SPAN_NAME).becomeRoot().setSampler(Samplers.neverSample()).startSpan(); + tracer.spanBuilder(null, SPAN_NAME).setSampler(Samplers.neverSample()).startSpan(); private Span span = - tracer.spanBuilder(SPAN_NAME).becomeRoot().setSampler(Samplers.neverSample()).startSpan(); + tracer.spanBuilder(null, SPAN_NAME).setSampler(Samplers.neverSample()).startSpan(); /** TearDown method. */ @TearDown diff --git a/benchmarks/src/jmh/java/io/opencensus/trace/RecordTraceEventsSampledSpanBenchmark.java b/benchmarks/src/jmh/java/io/opencensus/trace/RecordTraceEventsSampledSpanBenchmark.java index ccfbc775..5773923f 100644 --- a/benchmarks/src/jmh/java/io/opencensus/trace/RecordTraceEventsSampledSpanBenchmark.java +++ b/benchmarks/src/jmh/java/io/opencensus/trace/RecordTraceEventsSampledSpanBenchmark.java @@ -36,9 +36,9 @@ public class RecordTraceEventsSampledSpanBenchmark { private static final String ATTRIBUTE_KEY = "MyAttributeKey"; private static final String ATTRIBUTE_VALUE = "MyAttributeValue"; private Span linkedSpan = - tracer.spanBuilder(SPAN_NAME).becomeRoot().setSampler(Samplers.alwaysSample()).startSpan(); + tracer.spanBuilder(null, SPAN_NAME).setSampler(Samplers.alwaysSample()).startSpan(); private Span span = - tracer.spanBuilder(SPAN_NAME).becomeRoot().setSampler(Samplers.alwaysSample()).startSpan(); + tracer.spanBuilder(null, SPAN_NAME).setSampler(Samplers.alwaysSample()).startSpan(); /** TearDown method. */ @TearDown diff --git a/benchmarks/src/jmh/java/io/opencensus/trace/StartEndSpanBenchmark.java b/benchmarks/src/jmh/java/io/opencensus/trace/StartEndSpanBenchmark.java index 0a86b6f8..8418184f 100644 --- a/benchmarks/src/jmh/java/io/opencensus/trace/StartEndSpanBenchmark.java +++ b/benchmarks/src/jmh/java/io/opencensus/trace/StartEndSpanBenchmark.java @@ -23,13 +23,13 @@ import org.openjdk.jmh.annotations.Scope; import org.openjdk.jmh.annotations.State; import org.openjdk.jmh.annotations.TearDown; -/** Benchmarks for {@link SpanFactoryImpl} and {@link SpanImpl}. */ +/** Benchmarks for {@link SpanBuilderImpl} and {@link SpanImpl}. */ @State(Scope.Benchmark) public class StartEndSpanBenchmark { private static final Tracer tracer = Tracing.getTracer(); private static final String SPAN_NAME = "MySpanName"; private Span rootSpan = - tracer.spanBuilder(SPAN_NAME).becomeRoot().setSampler(Samplers.neverSample()).startSpan(); + tracer.spanBuilder(null, SPAN_NAME).setSampler(Samplers.neverSample()).startSpan(); @TearDown public void doTearDown() { @@ -45,7 +45,7 @@ public class StartEndSpanBenchmark { @OutputTimeUnit(TimeUnit.NANOSECONDS) public Span startEndNonSampledRootSpan() { Span span = - tracer.spanBuilder(SPAN_NAME).becomeRoot().setSampler(Samplers.neverSample()).startSpan(); + tracer.spanBuilder(null, SPAN_NAME).setSampler(Samplers.neverSample()).startSpan(); span.end(); return span; } @@ -60,8 +60,7 @@ public class StartEndSpanBenchmark { public Span startEndRecordEventsRootSpan() { Span span = tracer - .spanBuilder(SPAN_NAME) - .becomeRoot() + .spanBuilder(null, SPAN_NAME) .setSampler(Samplers.neverSample()) .setRecordEvents(true) .startSpan(); |