Merge pull request #804 from sebright/update-error-prone-warnings-for-2.1.2

Update lists of enabled Error Prone warnings with the latest bug patterns.

6 files changed, 22 insertions, 0 deletions

diff --git a/api/src/main/java/io/opencensus/common/OpenCensusLibraryInformation.java b/api/src/main/java/io/opencensus/common/OpenCensusLibraryInformation.java
index aa5d69d5..91771644 100644
--- a/api/src/main/java/io/opencensus/common/OpenCensusLibraryInformation.java
+++ b/api/src/main/java/io/opencensus/common/OpenCensusLibraryInformation.java
@@ -22,4 +22,6 @@ public final class OpenCensusLibraryInformation {
 
   /** The current version of the OpenCensus Java library. */
   public static final String VERSION = "0.9.0-SNAPSHOT"; // CURRENT_OPENCENSUS_VERSION
+
+  private OpenCensusLibraryInformation() {}
 }
diff --git a/api/src/main/java/io/opencensus/common/TimeUtil.java b/api/src/main/java/io/opencensus/common/TimeUtil.java
index ab64c5df..09b3ddf9 100644
--- a/api/src/main/java/io/opencensus/common/TimeUtil.java
+++ b/api/src/main/java/io/opencensus/common/TimeUtil.java
@@ -23,4 +23,6 @@ final class TimeUtil {
   static final long MILLIS_PER_SECOND = 1000L;
   static final long NANOS_PER_MILLI = 1000 * 1000;
   static final long NANOS_PER_SECOND = NANOS_PER_MILLI * MILLIS_PER_SECOND;
+
+  private TimeUtil() {}
 }
diff --git a/api/src/main/java/io/opencensus/internal/Provider.java b/api/src/main/java/io/opencensus/internal/Provider.java
index 25cb82b0..8cfb7294 100644
--- a/api/src/main/java/io/opencensus/internal/Provider.java
+++ b/api/src/main/java/io/opencensus/internal/Provider.java
@@ -28,6 +28,7 @@ import java.util.ServiceConfigurationError;
  * }</pre>
  */
 public final class Provider {
+  private Provider() {}
 
   /**
    * Tries to create an instance of the given rawClass as a subclass of the given superclass.
diff --git a/api/src/main/java/io/opencensus/stats/NoopStats.java b/api/src/main/java/io/opencensus/stats/NoopStats.java
index ac9329f6..55c424c7 100644
--- a/api/src/main/java/io/opencensus/stats/NoopStats.java
+++ b/api/src/main/java/io/opencensus/stats/NoopStats.java
@@ -34,6 +34,7 @@ import io.opencensus.tags.TagValue;
 import java.util.Collections;
 import java.util.List;
 import java.util.Map;
+import javax.annotation.Nullable;
 import javax.annotation.concurrent.GuardedBy;
 import javax.annotation.concurrent.Immutable;
 import javax.annotation.concurrent.ThreadSafe;
@@ -165,6 +166,7 @@ final class NoopStats {
     }
 
     @Override
+    @Nullable
     public ViewData getView(View.Name name) {
       checkNotNull(name, "name");
       synchronized (views) {
diff --git a/api/src/test/java/io/opencensus/tags/TagContextTest.java b/api/src/test/java/io/opencensus/tags/TagContextTest.java
index 813e1a76..b5c44b15 100644
--- a/api/src/test/java/io/opencensus/tags/TagContextTest.java
+++ b/api/src/test/java/io/opencensus/tags/TagContextTest.java
@@ -23,6 +23,7 @@ import com.google.common.testing.EqualsTester;
 import java.util.Collections;
 import java.util.Iterator;
 import java.util.List;
+import javax.annotation.Nullable;
 import org.junit.Test;
 import org.junit.runner.RunWith;
 import org.junit.runners.JUnit4;
@@ -85,6 +86,9 @@ public final class TagContextTest {
   private static final class SimpleTagContext extends TagContext {
     private final List<Tag> tags;
 
+    // This Error Prone warning doesn't seem correct, because the constructor is just calling
+    // another constructor.
+    @SuppressWarnings("ConstructorLeaksThis")
     SimpleTagContext(Tag... tags) {
       this(Lists.newArrayList(tags));
     }
@@ -94,6 +98,7 @@ public final class TagContextTest {
     }
 
     @Override
+    @Nullable
     protected Iterator<Tag> getIterator() {
       return tags == null ? null : tags.iterator();
     }
diff --git a/api/src/test/java/io/opencensus/trace/AttributeValueTest.java b/api/src/test/java/io/opencensus/trace/AttributeValueTest.java
index b7e0afbd..e505c59b 100644
--- a/api/src/test/java/io/opencensus/trace/AttributeValueTest.java
+++ b/api/src/test/java/io/opencensus/trace/AttributeValueTest.java
@@ -22,6 +22,7 @@ import static org.junit.Assert.fail;
 import com.google.common.testing.EqualsTester;
 import io.opencensus.common.Function;
 import io.opencensus.common.Functions;
+import javax.annotation.Nullable;
 import org.junit.Test;
 import org.junit.runner.RunWith;
 import org.junit.runners.JUnit4;
@@ -35,6 +36,7 @@ public class AttributeValueTest {
     attribute.match(
         new Function<String, Object>() {
           @Override
+          @Nullable
           public Object apply(String stringValue) {
             assertThat(stringValue).isEqualTo("MyStringAttributeValue");
             return null;
@@ -42,6 +44,7 @@ public class AttributeValueTest {
         },
         new Function<Boolean, Object>() {
           @Override
+          @Nullable
           public Object apply(Boolean booleanValue) {
             fail("Expected a String");
             return null;
@@ -49,6 +52,7 @@ public class AttributeValueTest {
         },
         new Function<Long, Object>() {
           @Override
+          @Nullable
           public Object apply(Long longValue) {
             fail("Expected a String");
             return null;
@@ -63,6 +67,7 @@ public class AttributeValueTest {
     attribute.match(
         new Function<String, Object>() {
           @Override
+          @Nullable
           public Object apply(String stringValue) {
             fail("Expected a Boolean");
             return null;
@@ -70,6 +75,7 @@ public class AttributeValueTest {
         },
         new Function<Boolean, Object>() {
           @Override
+          @Nullable
           public Object apply(Boolean booleanValue) {
             assertThat(booleanValue).isTrue();
             return null;
@@ -77,6 +83,7 @@ public class AttributeValueTest {
         },
         new Function<Long, Object>() {
           @Override
+          @Nullable
           public Object apply(Long longValue) {
             fail("Expected a Boolean");
             return null;
@@ -91,6 +98,7 @@ public class AttributeValueTest {
     attribute.match(
         new Function<String, Object>() {
           @Override
+          @Nullable
           public Object apply(String stringValue) {
             fail("Expected a Long");
             return null;
@@ -98,6 +106,7 @@ public class AttributeValueTest {
         },
         new Function<Boolean, Object>() {
           @Override
+          @Nullable
           public Object apply(Boolean booleanValue) {
             fail("Expected a Long");
             return null;
@@ -105,6 +114,7 @@ public class AttributeValueTest {
         },
         new Function<Long, Object>() {
           @Override
+          @Nullable
           public Object apply(Long longValue) {
             assertThat(longValue).isEqualTo(123456L);
             return null;