aboutsummaryrefslogtreecommitdiffstats
path: root/api/src/test
diff options
context:
space:
mode:
authorKristen Kozak <sebright@google.com>2017-11-08 13:00:03 -0800
committerKristen Kozak <sebright@google.com>2017-11-10 11:23:50 -0800
commit80b8b631b47e6db4cd3f543adeb4059b14d3033a (patch)
tree2db2958172745dd594c0aa49e983e297c619e1a5 /api/src/test
parent195946a4a96859979714b6b2c681116efdd3e8d2 (diff)
downloadplatform_external_opencensus-java-80b8b631b47e6db4cd3f543adeb4059b14d3033a.tar.gz
platform_external_opencensus-java-80b8b631b47e6db4cd3f543adeb4059b14d3033a.tar.bz2
platform_external_opencensus-java-80b8b631b47e6db4cd3f543adeb4059b14d3033a.zip
Deprecate Tags.setState, and throw an exception when it is called after getState.
This commit is related to #608. It deprecates Tags.setState and TagsComponent.setState and makes NoopTagsComponent.setState and TagsComponentImplBase.setState throw IllegalStateException when they are called after getState.
Diffstat (limited to 'api/src/test')
-rw-r--r--api/src/test/java/io/opencensus/tags/NoopTagsTest.java29
-rw-r--r--api/src/test/java/io/opencensus/tags/TagsTest.java2
2 files changed, 28 insertions, 3 deletions
diff --git a/api/src/test/java/io/opencensus/tags/NoopTagsTest.java b/api/src/test/java/io/opencensus/tags/NoopTagsTest.java
index 8434bd83..db07520e 100644
--- a/api/src/test/java/io/opencensus/tags/NoopTagsTest.java
+++ b/api/src/test/java/io/opencensus/tags/NoopTagsTest.java
@@ -50,19 +50,42 @@ public final class NoopTagsTest {
@Test
public void noopTagsComponent() {
- assertThat(NoopTags.getNoopTagsComponent().getTagger()).isSameAs(NoopTags.getNoopTagger());
- assertThat(NoopTags.getNoopTagsComponent().getTagPropagationComponent())
+ assertThat(NoopTags.newNoopTagsComponent().getTagger()).isSameAs(NoopTags.getNoopTagger());
+ assertThat(NoopTags.newNoopTagsComponent().getTagPropagationComponent())
.isSameAs(NoopTags.getNoopTagPropagationComponent());
}
@Test
+ @SuppressWarnings("deprecation")
public void noopTagsComponent_SetState_DisallowsNull() {
- TagsComponent noopTagsComponent = NoopTags.getNoopTagsComponent();
+ TagsComponent noopTagsComponent = NoopTags.newNoopTagsComponent();
thrown.expect(NullPointerException.class);
noopTagsComponent.setState(null);
}
@Test
+ @SuppressWarnings("deprecation")
+ public void preventSettingStateAfterGettingState_DifferentState() {
+ TagsComponent noopTagsComponent = NoopTags.newNoopTagsComponent();
+ noopTagsComponent.setState(TaggingState.DISABLED);
+ noopTagsComponent.getState();
+ thrown.expect(IllegalStateException.class);
+ thrown.expectMessage("State was already read, cannot set state.");
+ noopTagsComponent.setState(TaggingState.ENABLED);
+ }
+
+ @Test
+ @SuppressWarnings("deprecation")
+ public void preventSettingStateAfterGettingState_SameState() {
+ TagsComponent noopTagsComponent = NoopTags.newNoopTagsComponent();
+ noopTagsComponent.setState(TaggingState.DISABLED);
+ noopTagsComponent.getState();
+ thrown.expect(IllegalStateException.class);
+ thrown.expectMessage("State was already read, cannot set state.");
+ noopTagsComponent.setState(TaggingState.DISABLED);
+ }
+
+ @Test
public void noopTagger() {
Tagger noopTagger = NoopTags.getNoopTagger();
assertThat(noopTagger.empty()).isSameAs(NoopTags.getNoopTagContext());
diff --git a/api/src/test/java/io/opencensus/tags/TagsTest.java b/api/src/test/java/io/opencensus/tags/TagsTest.java
index e87407db..5cab5b45 100644
--- a/api/src/test/java/io/opencensus/tags/TagsTest.java
+++ b/api/src/test/java/io/opencensus/tags/TagsTest.java
@@ -62,12 +62,14 @@ public class TagsTest {
}
@Test
+ @SuppressWarnings("deprecation")
public void setState_IgnoresInput() {
Tags.setState(TaggingState.ENABLED);
assertThat(Tags.getState()).isEqualTo(TaggingState.DISABLED);
}
@Test(expected = NullPointerException.class)
+ @SuppressWarnings("deprecation")
public void setState_DisallowsNull() {
Tags.setState(null);
}