diff options
| author | Bogdan Drutu <bdrutu@google.com> | 2017-11-07 15:32:38 +1100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2017-11-07 15:32:38 +1100 |
| commit | 4833413b2a0e4fa6e4d4b7279f0b28e7e3479a56 (patch) | |
| tree | bb32667eaac1039cfdfeb70e7b21f831ae90c93c /api/src/test | |
| parent | f7550d9b06c204907345ea4e5dd5d8e6c3d6ed44 (diff) | |
| download | platform_external_opencensus-java-4833413b2a0e4fa6e4d4b7279f0b28e7e3479a56.tar.gz platform_external_opencensus-java-4833413b2a0e4fa6e4d4b7279f0b28e7e3479a56.tar.bz2 platform_external_opencensus-java-4833413b2a0e4fa6e4d4b7279f0b28e7e3479a56.zip | |
Add a setStatus method in the Span. (#779)
* Add a setStatus method in the Span.
* Update after feedback.
* Run ./gradlew goJF
* Update comment in EndSpanOptions.
Diffstat (limited to 'api/src/test')
| -rw-r--r-- | api/src/test/java/io/opencensus/trace/BlankSpanTest.java | 1 | ||||
| -rw-r--r-- | api/src/test/java/io/opencensus/trace/EndSpanOptionsTest.java | 15 |
2 files changed, 9 insertions, 7 deletions
diff --git a/api/src/test/java/io/opencensus/trace/BlankSpanTest.java b/api/src/test/java/io/opencensus/trace/BlankSpanTest.java index 4e8342e2..b9760c2f 100644 --- a/api/src/test/java/io/opencensus/trace/BlankSpanTest.java +++ b/api/src/test/java/io/opencensus/trace/BlankSpanTest.java @@ -55,6 +55,7 @@ public class BlankSpanTest { BlankSpan.INSTANCE.addNetworkEvent(NetworkEvent.builder(NetworkEvent.Type.SENT, 1L).build()); BlankSpan.INSTANCE.addLink( Link.fromSpanContext(SpanContext.INVALID, Link.Type.CHILD_LINKED_SPAN)); + BlankSpan.INSTANCE.setStatus(Status.OK); BlankSpan.INSTANCE.end(EndSpanOptions.DEFAULT); BlankSpan.INSTANCE.end(); } diff --git a/api/src/test/java/io/opencensus/trace/EndSpanOptionsTest.java b/api/src/test/java/io/opencensus/trace/EndSpanOptionsTest.java index cae21064..b6ab8e0e 100644 --- a/api/src/test/java/io/opencensus/trace/EndSpanOptionsTest.java +++ b/api/src/test/java/io/opencensus/trace/EndSpanOptionsTest.java @@ -26,19 +26,20 @@ import org.junit.runners.JUnit4; /** Unit tests for {@link EndSpanOptions}. */ @RunWith(JUnit4.class) public class EndSpanOptionsTest { - @Test(expected = NullPointerException.class) - public void setNullStatus() { - EndSpanOptions.builder().setStatus(null).build(); - } - @Test public void endSpanOptions_DefaultOptions() { - assertThat(EndSpanOptions.DEFAULT.getStatus()).isEqualTo(Status.OK); + assertThat(EndSpanOptions.DEFAULT.getStatus()).isNull(); assertThat(EndSpanOptions.DEFAULT.getSampleToLocalSpanStore()).isFalse(); } @Test - public void setStatus() { + public void setStatus_Ok() { + EndSpanOptions endSpanOptions = EndSpanOptions.builder().setStatus(Status.OK).build(); + assertThat(endSpanOptions.getStatus()).isEqualTo(Status.OK); + } + + @Test + public void setStatus_Error() { EndSpanOptions endSpanOptions = EndSpanOptions.builder() .setStatus(Status.CANCELLED.withDescription("ThisIsAnError")) |
