aboutsummaryrefslogtreecommitdiffstats
path: root/api/src/test
diff options
context:
space:
mode:
authorBogdan Drutu <bdrutu@google.com>2017-08-29 22:33:13 -0700
committerGitHub <noreply@github.com>2017-08-29 22:33:13 -0700
commit1fb102567c48b02ece1f8a7d8ba50cacab1f46d1 (patch)
tree9aeecbfd21c38d3e6c07928c78859d40cf0637bc /api/src/test
parent45f115a4c5966ebc8ec4fd04bafe8f967915703e (diff)
downloadplatform_external_opencensus-java-1fb102567c48b02ece1f8a7d8ba50cacab1f46d1.tar.gz
platform_external_opencensus-java-1fb102567c48b02ece1f8a7d8ba50cacab1f46d1.tar.bz2
platform_external_opencensus-java-1fb102567c48b02ece1f8a7d8ba50cacab1f46d1.zip
Add new api that is easier to use for user to add only one Attribute. (#571)
* Add new api that is easier to use for user to add only one Attribute. * Rename addAttribute[s] to putAttribute[s] and deprecate the old API. * Update tests to use putAttributes.
Diffstat (limited to 'api/src/test')
-rw-r--r--api/src/test/java/io/opencensus/trace/BlankSpanTest.java2
-rw-r--r--api/src/test/java/io/opencensus/trace/SpanTest.java12
2 files changed, 14 insertions, 0 deletions
diff --git a/api/src/test/java/io/opencensus/trace/BlankSpanTest.java b/api/src/test/java/io/opencensus/trace/BlankSpanTest.java
index 8f7993ef..4e8342e2 100644
--- a/api/src/test/java/io/opencensus/trace/BlankSpanTest.java
+++ b/api/src/test/java/io/opencensus/trace/BlankSpanTest.java
@@ -44,6 +44,8 @@ public class BlankSpanTest {
multipleAttributes.put("MyBooleanAttributeKey", AttributeValue.booleanAttributeValue(true));
multipleAttributes.put("MyLongAttributeKey", AttributeValue.longAttributeValue(123));
// Tests only that all the methods are not crashing/throwing errors.
+ BlankSpan.INSTANCE.putAttribute(
+ "MyStringAttributeKey2", AttributeValue.stringAttributeValue("MyStringAttributeValue2"));
BlankSpan.INSTANCE.addAttributes(attributes);
BlankSpan.INSTANCE.addAttributes(multipleAttributes);
BlankSpan.INSTANCE.addAnnotation("MyAnnotation");
diff --git a/api/src/test/java/io/opencensus/trace/SpanTest.java b/api/src/test/java/io/opencensus/trace/SpanTest.java
index 1a25d6b7..5d36bb14 100644
--- a/api/src/test/java/io/opencensus/trace/SpanTest.java
+++ b/api/src/test/java/io/opencensus/trace/SpanTest.java
@@ -17,9 +17,11 @@
package io.opencensus.trace;
import static com.google.common.truth.Truth.assertThat;
+import static org.mockito.Matchers.eq;
import static org.mockito.Matchers.same;
import static org.mockito.Mockito.verify;
+import java.util.Collections;
import java.util.EnumSet;
import java.util.Map;
import java.util.Random;
@@ -82,6 +84,16 @@ public class SpanTest {
}
@Test
+ public void addAttributeCallsAddAttributesByDefault() {
+ Span span = Mockito.spy(new NoopSpan(spanContext, spanOptions));
+ span.putAttribute("MyKey", AttributeValue.booleanAttributeValue(true));
+ span.end();
+ verify(span)
+ .addAttributes(
+ eq(Collections.singletonMap("MyKey", AttributeValue.booleanAttributeValue(true))));
+ }
+
+ @Test
public void endCallsEndWithDefaultOptions() {
Span span = Mockito.spy(new NoopSpan(spanContext, spanOptions));
span.end();