aboutsummaryrefslogtreecommitdiffstats
path: root/testscripts
diff options
context:
space:
mode:
authoryaberauneya <yaberauneya>2009-12-22 03:28:25 +0000
committeryaberauneya <yaberauneya>2009-12-22 03:28:25 +0000
commitf94a46d978543a96d9ae91ae68b6a42810956490 (patch)
tree8ede0f6846b8d8a508a1a6eee165c437ccaeba6d /testscripts
parentec789bce166000314289848db086df8886e3a2b0 (diff)
downloadplatform_external_ltp-f94a46d978543a96d9ae91ae68b6a42810956490.tar.gz
platform_external_ltp-f94a46d978543a96d9ae91ae68b6a42810956490.tar.bz2
platform_external_ltp-f94a46d978543a96d9ae91ae68b6a42810956490.zip
Apply the fix for the issue noted below.
Signed-off-by: Garrett Cooper <yanegomi@gmail.com> Hi, I ran "runltp" with "ltp-2009-12-16" cvs. And I found the following failure in "BindMounts" testcase: ------------ sh: /opt/ltp/testscripts/test_fs_bind.sh: Permission denied ------------ When I added execution permission and tested this testcase, the following errors occurred. ------------ ls: /opt/ltp/testcases/kernel/fs/fs_bind/move/test*: No such file or directory ls: /opt/ltp/testcases/kernel/fs/fs_bind/bind/test*: No such file or directory ls: /opt/ltp/testcases/kernel/fs/fs_bind/rbind/test*: No such file or directory ls: /opt/ltp/testcases/kernel/fs/fs_bind/regression/test*: No such file or directory ------------ This error is caused by following: (1) Execution files haven't permissions. (2) "${LTPROOT}" directory isn't the current directory in which "make install" executed. By default, "${LTPROOT}" directory is "/opt/ltp". (3) ".../ltp-2009-12-16/testcases/kernel/fs/fs_bind/" directory does exist, but "/opt/ltp/testcases/kernel/fs/fs_bind/" directory doesn't exist. (I want to suggest using "/opt/ltp/testcases/bin/fs_bind/" instead of "/opt/ltp/testcases/kernel/fs/fs_bind/".) Then, I think that it requires following three modifications to run "BindMounts" test exactly: (1) Add the execution permissions to "${LTPROOT}/testscripts" directory when installation. (2) Deploy following four directories under the "${LTPROOT}/testcases/bin" directory when installation. "./fs_bind/move/" "./fs_bind/bind/" "./fs_bind/rbind/" "./fs_bind/regression/" (3) Apply the following patch: ============ --- test_fs_bind.sh 2008-06-29 04:30:19.000000000 +0900 +++ test_fs_bind.sh.new 2009-12-17 11:32:27.000000000 +0900 @@ -60,7 +60,7 @@ LTPROOT="${PWD}" fi - FS_BIND_ROOT="${LTPROOT}/testcases/kernel/fs/fs_bind" + FS_BIND_ROOT="${LTPROOT}/testcases/bin/fs_bind" total=0 # total number of tests for dir in "${test_dirs[@]}" ; do ============ Regards-- -Tomonori Mitani
Diffstat (limited to 'testscripts')
-rw-r--r--testscripts/Makefile2
-rwxr-xr-xtestscripts/test_fs_bind.sh2
2 files changed, 2 insertions, 2 deletions
diff --git a/testscripts/Makefile b/testscripts/Makefile
index cc25e2470..c0cec1501 100644
--- a/testscripts/Makefile
+++ b/testscripts/Makefile
@@ -26,7 +26,7 @@ include $(top_srcdir)/include/mk/env_pre.mk
INSTALL_DIR := testscripts
-INSTALL_MODE := 00644
+INSTALL_MODE := 00755
INSTALL_TARGETS := *.sh
diff --git a/testscripts/test_fs_bind.sh b/testscripts/test_fs_bind.sh
index 30eafa956..39a237e45 100755
--- a/testscripts/test_fs_bind.sh
+++ b/testscripts/test_fs_bind.sh
@@ -60,7 +60,7 @@ test_setup()
LTPROOT="${PWD}"
fi
- FS_BIND_ROOT="${LTPROOT}/testcases/kernel/fs/fs_bind"
+ FS_BIND_ROOT="${LTPROOT}/testcases/bin/fs_bind"
total=0 # total number of tests
for dir in "${test_dirs[@]}" ; do