diff options
author | Luis Hector Chavez <lhchavez@google.com> | 2018-09-18 11:08:11 -0700 |
---|---|---|
committer | Luis Hector Chavez <lhchavez@google.com> | 2018-09-25 15:47:35 +0000 |
commit | 5f1197afff4d4303a93ada7786c8eb572b78ae6e (patch) | |
tree | 8caabc515e0ab21d51d80f8d7020ada0e383065c /soong | |
parent | 8bf88c8f319126520347be55342761abfba6a61a (diff) | |
download | platform_external_libchrome-5f1197afff4d4303a93ada7786c8eb572b78ae6e.tar.gz platform_external_libchrome-5f1197afff4d4303a93ada7786c8eb572b78ae6e.tar.bz2 platform_external_libchrome-5f1197afff4d4303a93ada7786c8eb572b78ae6e.zip |
libchrome: Fixup the soong pluginandroid-o-mr1-iot-release-1.0.5
This change addresses a subset of the comments left after landing
https://android-review.googlesource.com/c/platform/external/libchrome/+/757314
Bug: 109924413
Test: m
Change-Id: Id4ac6aa81e13aa382e3b009900f7e4f8ee987098
Diffstat (limited to 'soong')
-rw-r--r-- | soong/bindings_generator.go | 15 |
1 files changed, 5 insertions, 10 deletions
diff --git a/soong/bindings_generator.go b/soong/bindings_generator.go index 36462cb03..3d0e7f5da 100644 --- a/soong/bindings_generator.go +++ b/soong/bindings_generator.go @@ -3,7 +3,6 @@ package libchrome import ( "fmt" "path" - "path/filepath" "strings" "android/soong/android" @@ -23,7 +22,7 @@ var ( pctx = android.NewPackageContext("android/soong/external/libchrome") mojomBindingsGenerator = pctx.HostBinToolVariable("mojomBindingsGenerator", "mojom_bindings_generator") - mergeSrcjars = pctx.HostBinToolVariable("mergeSrcjars", "merge_srcjars") + mergeZips = pctx.HostBinToolVariable("mergeZips", "merge_zips") generateMojomPicklesRule = pctx.StaticRule("generateMojomPicklesRule", blueprint.RuleParams{ Command: `${mojomBindingsGenerator} @@ -56,9 +55,9 @@ var ( }, "generator", "package", "flags", "outDir", "templateDir") mergeSrcjarsRule = pctx.StaticRule("mergeSrcjarsRule", blueprint.RuleParams{ - Command: "${mergeSrcjars} --output=${out} ${in}", + Command: "${mergeZips} ${out} ${in}", CommandDeps: []string{ - "${mergeSrcjars}", + "${mergeZips}", }, Description: "Merge .srcjars $in => $out", }) @@ -155,12 +154,8 @@ func (p *mojomGenerationProperties) flags(ctx android.ModuleContext) string { for _, typemap := range ctx.ExpandSources(p.Typemaps, nil) { flags = append(flags, fmt.Sprintf("--typemap=%s", typemap.String())) } - for _, include := range p.Includes { - includePath, err := filepath.Abs(include) - if err != nil { - ctx.PropertyErrorf("includes", "Failed to get the absolute path for %s: %q", include, err) - } - flags = append(flags, fmt.Sprintf("-I=%s:%s", includePath, includePath)) + for _, include := range android.PathsForSource(ctx, p.Includes) { + flags = append(flags, fmt.Sprintf("-I=%s:%s", include, include)) } for _, pickle := range p.Pickles { m := android.SrcIsModule(pickle) |