aboutsummaryrefslogtreecommitdiffstats
path: root/plat
diff options
context:
space:
mode:
authorJonathan Wright <jonathan.wright@arm.com>2018-03-14 17:55:32 +0000
committerJonathan Wright <jonathan.wright@arm.com>2018-03-26 12:43:05 +0100
commit8ae0df93a01bfd869fa80068b5df17359d798714 (patch)
tree5d3a0ff72d95b889e72daa8af468e68775f8dbc4 /plat
parentb7229e4919044a747c500c9d082168aa032eb3bf (diff)
downloadplatform_external_arm-trusted-firmware-8ae0df93a01bfd869fa80068b5df17359d798714.tar.gz
platform_external_arm-trusted-firmware-8ae0df93a01bfd869fa80068b5df17359d798714.tar.bz2
platform_external_arm-trusted-firmware-8ae0df93a01bfd869fa80068b5df17359d798714.zip
plat/common: remove fall-through on release build
Removes fall-through in switch statement on unknown interrupt type in release builds. Previous behaviour was to assert(0) on default case in debug builds but fall through and interpret the unknown interrupt type as INTR_TYPE_EL3 in release builds. Change-Id: I05fb0299608efda0f9eda2288d3e56e5625e05c9 Signed-off-by: Jonathan Wright <jonathan.wright@arm.com>
Diffstat (limited to 'plat')
-rw-r--r--plat/common/plat_gicv3.c5
1 files changed, 2 insertions, 3 deletions
diff --git a/plat/common/plat_gicv3.c b/plat/common/plat_gicv3.c
index 030eea723..cf9aca229 100644
--- a/plat/common/plat_gicv3.c
+++ b/plat/common/plat_gicv3.c
@@ -158,15 +158,14 @@ uint32_t plat_interrupt_type_to_line(uint32_t type,
return __builtin_ctz(SCR_FIQ_BIT);
else
return __builtin_ctz(SCR_IRQ_BIT);
- default:
- assert(0);
- /* Fall through in the release build */
case INTR_TYPE_EL3:
/*
* The EL3 interrupts are signaled as FIQ in both S-EL0/1 and
* NS-EL0/1/2 contexts
*/
return __builtin_ctz(SCR_FIQ_BIT);
+ default:
+ panic();
}
}