diff options
| author | Justin Chadwell <justin.chadwell@arm.com> | 2019-09-18 14:13:42 +0100 |
|---|---|---|
| committer | Madhukar Pappireddy <madhukar.pappireddy@arm.com> | 2019-11-19 08:53:21 -0600 |
| commit | d7b4cd4111ab4cfde60f693a789a290870c02035 (patch) | |
| tree | 41b110018b3ff623d20cef2ca29a71185f5d2fa1 /drivers | |
| parent | b7f6525db642d533327403ff8130eb91190f2e98 (diff) | |
| download | platform_external_arm-trusted-firmware-d7b4cd4111ab4cfde60f693a789a290870c02035.tar.gz platform_external_arm-trusted-firmware-d7b4cd4111ab4cfde60f693a789a290870c02035.tar.bz2 platform_external_arm-trusted-firmware-d7b4cd4111ab4cfde60f693a789a290870c02035.zip | |
Enable -Wlogical-op always
-Wlogical-op prevents common errors with using numerical constants where
a boolean one is expected as well as when the operands of a logical
operator are the same. While these are perfectly valid behavior, they
can be a sign that something is slightly off.
This patch adds this warning to gcc and it's closest equivalent to
clang, while also fixing any warnings that enabling them causes.
Change-Id: Iabadfc1e6ee0c44eef6685a23b0aed8abef8ce89
Signed-off-by: Justin Chadwell <justin.chadwell@arm.com>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/mentor/i2c/mi2cv.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/mentor/i2c/mi2cv.c b/drivers/mentor/i2c/mi2cv.c index 1cdcf7478..b0270c955 100644 --- a/drivers/mentor/i2c/mi2cv.c +++ b/drivers/mentor/i2c/mi2cv.c @@ -81,14 +81,14 @@ static void mentor_i2c_interrupt_clear(void) udelay(1); } -static int mentor_i2c_interrupt_get(void) +static bool mentor_i2c_interrupt_get(void) { uint32_t reg; /* get the interrupt flag bit */ reg = mmio_read_32((uintptr_t)&base->control); reg &= I2C_CONTROL_IFLG; - return reg && I2C_CONTROL_IFLG; + return (reg != 0U); } static int mentor_i2c_wait_interrupt(void) |