diff options
| author | Yann Gautier <yann.gautier@st.com> | 2018-11-09 15:57:18 +0100 |
|---|---|---|
| committer | Yann Gautier <yann.gautier@st.com> | 2018-11-09 18:22:08 +0100 |
| commit | 3e6fab43085b0f3ecb05339d81edad86dd091a52 (patch) | |
| tree | d63f08179e243909c35d8ace147a5774264876d6 /drivers | |
| parent | 4cb17707b5c83e47477d743cb1129fc0c75a15c1 (diff) | |
| download | platform_external_arm-trusted-firmware-3e6fab43085b0f3ecb05339d81edad86dd091a52.tar.gz platform_external_arm-trusted-firmware-3e6fab43085b0f3ecb05339d81edad86dd091a52.tar.bz2 platform_external_arm-trusted-firmware-3e6fab43085b0f3ecb05339d81edad86dd091a52.zip | |
stm32mp1: correct some static analysis tools issues
These issues wer found by sparse:
drivers/st/clk/stm32mp1_clk.c:1524:19:
warning: incorrect type in assignment (different base types)
expected restricted fdt32_t const [usertype] *pkcs_cell
got unsigned int const [usertype] *
plat/st/stm32mp1/plat_image_load.c:13:6:
warning: symbol 'plat_flush_next_bl_params' was not declared.
Should it be static?
plat/st/stm32mp1/plat_image_load.c:21:16:
warning: symbol 'plat_get_bl_image_load_info' was not declared.
Should it be static?
plat/st/stm32mp1/plat_image_load.c:29:13:
warning: symbol 'plat_get_next_bl_params' was not declared.
Should it be static?
plat/st/stm32mp1/bl2_io_storage.c:40:10:
warning: symbol 'block_buffer' was not declared. Should it be static?
Signed-off-by: Yann Gautier <yann.gautier@st.com>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/st/clk/stm32mp1_clk.c | 4 | ||||
| -rw-r--r-- | drivers/st/clk/stm32mp1_clkfunc.c | 6 |
2 files changed, 5 insertions, 5 deletions
diff --git a/drivers/st/clk/stm32mp1_clk.c b/drivers/st/clk/stm32mp1_clk.c index f0bf363e2..b8457cb37 100644 --- a/drivers/st/clk/stm32mp1_clk.c +++ b/drivers/st/clk/stm32mp1_clk.c @@ -1323,7 +1323,7 @@ int stm32mp1_clk_init(void) int ret, len; enum stm32mp1_pll_id i; bool lse_css = false; - const uint32_t *pkcs_cell; + const fdt32_t *pkcs_cell; /* Check status field to disable security */ if (!fdt_get_rcc_secure_status()) { @@ -1529,7 +1529,7 @@ int stm32mp1_clk_init(void) priv->pkcs_usb_value = 0; for (j = 0; j < ((uint32_t)len / sizeof(uint32_t)); j++) { - uint32_t pkcs = (uint32_t)fdt32_to_cpu(pkcs_cell[j]); + uint32_t pkcs = fdt32_to_cpu(pkcs_cell[j]); if (pkcs == (uint32_t)CLK_CKPER_DISABLED) { ckper_disabled = true; diff --git a/drivers/st/clk/stm32mp1_clkfunc.c b/drivers/st/clk/stm32mp1_clkfunc.c index d4c69cb4e..078d803e7 100644 --- a/drivers/st/clk/stm32mp1_clkfunc.c +++ b/drivers/st/clk/stm32mp1_clkfunc.c @@ -265,11 +265,11 @@ int fdt_rcc_subnode_offset(const char *name) * This function gets the pointer to a rcc-clk property from its name. * It reads the values indicated inside the device tree. * Length of the property is stored in the second parameter. - * Returns pointer if success, and NULL value else. + * Returns pointer on success, and NULL value on failure. ******************************************************************************/ -const uint32_t *fdt_rcc_read_prop(const char *prop_name, int *lenp) +const fdt32_t *fdt_rcc_read_prop(const char *prop_name, int *lenp) { - const uint32_t *cuint; + const fdt32_t *cuint; int node, len; void *fdt; |