diff options
| author | Jamie Madill <jmadill@chromium.org> | 2021-09-08 12:31:47 -0400 |
|---|---|---|
| committer | Angle LUCI CQ <angle-scoped@luci-project-accounts.iam.gserviceaccount.com> | 2021-09-10 19:02:19 +0000 |
| commit | 0e021199ac2517c4c51234bba2414d4a6f7f5e92 (patch) | |
| tree | 352f67762e48c24c07b296ebb675fedb519c2e3a | |
| parent | ac453e29bffd39333e4397ac468d2557cdec8b2e (diff) | |
| download | platform_external_angle-0e021199ac2517c4c51234bba2414d4a6f7f5e92.tar.gz platform_external_angle-0e021199ac2517c4c51234bba2414d4a6f7f5e92.tar.bz2 platform_external_angle-0e021199ac2517c4c51234bba2414d4a6f7f5e92.zip | |
Gold Tests: Append "show all results" to triage links.
This should allow for easier triage when CL authors run into new
images that don't match the goldens.
Bug: skia:12428
Change-Id: I60fee615f23f5a1b36ddbe6c6708498fb3def46e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3149571
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
| -rwxr-xr-x | src/tests/restricted_traces/restricted_trace_gold_tests.py | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/src/tests/restricted_traces/restricted_trace_gold_tests.py b/src/tests/restricted_traces/restricted_trace_gold_tests.py index f3fe55b3a..35be55420 100755 --- a/src/tests/restricted_traces/restricted_trace_gold_tests.py +++ b/src/tests/restricted_traces/restricted_trace_gold_tests.py @@ -304,7 +304,9 @@ def upload_test_result_to_skia_gold(args, gold_session_manager, gold_session, go logging.error('Failed to get triage link for %s, raw output: %s', image_name, error) logging.error('Reason for no triage link: %s', gold_session.GetTriageLinkOmissionReason(image_name)) - elif gold_properties.IsTryjobRun(): + if gold_properties.IsTryjobRun(): + # Pick "show all results" so we can see the tryjob images by default. + triage_link += '&master=true' artifacts['triage_link_for_entire_cl'] = [triage_link] else: artifacts['gold_triage_link'] = [triage_link] |