path: root/ChangeLog

commit 9fe2de783d
Author: Gerald Combs <gerald@wireshark.org>
Date:   Fri Feb 21 10:19:35 2020 -0800

    EAP: Remove a couple of string length assumptions.
    
    Don't assume our MNC and MCC string lengths are > 3.
    
    Bug: 16397
    Change-Id: I0759dcb9d0c5f078cf3a98e9323d9cb741e15dd4
    Reviewed-on: https://code.wireshark.org/review/36146
    Reviewed-by: Gerald Combs <gerald@wireshark.org>
    Petri-Dish: Gerald Combs <gerald@wireshark.org>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@gmail.com>
    (cherry picked from commit 8bda8642dfc8c9a870c6a48771566012353cc898)
    Reviewed-on: https://code.wireshark.org/review/36173

commit e3dea81173
Author: Gerald Combs <gerald@wireshark.org>
Date:   Sun Feb 23 08:58:20 2020 +0000

    [Automatic update for 2020-02-23]
    
    Update manuf, services enterprise numbers, translations, and other items.
    
    Change-Id: I11c1e21e2e716e190ae592e6ad135c5bc5f0a551
    Reviewed-on: https://code.wireshark.org/review/36164
    Reviewed-by: Gerald Combs <gerald@wireshark.org>

commit 4f00a466cd
Author: Guy Harris <guy@alum.mit.edu>
Date:   Sat Feb 22 20:35:43 2020 -0800

    Use "must" instead of "should" to avoid ambiguity.
    
    As I said in
    
        https://ask.wireshark.org/question/10361/how-to-properly-use-heuristic-dissector-for-tcp/?answer=10363#post-id-10363
    
      "Should" has multiple meanings; there's "Used to indicate obligation,
      duty, or correctness, typically when criticizing someone's actions.", as
      in "I think we should trust our people more", and there's "Used to
      indicate what is probable.", as in "the bus should arrive in a few
      minutes". You're reading it in the latter sense; it was intended in the
      former sense.
    
      That sentence should probably be changed to "Wireshark must be then set
      up..." to avoid the ambiguity.
    
    Make it so (over half a year later, sigh), and change another case where
    "should" is meant in the first sense while we're at it.
    
    Change-Id: I90198d1616619c75802deeeb703ceee0c8bac1bf
    Reviewed-on: https://code.wireshark.org/review/36155
    Reviewed-by: Guy Harris <guy@alum.mit.edu>
    (cherry picked from commit c268e9b0d563cfd248fae611c06e39430e1bad6c)
    Reviewed-on: https://code.wireshark.org/review/36158

commit 3e8163790d
Author: Gerald Combs <gerald@wireshark.org>
Date:   Sun Feb 16 08:58:54 2020 +0000

    [Automatic update for 2020-02-16]
    
    Update manuf, services enterprise numbers, translations, and other items.
    
    Change-Id: I2feb9bb26444e5047db077addad9b05c35582ebb
    Reviewed-on: https://code.wireshark.org/review/36119
    Reviewed-by: Gerald Combs <gerald@wireshark.org>

commit 6b98dc6370
Author: Gerald Combs <gerald@wireshark.org>
Date:   Wed Feb 12 12:07:52 2020 -0800

    WiMax DLMAP: Fix a large loop.
    
    Make sure we advance our offset.
    
    Bug: 16383
    Ping-Bug: 16368
    Change-Id: I4949cb0988601dbe545d0bc22de4d654b4e61204
    Reviewed-on: https://code.wireshark.org/review/36085
    Reviewed-by: Gerald Combs <gerald@wireshark.org>
    Petri-Dish: Gerald Combs <gerald@wireshark.org>
    Reviewed-by: Anders Broman <a.broman58@gmail.com>
    (cherry picked from commit 6dad599a8a1bda8b8e999cc4a7e460140e4ecc0a)
    Reviewed-on: https://code.wireshark.org/review/36094

commit 97cb5e9cb9
Author: Gerald Combs <gerald@wireshark.org>
Date:   Sun Feb 9 08:58:21 2020 +0000

    [Automatic update for 2020-02-09]
    
    Update manuf, services enterprise numbers, translations, and other items.
    
    Change-Id: Ib29ea40d51b569f366ad46ba979f7e9b974df29f
    Reviewed-on: https://code.wireshark.org/review/36063
    Reviewed-by: Gerald Combs <gerald@wireshark.org>

commit 93d6b03a67
Author: Gerald Combs <gerald@wireshark.org>
Date:   Fri Feb 7 11:17:35 2020 -0800

    WiMax DLMAP: Add a length check.
    
    Make sure we have enough data for a CRC.
    
    Bug: 16368
    Change-Id: I03a2532061a5cf5e28cb65c83dd4ab90654d1679
    Reviewed-on: https://code.wireshark.org/review/36051
    Reviewed-by: Gerald Combs <gerald@wireshark.org>

commit 9eb2802176
Author: Gerald Combs <gerald@wireshark.org>
Date:   Sun Feb 2 08:58:28 2020 +0000

    [Automatic update for 2020-02-02]
    
    Update manuf, services enterprise numbers, translations, and other items.
    
    Change-Id: I5c054a84cb1d2b34901306e7079fdebbb5f55c24
    Reviewed-on: https://code.wireshark.org/review/36008
    Reviewed-by: Gerald Combs <gerald@wireshark.org>

commit 093a10ca3c
Author: Guy Harris <guy@alum.mit.edu>
Date:   Fri Jan 31 16:39:37 2020 -0800

    Check for liblua-{version} as well as liblua{version}.
    
    FreeBSD packages install liblua-{version}.
    
    Change-Id: Ib28d2032a13baff9da42d61e3054a8b8e64b5cc9
    Reviewed-on: https://code.wireshark.org/review/35994
    Reviewed-by: Guy Harris <guy@alum.mit.edu>
    (cherry picked from commit 20e9652179221ec4e7399eae2bda2a1fff44cb36)
    Reviewed-on: https://code.wireshark.org/review/35997

commit a7ad54e1df
Author: Guy Harris <guy@alum.mit.edu>
Date:   Mon Jan 27 15:46:24 2020 -0800

    Fix indentation.
    
    Change-Id: Ib80213ecb5c02d64f107706971c646decc601e8d
    Reviewed-on: https://code.wireshark.org/review/35967
    Reviewed-by: Guy Harris <guy@alum.mit.edu>
    (cherry picked from commit 0c112e2e242005437698961d41b6758c22cdbc7b)
    Reviewed-on: https://code.wireshark.org/review/35970

commit c9eed5d79d
Author: Dario Lombardo <lomato@gmail.com>
Date:   Fri Jan 10 15:42:58 2020 +0100

    Fix compilation with gcc-9.
    
    gcc-9 spotted some NULL pointer usages.
    
    Bug: 16319
    Change-Id: I3e4ac57705f1852c43299f5e924fc642a2c56a3a
    Reviewed-on: https://code.wireshark.org/review/35733
    Reviewed-by: Peter Wu <peter@lekensteyn.nl>
    Petri-Dish: Peter Wu <peter@lekensteyn.nl>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@gmail.com>
    (cherry picked from commit 084a887a30b78a3f4f42aa35a15049c251adfcfa)
    Reviewed-on: https://code.wireshark.org/review/35966
    Reviewed-by: Guy Harris <guy@alum.mit.edu>

commit bac736d162
Author: Gerald Combs <gerald@wireshark.org>
Date:   Sun Jan 26 08:57:54 2020 +0000

    [Automatic update for 2020-01-26]
    
    Update manuf, services enterprise numbers, translations, and other items.
    
    Change-Id: I649e5ad3dc0bcde94b0e30d0d7718d9b83f6db96
    Reviewed-on: https://code.wireshark.org/review/35952
    Reviewed-by: Gerald Combs <gerald@wireshark.org>

commit 28dc014dc2
Author: Erwin Rol <erwin@erwinrol.com>
Date:   Sat Jan 11 17:14:44 2020 +0100

    rdm: Remove incorrect dissection of ack overflow data
    
    Ack overflow data was incorrectly dissected causing checksum errors. For now
    just display raw data.
    
    Change-Id: Icdd858bdbeeb4dd40e48c45fc46e5e188d53be69
    Signed-off-by: Erwin Rol <erwin@erwinrol.com>
    Reviewed-on: https://code.wireshark.org/review/35915
    Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
    Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Pascal Quantin <pascal@wireshark.org>
    (cherry picked from commit 4f462bb6e3470ccb09b8da1efd4f133169aef03d)
    Reviewed-on: https://code.wireshark.org/review/35945
    Petri-Dish: Pascal Quantin <pascal@wireshark.org>

commit 80504ef3ca
Author: Erwin Rol <erwin@erwinrol.com>
Date:   Tue Dec 24 10:52:37 2019 +0100

    artnet: Fix ArtPollReply universe calculation
    
    The SubSwitch field holds bit 7-4 of the 15bit port address, but
    it holds it in bit 3-0 so we have to shift it 4 bits instead of
    taking bit 7-4 of the SubSwitch field.
    
    Change-Id: I7841d64749e8a561e4ee928a23a3c46cb5be34cb
    Signed-off-by: Erwin Rol <erwin@erwinrol.com>
    Reviewed-on: https://code.wireshark.org/review/35910
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
    (cherry picked from commit 824fef51aa3efc7a146ea57de90b1a6135614496)
    Reviewed-on: https://code.wireshark.org/review/35948
    Reviewed-by: Pascal Quantin <pascal@wireshark.org>

commit b3935dbb52
Author: João Valverde <joao.valverde@tecnico.ulisboa.pt>
Date:   Thu Jan 23 02:13:40 2020 +0000

    IPv4: Fix display of Fragment Offset field
    
    Bug: 16344
    Change-Id: I0fe0bec606a103e0cb96c6b6da0f98f9b12097b7
    Fixes: v3.1.0rc0-916-g237ec1349f ("IP: Make dissection of ip.frag_offset RFC 791 compliant")
    Reviewed-on: https://code.wireshark.org/review/35918
    Petri-Dish: João Valverde <j@v6e.pt>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@gmail.com>
    Reviewed-on: https://code.wireshark.org/review/35929
    Reviewed-by: João Valverde <j@v6e.pt>

commit 086003c9d6
Author: Pascal Quantin <pascal@wireshark.org>
Date:   Wed Jan 22 11:38:02 2020 +0100

    LTE RRC: fix a memory leak in composite TVB handling
    
    Bug: 16341
    Change-Id: Ib6c020ea3df8b39a02f742f0684fca7db96f1fc3
    Reviewed-on: https://code.wireshark.org/review/35899
    Petri-Dish: Pascal Quantin <pascal@wireshark.org>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Pascal Quantin <pascal@wireshark.org>
    (cherry picked from commit adeeb7f2da801303768ce96e2cacf6a703a69c6f)
    Conflicts:
            epan/dissectors/packet-lte-rrc.c
    Reviewed-on: https://code.wireshark.org/review/35903

commit 3a86df5bbe
Author: Pascal Quantin <pascal@wireshark.org>
Date:   Mon Jan 20 21:38:44 2020 +0100

    ICMP/ICMPv6: fix request/response tracking for checksum 0x0000
    
    Apply the change proposed by Chris Maynard in
    https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16334
    
    Bug: 16334
    Change-Id: I91d79d992c107ca4ddaa17c25c3629424cc240f6
    Reviewed-on: https://code.wireshark.org/review/35878
    Petri-Dish: Pascal Quantin <pascal@wireshark.org>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@gmail.com>
    Reviewed-on: https://code.wireshark.org/review/35884
    Reviewed-by: Pascal Quantin <pascal@wireshark.org>

commit 69c5a2feb9
Author: Gerald Combs <gerald@wireshark.org>
Date:   Sun Jan 19 08:58:04 2020 +0000

    [Automatic update for 2020-01-19]
    
    Update manuf, services enterprise numbers, translations, and other items.
    
    Change-Id: I3c4340d26da0af882a4ed29db47360b5e2538cfa
    Reviewed-on: https://code.wireshark.org/review/35866
    Reviewed-by: Gerald Combs <gerald@wireshark.org>

commit 6a901125d0
Author: Stig Bjørlykke <stig@bjorlykke.org>
Date:   Sat Jan 18 20:03:02 2020 +0100

    Qt: Support ampersand in profile name
    
    An ampersand in the menu item text is used as shortcut, so use "&&" to
    get a real ampersand.
    
    Change-Id: Iea1e10f23db582cded83182778be815cfeece7bd
    Reviewed-on: https://code.wireshark.org/review/35861
    Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@alum.mit.edu>
    Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
    (cherry picked from commit f8e92a21fb2e981d7bb5e019cbf781ec43031665)
    Reviewed-on: https://code.wireshark.org/review/35862

commit c589a695b3
Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
Date:   Wed Jan 15 22:14:16 2020 +0100

    lapdm(.h): fix duplicate include guard (found by lgtm.com)
    
    Change-Id: I3cf4d30f5e91b6182c64b7f016e03d63aa1066d0
    Reviewed-on: https://code.wireshark.org/review/35829
    Petri-Dish: Guy Harris <guy@alum.mit.edu>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@alum.mit.edu>
    (cherry picked from commit 3e072f1bc9d89c070b1e8a81e8fffcd11fa19cbd)
    Reviewed-on: https://code.wireshark.org/review/35834

commit 8dcd5dff7f
Author: Gerald Combs <gerald@wireshark.org>
Date:   Wed Jan 15 12:38:37 2020 -0800

    2.6.14 → 2.6.15.
    
    Change-Id: I05dec99b3454f2100b562fe65ecfbd235e0cdd0f
    Reviewed-on: https://code.wireshark.org/review/35827
    Reviewed-by: Gerald Combs <gerald@wireshark.org>