path: root/ChangeLog

commit 846db80ce5
Author: Gerald Combs <gerald@wireshark.org>
Date:   Tue Jan 8 09:50:49 2019 -0800

    Update the release notes for 2.4.12.
    
    Change-Id: I41d1fae661adaa62727f788d0fa3fbf311e26633
    Reviewed-on: https://code.wireshark.org/review/31451
    Reviewed-by: Gerald Combs <gerald@wireshark.org>

commit cd09cb5cfb
Author: Gerald Combs <gerald@wireshark.org>
Date:   Mon Jan 7 14:41:29 2019 -0800

    epan: Add a boundary check to get_t61_string.
    
    Add a boundary check to make sure we don't go past the end of "ptr".
    
    Bug: 15373
    Change-Id: I85394e8e6e477b47919362af146051cc8911254b
    Reviewed-on: https://code.wireshark.org/review/31440
    Reviewed-by: Gerald Combs <gerald@wireshark.org>

commit 464786092c
Author: Gerald Combs <gerald@wireshark.org>
Date:   Sun Jan 6 08:44:04 2019 +0000

    [Automatic update for 2019-01-06]
    
    Update manuf, services enterprise numbers, translations, and other items.
    
    Change-Id: I9566efd494e694d7fc9f45ca1353bd65a9f2677d
    Reviewed-on: https://code.wireshark.org/review/31404
    Reviewed-by: Gerald Combs <gerald@wireshark.org>

commit a8304056ca
Author: Dario Lombardo <lomato@gmail.com>
Date:   Sat Jan 5 23:22:50 2019 +0100

    doc: remove wrong trailing slash.
    
    Change-Id: If6bcf2ce9754453cfff434dde67b682761b37231
    Reviewed-on: https://code.wireshark.org/review/31394
    Petri-Dish: Dario Lombardo <lomato@gmail.com>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@alum.mit.edu>
    (cherry picked from commit ec606cc59e943d27a71b07e5ee832acdf789c811)
    Reviewed-on: https://code.wireshark.org/review/31396

commit f85c9f0a1d
Author: Guy Harris <guy@alum.mit.edu>
Date:   Sat Jan 5 13:35:08 2019 -0800

    Remove comment whose meaning is unclear at best.
    
    What is is it saying we shouldn't be doing?
    
    Change-Id: Iad26687f3f3f482af09760255fef7189ed71a3ae
    Reviewed-on: https://code.wireshark.org/review/31391
    Reviewed-by: Guy Harris <guy@alum.mit.edu>
    (backported from commit 10a7993bae60a66f64595de28ad0c764484a641a)
    Reviewed-on: https://code.wireshark.org/review/31393

commit 0ce320b733
Author: Guy Harris <guy@alum.mit.edu>
Date:   Thu Jan 3 12:21:19 2019 -0800

    Avoid definition collisions for INVALID_SOCKET.
    
    Newer versions of libpcap define it (due to the somewhat infelicitous
    API for "active mode" remote capture, which returns a socket); don't
    define it ourselves if it's already defined.
    
    Change-Id: I620576620fd2708ebd503da696e17b472bc20472
    Reviewed-on: https://code.wireshark.org/review/31344
    Reviewed-by: Guy Harris <guy@alum.mit.edu>
    (cherry picked from commit 20ad0ffbaf1d49bf3da50a62c0bed93f765b9e31)
    Reviewed-on: https://code.wireshark.org/review/31346

commit 5f7ba271ec
Author: Peter Wu <peter@lekensteyn.nl>
Date:   Mon Dec 31 14:07:32 2018 +0100

    wsutil: fix crash due to corruption of the "small_buffers" array
    
    Gracefully handle repeated calls of ws_buffer_free on the same buffer to
    avoid strange crashes in other new users that allocate a "small" buffer.
    
    The first call to ws_buffer_free would store data pointer in the
    'small_buffers' array for reuse and set the pointer to NULL. Result:
    
        (gdb) p cfile.rec.options_buf
        $2 = {
          data = 0x0,
          allocated = 2048,     // Oops, not modified!
          start = 0,
          first_free = 0
        }
    
    All users of Buffer (including ws_buffer_free) however asssume that
    'allocated' reflects the actual size of 'data'. If this is not the case
    (if ws_buffer_free is called again), then a data pointer (NULL!) will be
    stored and the next ws_buffer_init request for a "small buffer" will
    result in unexpected behavior (including crashes).
    
    Fix the issue by clearing the 'allocated' field as well. Add assertions
    to catch such issues earlier rather than crashing at random users of
    these buffers (such as frame_tvbuff).
    
    Bug: 15263
    Change-Id: I0b491c3fccac8c6fddd43779629343d721638ca9
    Reviewed-on: https://code.wireshark.org/review/31278
    Petri-Dish: Peter Wu <peter@lekensteyn.nl>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@gmail.com>
    (cherry picked from commit ae2a75233cec4e1286964963e6ac4ba936322cb1)
    Reviewed-on: https://code.wireshark.org/review/31302
    Reviewed-by: Peter Wu <peter@lekensteyn.nl>

commit cf1075662f
Author: Stig Bjørlykke <stig@bjorlykke.org>
Date:   Tue Jan 1 12:57:07 2019 +0100

    Happy New Year 2019!
    
    Change-Id: Ic140aafdb32e649e88bf3f00bda3cec9404e555a
    Reviewed-on: https://code.wireshark.org/review/31284
    Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
    (cherry picked from commit a05ba5be694635211486a2e1f131b5ae2ffadc51)
    Reviewed-on: https://code.wireshark.org/review/31285
    (cherry picked from commit c4e134bc537dedbb16293c37f367a7082028fe37)
    Reviewed-on: https://code.wireshark.org/review/31286

commit b7775ad502
Author: Peter Wu <peter@lekensteyn.nl>
Date:   Wed Dec 19 15:52:23 2018 +0100

    Revert "Add routines to load Lua programs that assume the path is UTF-8 on Windows."
    
    This reverts commit 5953756305388724545f0df46d286be2f02c048a.
    
    The public API should not be polluted with Windows-specific hacks. As we
    already override dofile/loadfile, those should be fixed instead.
    
    Ping-Bug: 15118
    Change-Id: Ia9d5e64e8ef14032f982f695ffd4cac59067bb17
    Reviewed-on: https://code.wireshark.org/review/31134
    Reviewed-by: Peter Wu <peter@lekensteyn.nl>
    Petri-Dish: Peter Wu <peter@lekensteyn.nl>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@alum.mit.edu>
    Reviewed-by: Anders Broman <a.broman58@gmail.com>
    (cherry picked from commit 07cfef9e5a9424c22281df1a7dda4e283c0b7ddc)
    Reviewed-on: https://code.wireshark.org/review/31263

commit 44f7182057
Author: Gerald Combs <gerald.combs@riverbed.com>
Date:   Sun Dec 30 08:43:38 2018 +0000

    [Automatic update for 2018-12-30]
    
    Update manuf, services enterprise numbers, translations, and other items.
    
    Change-Id: I4f88d120aa3d104b3dcbf60f511f7cb56df9191d
    Reviewed-on: https://code.wireshark.org/review/31256
    Reviewed-by: Gerald Combs <gerald@wireshark.org>

commit 356e238f8c
Author: Guy Harris <guy@alum.mit.edu>
Date:   Fri Dec 28 19:26:03 2018 -0800

    Small cleanups.
    
    Get rid of an extra blank line in a comment.
    
    Change another comment to refer to "error packets", as we do elsewhere.
    
    Fix indentation.
    
    Change-Id: I4d81b8856ea876f20914352f962b1df0e115404c
    Reviewed-on: https://code.wireshark.org/review/31241
    Reviewed-by: Guy Harris <guy@alum.mit.edu>
    (cherry picked from commit d68a8a36054a26e520647a9402e9e405efd8cf3e)
    Reviewed-on: https://code.wireshark.org/review/31250

commit e2e4e28abc
Author: Guy Harris <guy@alum.mit.edu>
Date:   Sat Dec 29 11:25:19 2018 -0800

    Fix indentation.
    
    Change-Id: I6cc3373d043e6a8203a5f70eb03f03bb6cd8a6d9
    Reviewed-on: https://code.wireshark.org/review/31246
    Reviewed-by: Guy Harris <guy@alum.mit.edu>
    (cherry picked from commit 1fe5921b7bd942022d2a2f5c0a27bb0d479ae6bd)
    Reviewed-on: https://code.wireshark.org/review/31248

commit 6343cbf5e2
Author: Pascal Quantin <pascal.quantin@gmail.com>
Date:   Fri Dec 28 10:38:44 2018 +0100

    GTPv2: fix dissection of APN IE
    
    The total maximum length of the APN with Network Identifier and Operator
    Identifier is 100 bytes.
    
    Bug: 15383
    Change-Id: Ib74eac1f18f2235c2788e58370f50eeb9a678357
    Reviewed-on: https://code.wireshark.org/review/31225
    Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
    Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Michael Mann <mmann78@netscape.net>
    (cherry picked from commit 6180d0fdaa5e27de9fcddba7bd9d47adc0c71a42)
    Reviewed-on: https://code.wireshark.org/review/31229

commit b5b02f2a9b
Author: Jaap Keuter <jaap.keuter@xs4all.nl>
Date:   Mon Dec 24 23:15:26 2018 +0100

    ISAKMP: Fix a crash when no decryption data block is there
    
    Don't try to (re)set parameters in a struct when its pointer
    points to NULL.
    
    Bug: 15374
    Change-Id: I953e82795990fde5fce2ad6d955781b372a9e405
    Signed-off-by: Jaap Keuter <jaap.keuter@xs4all.nl>
    Reviewed-on: https://code.wireshark.org/review/31189
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Michael Mann <mmann78@netscape.net>
    (cherry picked from commit c9cfae7fecd4bc21b8b4f48328d08e104d47dd52)
    Reviewed-on: https://code.wireshark.org/review/31220
    Petri-Dish: Michael Mann <mmann78@netscape.net>

commit e06172dfe0
Author: Gerald Combs <gerald.combs@riverbed.com>
Date:   Sun Dec 23 08:41:13 2018 +0000

    [Automatic update for 2018-12-23]
    
    Update manuf, services enterprise numbers, translations, and other items.
    
    Change-Id: Ie03ab83d8fd439523288496e4ea3db3f9b1062f1
    Reviewed-on: https://code.wireshark.org/review/31177
    Reviewed-by: Gerald Combs <gerald@wireshark.org>

commit de09a49c7c
Author: Anders Broman <anders.broman@ericsson.com>
Date:   Thu Dec 20 11:04:54 2018 +0100

    ANSI MAP: borderCellAccess parameter coded as tag 50 but should be 58.
    
    Bug: 15372
    Change-Id: I11886649dbd390655505d93e4378fe38dff8fb64
    Reviewed-on: https://code.wireshark.org/review/31144
    Petri-Dish: Anders Broman <a.broman58@gmail.com>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@gmail.com>
    (cherry picked from commit 31e38c312b4157c0d93c80db0ae3b712271d3c17)
    Reviewed-on: https://code.wireshark.org/review/31146

commit 516be16a35
Author: Gerald Combs <gerald@wireshark.org>
Date:   Wed Dec 19 09:20:02 2018 -0800

    Qt: Open our preference dialogs via "clicked" signals.
    
    In ModulePreferencesScrollArea we create QPushButtons that open modal
    UAT and file dialogs. Open them via the "clicked" signal instead of
    the "pressed" signal. "clicked" is a general activation signal that
    fires after the mouse button has been clicked+released or a keyboard
    event. "pressed" fires before "released" and can be problematic in
    some cases.
    
    Bug: 15366
    Change-Id: Icb353d86ae0a4b4b97e5f63df791ec562070756d
    Reviewed-on: https://code.wireshark.org/review/31125
    Petri-Dish: Gerald Combs <gerald@wireshark.org>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Gerald Combs <gerald@wireshark.org>

commit a2970e017c
Author: Gerald Combs <gerald@wireshark.org>
Date:   Tue Dec 18 08:30:27 2018 -0800

    Lua: Fix compilation with Lua 5.1.
    
    Change-Id: Idd4aa36ee95e985560867094d423128e51aacfb1
    Reviewed-on: https://code.wireshark.org/review/31095
    Petri-Dish: Gerald Combs <gerald@wireshark.org>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Gerald Combs <gerald@wireshark.org>
    (cherry picked from commit 060811713fa63e04cbed95af4e7720794a1bf3a6)
    Reviewed-on: https://code.wireshark.org/review/31118
    Reviewed-by: Guy Harris <guy@alum.mit.edu>

commit a7ec649385
Author: Gerald Combs <gerald@wireshark.org>
Date:   Wed Dec 5 09:59:23 2018 -0800

    Fix some spelling errors found by Lintian.
    
    Change-Id: If6fc3aab7ad4fc634567121f7b9541bc6f6c5766
    Reviewed-on: https://code.wireshark.org/review/30926
    Reviewed-by: Gerald Combs <gerald@wireshark.org>
    Petri-Dish: Gerald Combs <gerald@wireshark.org>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@gmail.com>
    (backported from commit 8c22c5badecf16c2a7881db28254ba22c7cb3d1c)
    Reviewed-on: https://code.wireshark.org/review/31114
    Reviewed-by: Guy Harris <guy@alum.mit.edu>

commit dcab121f39
Author: Guy Harris <guy@alum.mit.edu>
Date:   Tue Dec 18 23:13:02 2018 -0800

    Don't free something before freeing some of its contents.
    
    Free the wspstat_t only after freeing the hash table contained in it.
    
    Change-Id: I2aa31d74b6d0f86e5404a9b614fee8a3f6708938
    Ping-Bug: 15365
    Reviewed-on: https://code.wireshark.org/review/31108
    Reviewed-by: Guy Harris <guy@alum.mit.edu>
    (cherry picked from commit 0fc7f3781351c23cf05bdaafc1dd3dc6f9a08a2c)
    Reviewed-on: https://code.wireshark.org/review/31110

commit b3f7c408e3
Author: Guy Harris <guy@alum.mit.edu>
Date:   Tue Dec 18 22:58:24 2018 -0800

    Clean up exp_pdu_open() API.
    
    It really shouldn't free the comment passed to it, as the caller
    allocated it, and knows how to free it if necessary; it might not even
    have been allocated.
    
    Make the comment argument a "const char *" to 1) allow passing string
    constants etc. and 2) to catch any attempts to free it in
    exp_pdu_open().
    
    Make the callers free it after exp_pdu_open() returns.
    
    (Alternatively, we could have exp_pdu_open() take the file name argument
    and generate the comment itself, so that all code paths generate the
    same comment.)
    
    Change-Id: I6e6924b05565761b641a6c3b4d9a2e97f4264e1b
    Ping-Bug: 15365
    Reviewed-on: https://code.wireshark.org/review/31105
    Reviewed-by: Guy Harris <guy@alum.mit.edu>
    (cherry picked from commit 05b43fc5af805dde1bdbf74dd1448690f3a10705)
    Reviewed-on: https://code.wireshark.org/review/31107

commit 9035f52ca2
Author: Guy Harris <guy@alum.mit.edu>
Date:   Tue Dec 18 22:03:35 2018 -0800

    Always set *dfp to NULL on an error return from dfilter_compile().
    
    All other error-return code paths set *dfp to NULL; make this one do so
    as well.
    
    Change-Id: I4015c1d53bdbac99cdeda158d7d01c8da7bf2562
    Reviewed-on: https://code.wireshark.org/review/31102
    Reviewed-by: Guy Harris <guy@alum.mit.edu>
    (cherry picked from commit 9d8b0a9cd0afca4c9bfebefd7154185c5c93afdb)
    Reviewed-on: https://code.wireshark.org/review/31104

commit 7c3eae7737
Author: Guy Harris <guy@alum.mit.edu>
Date:   Tue Dec 18 14:03:07 2018 -0800

    Don't assume the filter will be non-null.
    
    There's no guarantee that sp->filter is non-null; if it's null, that
    means there's no filter.
    
    Bug: 15369
    Change-Id: I2a61db2e134aa70d30c2265b63aabf99c35e362e
    Reviewed-on: https://code.wireshark.org/review/31096
    Reviewed-by: Guy Harris <guy@alum.mit.edu>
    (cherry picked from commit 053f47fdefc9bcb36983129b77b7e1754d4304bb)
    Reviewed-on: https://code.wireshark.org/review/31098

commit 259b5dea2b
Author: Guy Harris <guy@alum.mit.edu>
Date:   Tue Dec 18 00:49:21 2018 -0800

    Treat the strings for simple dialogs as UTF-8 on Windows.
    
    On Windows, filename strings inside Wireshark are UTF-8 strings, so
    error messages containing file names are UTF-8 strings.  Convert from
    UTF-8, not from the local code page.
    
    Bug: 15367
    Change-Id: I52f3de2606ec6a592e7cb82b1a9aaeeef8acecef
    Reviewed-on: https://code.wireshark.org/review/31090
    Petri-Dish: Guy Harris <guy@alum.mit.edu>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@alum.mit.edu>
    (cherry picked from commit ae83101dd5643c3852ca67ffb331cd8dbd20c727)
    Reviewed-on: https://code.wireshark.org/review/31092

commit 4594f47e3b
Author: Guy Harris <guy@alum.mit.edu>
Date:   Mon Dec 17 10:57:20 2018 -0800

    Add routines to load Lua programs that assume the path is UTF-8 on Windows.
    
    Add ws_dofile() and ws_loadfile(), which are like the substitute
    dofile() and loadfile() we provide, but that, on Windows, take a UTF-8
    path rather than a path in the local code page.
    
    Use that to load console.lua.
    
    This means we can load console.lua on Windows even if the full path to
    it includes non-ASCII characters.
    
    Bug: 15118
    Change-Id: Iaa00639563fe53a34e1e24e42022f3886a38e7c5
    Reviewed-on: https://code.wireshark.org/review/31075
    Petri-Dish: Guy Harris <guy@alum.mit.edu>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@alum.mit.edu>
    (cherry picked from commit 5953756305388724545f0df46d286be2f02c048a)
    Reviewed-on: https://code.wireshark.org/review/31078

commit f4fd3c95a7
Author: Pascal Quantin <pascal.quantin@gmail.com>
Date:   Wed Dec 12 21:35:52 2018 +0100

    GSM A: detect buffer overrun when decoding MS Classmark 3 IE
    
    Change-Id: I12d372afd8a50b9a04f92c53077e79116db6c255
    Reviewed-on: https://code.wireshark.org/review/31024
    Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
    (cherry picked from commit 144d481c2035a8d3d6d0b915a26a076a7ddcc371)
    Reviewed-on: https://code.wireshark.org/review/31071
    Reviewed-by: Anders Broman <a.broman58@gmail.com>

commit f7c17a34d3
Author: Gerald Combs <gerald.combs@riverbed.com>
Date:   Sun Dec 16 08:41:16 2018 +0000

    [Automatic update for 2018-12-16]
    
    Update manuf, services enterprise numbers, translations, and other items.
    
    Change-Id: I57a010c16a8a407563487e539a9f24882dd50d6e
    Reviewed-on: https://code.wireshark.org/review/31062
    Reviewed-by: Gerald Combs <gerald@wireshark.org>

commit 527aaf060b
Author: Anders Broman <anders.broman@ericsson.com>
Date:   Tue Dec 11 09:59:38 2018 +0100

    ASNI MAP: AnalogRedirectRecord is OPTIONAL in QualificationRequest
    
    Bug: 15350
    Change-Id: Ibe7f085daa2981168b3c5201256d674feb4cb7e5
    Reviewed-on: https://code.wireshark.org/review/31004
    Petri-Dish: Anders Broman <a.broman58@gmail.com>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@gmail.com>
    (cherry picked from commit 9035a131e5ba9e8b653a0e3a95b79569905a50f8)
    Reviewed-on: https://code.wireshark.org/review/31005

commit bf9272a92f
Author: Stig Bjørlykke <stig@bjorlykke.org>
Date:   Sun Dec 9 21:54:18 2018 +0100

    p_mul: Detect Data PDU sequence number 0
    
    Data PDU sequence number 0 is illegal, add an expert info for this.
    Don't include this packet in SEQ/ACK analysis.
    
    Bug: 15337
    Change-Id: I476088531e8a3605393ee1dedf1e8b159dac342b
    Reviewed-on: https://code.wireshark.org/review/30980
    Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@gmail.com>
    (cherry picked from commit 3cccd4ec5b922e79afd134db4f0c9acb10bf7202)
    Reviewed-on: https://code.wireshark.org/review/30987
    Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>

commit c1a9eefc33
Author: Michael Mann <mmann78@netscape.net>
Date:   Sun Dec 9 09:27:31 2018 -0500

    Multicast Statistics Dialog: Clear list when redrawing
    
    The multicast statistics tap provides a continually updating list which the draw function just has to iterate through.
    
    Bug: 15271
    Change-Id: I270e7ca9460ec9568756b6c8d98f4f17653c8cad
    Reviewed-on: https://code.wireshark.org/review/30976
    Petri-Dish: Michael Mann <mmann78@netscape.net>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Michael Mann <mmann78@netscape.net>
    (cherry picked from commit 96c52c1a0f7585fc0130ce26f66c340589965ff9)
    Reviewed-on: https://code.wireshark.org/review/30982
    Reviewed-by: Anders Broman <a.broman58@gmail.com>

commit ab4ff21bdd
Author: Gerald Combs <gerald.combs@riverbed.com>
Date:   Sun Dec 9 08:39:32 2018 +0000

    [Automatic update for 2018-12-09]
    
    Update manuf, services enterprise numbers, translations, and other items.
    
    Change-Id: Ia11b927bdbb84e4ee4d6db55015baa8fdbc8eb30
    Reviewed-on: https://code.wireshark.org/review/30975
    Reviewed-by: Gerald Combs <gerald@wireshark.org>

commit 102cf9d8f6
Author: Guy Harris <guy@alum.mit.edu>
Date:   Thu Dec 6 08:36:43 2018 -0800

    Update comments, get rid of IMPORT_MAX_PACKET.
    
    Get rid of the IMPORT_MAX_PACKET #define; just directly use
    WTAP_MAX_PACKET_SIZE_STANDARD, to match what text2pcap.c does.
    
    Update comments in text2pcap.c and ui/text_import.c to say the maximum
    packet size is WTAP_MAX_PACKET_SIZE_STANDARD.
    
    Change-Id: I34118f76426d1416fccf43b2a356ad8d200de19b
    Ping-Bug: 15292
    Reviewed-on: https://code.wireshark.org/review/30945
    Reviewed-by: Guy Harris <guy@alum.mit.edu>
    (backported from commit 0946518780bc260d0668485b3f6f7e1d14325a7b)
    Reviewed-on: https://code.wireshark.org/review/30947
    Petri-Dish: Guy Harris <guy@alum.mit.edu>
    Tested-by: Petri Dish Buildbot

commit fdb2dae5d8
Author: Jaap Keuter <jaap.keuter@xs4all.nl>
Date:   Thu Dec 6 13:49:04 2018 +0100

    Qt: Fix tooltip on import size
    
    Import size is increased to 256kiB, but tooltip says 64kB.
    Adjust text according to limit set bt code.
    
    Change-Id: I586248fd25a96e4ffe0936babc90b4150c14f118
    Ping-Bug: 15292
    Signed-off-by: Jaap Keuter <jaap.keuter@xs4all.nl>
    Reviewed-on: https://code.wireshark.org/review/30940
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@gmail.com>
    (cherry picked from commit aadf8727178c9e0aa3ecc638d60bc1878d431f60)
    Reviewed-on: https://code.wireshark.org/review/30944
    Reviewed-by: Guy Harris <guy@alum.mit.edu>

commit 1c66174ec7
Author: Martin Kaiser <wireshark@kaiser.cx>
Date:   Sat Mar 3 19:49:22 2018 +0100

    enip: use wmem for copied addresses
    
    When we copy an address from pinfo into connInfo->O2T.ipaddress, a
    shallow copy is not sufficient. connInfo->O2T.ipaddress is kept across
    packets whereas pinfo is valid only for the current packet.
    
    Use wmem with file scope for the copied address. This fixes a
    use-after-free error when we access the address in a subsequent packet.
    
    Bug: 14470
    Change-Id: I8b74037020189485485a506af6510cb45828e3c4
    Reviewed-on: https://code.wireshark.org/review/26248
    Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
    Petri-Dish: Martin Kaiser <wireshark@kaiser.cx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@gmail.com>
    (cherry picked from commit 177962a5b4a05759b40fb6fc07a4a6eec306a9bf)
    Reviewed-on: https://code.wireshark.org/review/30941
    Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
    Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>

commit f898da5451
Author: Jaap Keuter <jaap.keuter@xs4all.nl>
Date:   Wed Dec 5 16:08:06 2018 +0100

    text2pcap: extend snap length
    
    The snaplength as saved in the capture file is set to the original
    PCAP file length of 65535. In reality the package size can grow to
    256kiB. Make use of the correct constant when writing the PCAP file.
    
    Bug: 15292
    Change-Id: Ib7710e4151cdc712f3344c1436252f9b3bfb556c
    Signed-off-by: Jaap Keuter <jaap.keuter@xs4all.nl>
    Reviewed-on: https://code.wireshark.org/review/30923
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@alum.mit.edu>
    (cherry picked from commit b63e2d7a950a30ac8791caa41b704b4b442ee451)
    Reviewed-on: https://code.wireshark.org/review/30928
    (cherry picked from commit 7b019ff8028ea0b083bac090e9a80272677966d6)
    Reviewed-on: https://code.wireshark.org/review/30929

commit ce9325daa9
Author: Christophe GUERBER <christophe.guerber@gmail.com>
Date:   Sun Dec 2 01:21:03 2018 +0100

    Fixes IMF dissector
    
    When no content is provided, creating the tree with empty content leads
    to malformed IMF.
    
    Ping-Bug: 15090
    Change-Id: Idf521c26f69638a94300792e50dba29645a45a68
    Reviewed-on: https://code.wireshark.org/review/30874
    Petri-Dish: Michael Mann <mmann78@netscape.net>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Michael Mann <mmann78@netscape.net>
    (cherry picked from commit bf88197d94bf6045cf789a1aa332a8c88755556f)
    Reviewed-on: https://code.wireshark.org/review/30888
    Reviewed-by: Anders Broman <a.broman58@gmail.com>

commit b675563838
Author: Guy Harris <guy@alum.mit.edu>
Date:   Sun Dec 2 01:02:28 2018 -0800

    Don't include <wsutil/wspcap.h> if we're not building with libpcap.
    
    We don't need it and, if there *is* no pcap.h header, because the pcap
    headers aren't installed, it won't compile.
    
    Bug: 15317
    Change-Id: Ie2a107f6117aad8f87943cd72269211f13b71142
    Reviewed-on: https://code.wireshark.org/review/30883
    Reviewed-by: Guy Harris <guy@alum.mit.edu>
    (cherry picked from commit 98d4b434fe4a7b162fa38eb31478ff086d32c040)
    Reviewed-on: https://code.wireshark.org/review/30885

commit cbf3304058
Author: Gerald Combs <gerald.combs@riverbed.com>
Date:   Sun Dec 2 08:37:09 2018 +0000

    [Automatic update for 2018-12-02]
    
    Update manuf, services enterprise numbers, translations, and other items.
    
    Change-Id: Id0e8ebd9e4992761be8941ebe377747c624ed83b
    Reviewed-on: https://code.wireshark.org/review/30882
    Reviewed-by: Gerald Combs <gerald@wireshark.org>

commit 0b30fc3dff
Author: Gerald Combs <gerald@wireshark.org>
Date:   Wed Nov 28 12:46:05 2018 -0800

    2.4.11 → 2.4.12.
    
    Change-Id: I370af81902185295a911725394bfebefee3f5772
    Reviewed-on: https://code.wireshark.org/review/30828
    Reviewed-by: Gerald Combs <gerald@wireshark.org>