aboutsummaryrefslogtreecommitdiffstats
path: root/fileset.c
Commit message (Collapse)AuthorAgeFilesLines
* Replace g_strdup_printf() with ws_strdup_printf()João Valverde2021-12-191-1/+1
| | | | Use macros from inttypes.h.
* Replace g_assert() with ws_assert()João Valverde2021-06-191-2/+3
|
* Detect and replace bad allocation patternsMoshe Kaplan2020-12-221-1/+1
| | | | | | | | | | | | | | | Adds a pre-commit hook for detecting and replacing occurrences of `g_malloc()` and `wmem_alloc()` with `g_new()` and `wmem_new()`, to improve the readability of Wireshark's code, and occurrences of `g_malloc(sizeof(struct myobj) * foo)` with `g_new(struct myobj, foo)` to prevent integer overflows Also fixes all existing occurrences across the codebase.
* HTTPS (almost) everywhere.Guy Harris2019-07-261-1/+1
| | | | | | | | | | Change all wireshark.org URLs to use https. Fix some broken links while we're at it. Change-Id: I161bf8eeca43b8027605acea666032da86f5ea1c Reviewed-on: https://code.wireshark.org/review/34089 Reviewed-by: Guy Harris <guy@alum.mit.edu>
* replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later.Dario Lombardo2018-02-081-1/+1
| | | | | | | | | | The first is deprecated, as per https://spdx.org/licenses/. Change-Id: I8e21e1d32d09b8b94b93a2dc9fbdde5ffeba6bed Reviewed-on: https://code.wireshark.org/review/25661 Petri-Dish: Anders Broman <a.broman58@gmail.com> Petri-Dish: Dario Lombardo <lomato@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
* Have the frame_tvbuff.c routines not use the global cfile.Guy Harris2017-12-081-1/+0
| | | | | | | | | | | | | | Have the routines that create them take a pointer to a struct packet_provider_data, store that in the tvbuff data, and use it to get the wtap from which packets are being read. While we're at it, don't include globals.h in any header files, and include it in source files iff the source file actually uses cfile. Add whatever includes that requires. Change-Id: I9f1ee391f951dc427ff62c80f67aa4877a37c229 Reviewed-on: https://code.wireshark.org/review/24733 Reviewed-by: Guy Harris <guy@alum.mit.edu>
* Convert the file set dialog treewidget to a treeview+model.Gerald Combs2017-12-051-5/+8
| | | | | | | | | | | | Add a FilesetEntryModel and use it in FileSetDialog. This should be faster than using a QTreeWidget. Move dialog updates and date calculations out of the "add file" loop. Bug: 11280 Bug: 14242 Change-Id: I702cef4fe91e739695fe805dc5e496bf3db411f1 Reviewed-on: https://code.wireshark.org/review/24708 Reviewed-by: Gerald Combs <gerald@wireshark.org>
* Start using SPDX license identifiers.Gerald Combs2017-11-091-13/+1
| | | | | | | | | | | | | | | | | | | | | | | A while back Graham pointed out the SPDX project (spdx.org), which is working on standardizing license specifications: https://www.wireshark.org/lists/wireshark-dev/201509/msg00119.html Appendix V of the specification describes a short identifier (SPDX-License-Identifier) that you can use in place of boilerplate in your source files: https://spdx.org/spdx-specification-21-web-version#h.twlc0ztnng3b Start the conversion process with our top-level C and C++ files. Change-Id: Iba1d835776714deb6285e2181e8ca17f95221878 Reviewed-on: https://code.wireshark.org/review/24302 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Reviewed-by: Balint Reczey <balint@balintreczey.hu> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
* Clean up conditional code for getting creation time.Guy Harris2016-10-221-26/+19
| | | | | | | | | | Define a macro to get the creation time from a stat structure, or to return 0 if the creation time is unavailable, and use that in both places where we fetch the creation time. Change-Id: I15354f2d52a40cb1227f30ae274120575eec2055 Reviewed-on: https://code.wireshark.org/review/18387 Reviewed-by: Guy Harris <guy@alum.mit.edu>
* On UN*X, st_ctime is the last status change time, not the creation time.Guy Harris2016-10-221-0/+24
| | | | | | | | | | | | | | | That's the time the file's inode last changed, so size changes, permission changes, etc. affect it. It's *not* the time the file was created; most UN*Xes don't provide that. Newer versions of FreeBSD, NetBSD, OpenBSD, and macOS do, but other UN*Xes don't appear to. On Windows, at least according to Microsoft's documentation, st_ctime *is* the creation time. Hopefully that's not the result of confusion on the part of somebody at Microsoft. Change-Id: I20743703f6ef66e40dff9004dc91bed46af6fad0 Reviewed-on: https://code.wireshark.org/review/18378 Reviewed-by: Guy Harris <guy@alum.mit.edu>
* Fix memleaks related to get_dirnamePeter Wu2016-02-041-2/+2
| | | | | | | | | | | | | | | get_dirname may return NULL instead of the original string, so avoid patterns like get_dirname(strdup(x)). Writing to cf_path.toUtf8().data() is fine btw, toUtf8() returns new memory. This fixes two memleak reported by LeakSanitizer via fileset_add_dir and MainWindow::captureFileReadFinished (both via cf_callback_invoke). Change-Id: I0f1528763e77e1f55b54b6674c890a9d02302ee8 Reviewed-on: https://code.wireshark.org/review/13691 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
* Fix a lot of typos and misspellingsmoshekaplan2016-01-081-2/+2
| | | | | | | | | Change-Id: I8512cfa1d424f82a873a0e0e1d22c7b075fdd7f3 Reviewed-on: https://code.wireshark.org/review/13069 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
* Clean up includes of unistd.h, fcntl.h, and sys/stat.h.Guy Harris2015-11-071-12/+0
| | | | | | | | | | | | | | | Have wsutil/file_util.h include them on UN*X, just as it includes io.h on Windows, so we can have a rule of "if you do file operations, include <wsutil/file_util.h> and use the routines in it". Remove includes of unistd.h, fcntl.h, and sys/stat.h that aren't necessary (whether because of the addition of them to wsutil/file_util.h or because they weren't needed in the first place). Change-Id: Ie241dd74deff284e39a5f690a297dbb6e1dc485f Reviewed-on: https://code.wireshark.org/review/11619 Petri-Dish: Guy Harris <guy@alum.mit.edu> Reviewed-by: Guy Harris <guy@alum.mit.edu>
* We use GLib's directory-reading routines, so we don't need <dire[cn]t.h>.Guy Harris2015-02-141-4/+0
| | | | | | | | Change-Id: Id86e5d6d0ab24adb1bfff0688f33a40f2fdaed8d Reviewed-on: https://code.wireshark.org/review/7108 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Guy Harris <guy@alum.mit.edu>
* Don't use ctype.h routines.Guy Harris2014-10-171-2/+1
| | | | | | | | | That avoids locale dependency and handles possibly-signed chars(which we weren't always doing before). Change-Id: I89e50678abb8c3e535081c92ca25bc1bab672c68 Reviewed-on: https://code.wireshark.org/review/4798 Reviewed-by: Guy Harris <guy@alum.mit.edu>
* Add editor modelines; Adjust whitespace as needed.Bill Meier2014-10-121-0/+13
| | | | | | Change-Id: I4da7b335d905dbca10bbce03aa88e1cdeeb1f8ad Reviewed-on: https://code.wireshark.org/review/4626 Reviewed-by: Bill Meier <wmeier@newsguy.com>
* Modify includes of config.h so that out-of-tree builds, i.e. CMakeGraham Bloice2014-08-241-1/+1
| | | | | | | | | | | don't pick up the in-tree copy. Change-Id: I7ec473876cdba1a025c52362d7f6adc62d24ce71 Reviewed-on: https://code.wireshark.org/review/3798 Petri-Dish: Graham Bloice <graham.bloice@trihedral.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Roland Knall <rknall@gmail.com> Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>
* Remove all $Id$ from top of fileAlexis La Goutte2014-03-041-2/+0
| | | | | | | | | | (Using sed : sed -i '/^ \* \$Id\$/,+1 d') Fix manually some typo (in export_object_dicom.c and crc16-plain.c) Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8 Reviewed-on: https://code.wireshark.org/review/497 Reviewed-by: Anders Broman <a.broman58@gmail.com>
* Move the epan/filesystem.c routines to wsutil; they're not specific toGuy Harris2013-11-171-1/+1
| | | | | | | packet dissection, they're specific to the entire Wireshark suite of programs. svn path=/trunk/; revision=53377
* g_strcmp0 first occures in GLIB 2.16 define it localy if it does not existAnders Broman2012-10-221-0/+1
| | | | | | to make builds on Fedora 8 with GTK 2.12 work. svn path=/trunk/; revision=45707
* Implement file sets.Gerald Combs2012-10-011-1/+1
| | | | | | | | | | Replace the original file set code with a UI form. Use more consistent file names. List the files using a QTreeWidget instead of a grid. fileset_is_file_in_set is only used in fileset.c so make it static. In main_window.cpp reduce our usage of the global cfile variable. svn path=/trunk/; revision=45243
* Add a window pointer so that we can figure out from whence we came.Gerald Combs2012-10-011-6/+4
| | | | | | Bring the timestamp output more in line with ISO 8601. svn path=/trunk/; revision=45240
* We always HAVE_CONFIG_H so don't bother checking whether we have it or not.Jeff Morriss2012-09-201-3/+1
| | | | svn path=/trunk/; revision=45015
* Update Free Software Foundation address.Jakub Zawadzki2012-06-281-1/+1
| | | | | | (COPYING will be updated in next commit) svn path=/trunk/; revision=43536
* From Evan Huus:Anders Broman2012-06-241-0/+44
| | | | | | | | Size wrong in "File Set List" for just-finished captures. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7370 svn path=/trunk/; revision=43455
* Define ws_statb64 to be the appropriate "struct XXX" for aGuy Harris2011-04-101-1/+1
| | | | | | 64-bit-file-size-capable stat call, and use it for ws_fstat64(). svn path=/trunk/; revision=36545
* Add ws_fstat64(), defined to be fstat on UN*X and _fstati64 on Windows.Guy Harris2011-04-101-1/+1
| | | | | | Use it in some places where we're getting the file size. svn path=/trunk/; revision=36544
* Define some vars & fcns as static;Bill Meier2010-10-121-5/+5
| | | | | | Also: do some minor reformmating and cleanup of whitespace. svn path=/trunk/; revision=34492
* When freeing the fileset entries, free the entry itself too.Jeff Morriss2010-08-201-0/+1
| | | | svn path=/trunk/; revision=33865
* Squelch some compiler warnings.Guy Harris2010-03-021-11/+11
| | | | svn path=/trunk/; revision=32078
* Removed some unused assignments.Stig Bjørlykke2009-11-101-2/+1
| | | | svn path=/trunk/; revision=30920
* (FWIW) One step towards including stdio.h & stdlib.h only when req'd.Bill Meier2009-08-261-0/+1
| | | | svn path=/trunk/; revision=29568
* Fix the last(?) of the Win64 compilation problems.Gerald Combs2009-04-161-3/+3
| | | | svn path=/trunk/; revision=28065
* ETH -> WS updates.Gerald Combs2008-10-271-2/+2
| | | | svn path=/trunk/; revision=26570
* Move the file utility functions from wiretap to libwsutil so thatJeff Morriss2008-05-221-10/+10
| | | | | | | | | libwireshark (and the plugins using those functions) do not depend on wiretap on Windows. While doing that, rename the eth_* functions to ws_*. svn path=/trunk/; revision=25354
* Fix yet more casts of ctype.h macro arguments - and fix some cases whereGuy Harris2007-07-141-1/+1
| | | | | | we were passing an uncasted "char" to those macros. svn path=/trunk/; revision=22306
* suffix in file set is optionalTomas Kukosa2006-11-301-2/+5
| | | | svn path=/trunk/; revision=20023
* fix a minor bug: don't show a single file twice in the fileset dialogUlf Lamping2006-08-291-3/+1
| | | | svn path=/trunk/; revision=19078
* name changeRonnie Sahlberg2006-05-211-2/+2
| | | | svn path=/trunk/; revision=18197
* Use eth_dir_open(), not g_dir_open(); g_dir_open() isn't available inGuy Harris2005-11-071-2/+2
| | | | | | GLib 1.2[.x]. svn path=/trunk/; revision=16412
* replace *a lot* of file related calls by their GLib counterparts. This is ↵Ulf Lamping2005-11-061-33/+9
| | | | | | | | | | | | necessary for the switch to GTK 2.6 (at least on WIN32). to do this, I've added file_util.h to wiretap (would file_compat.h be a better name?), and provide compat_macros like eth_open() instead of open(). While at it, move other file related things there, like #include <io.h>, definition of O_BINARY and alike, so it's all in one place. deleted related things from config.h.win32 As of these massive changes, I'm almost certain that this will break the Unix build. I'll keep an eye on the buildbot so hopefully everything is working again soon. svn path=/trunk/; revision=16403
* while sorting the entries, don't use the file creation date but the filename ↵Ulf Lamping2005-08-181-4/+4
| | | | | | for comparison svn path=/trunk/; revision=15411
* Some 'no previous declararion' warning fixesJörg Mayer2005-08-141-4/+4
| | | | svn path=/trunk/; revision=15355
* do some code cleanup (from the previous commit) and close the directories ↵Ulf Lamping2005-05-181-23/+36
| | | | | | opened with opendir/g_dir_open svn path=/trunk/; revision=14394
* don't crash, if the given filename doesn't contain a dot e.g. 'test123'Ulf Lamping2005-05-181-1/+1
| | | | svn path=/trunk/; revision=14390
* (hopefully) removed various gcc warningsUlf Lamping2005-04-301-0/+4
| | | | svn path=/trunk/; revision=14241
* fix buildbot reported problems (unix related), part 4, more GLib 1.x relatedUlf Lamping2005-04-301-2/+4
| | | | svn path=/trunk/; revision=14240
* fix buildbot reported problems (unix related), part 3, don't use GError with ↵Ulf Lamping2005-04-301-4/+4
| | | | | | GLib 1.x svn path=/trunk/; revision=14239
* fix buildbot reported problems (unix related), part 2, add some missing ↵Ulf Lamping2005-04-291-0/+5
| | | | | | #includes svn path=/trunk/; revision=14235
* fix buildbot reported problems (unix related), part 1Ulf Lamping2005-04-291-4/+5
| | | | svn path=/trunk/; revision=14234
generated by cgit v1.2.3 (git 2.25.1) at 2025-02-25 04:35:40 +0000