diff options
| author | Guy Harris <guy@alum.mit.edu> | 2003-03-06 19:15:09 +0000 |
|---|---|---|
| committer | Guy Harris <guy@alum.mit.edu> | 2003-03-06 19:15:09 +0000 |
| commit | 2b7866f33b0a3af134219d11f437ebcad79b858f (patch) | |
| tree | 5009de754def56348aeeef98919add2e52cba311 /plugins/mgcp | |
| parent | e2c1862af71d0c907707ebafd21be5c09269ef8c (diff) | |
| download | wireshark-2b7866f33b0a3af134219d11f437ebcad79b858f.tar.gz wireshark-2b7866f33b0a3af134219d11f437ebcad79b858f.tar.bz2 wireshark-2b7866f33b0a3af134219d11f437ebcad79b858f.zip | |
"transid" values are guint32's, and should be printed with "%u" (on
most, if not all, platforms on which Ethereal runs, a guint32 is an
"unsigned int", not an "unsigned long", and on platforms where an
"unsigned long" is 64 bits, "%ld" is definitely wrong - and so is
"%lu").
svn path=/trunk/; revision=7296
Diffstat (limited to 'plugins/mgcp')
| -rw-r--r-- | plugins/mgcp/packet-mgcp.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/plugins/mgcp/packet-mgcp.c b/plugins/mgcp/packet-mgcp.c index 61bc016f8a..a7695ced75 100644 --- a/plugins/mgcp/packet-mgcp.c +++ b/plugins/mgcp/packet-mgcp.c @@ -2,7 +2,7 @@ * Routines for mgcp packet disassembly * RFC 2705 * - * $Id: packet-mgcp.c,v 1.36 2003/03/06 09:01:47 sahlberg Exp $ + * $Id: packet-mgcp.c,v 1.37 2003/03/06 19:15:09 guy Exp $ * * Copyright (c) 2000 by Ed Warnicke <hagbard@physics.rutgers.edu> * @@ -1024,6 +1024,7 @@ static void dissect_mgcp_firstline(tvbuff_t *tvb, packet_info *pinfo, if(tokennum == 1){ transid = g_malloc(tokenlen); transid = tvb_format_text(tvb,tvb_previous_offset,tokenlen); + /* XXX - what if this isn't a valid text string? */ mi->transid = atol(transid); my_proto_tree_add_string(tree,hf_mgcp_transid, tvb, tvb_previous_offset, tokenlen, @@ -1146,7 +1147,7 @@ static void dissect_mgcp_firstline(tvbuff_t *tvb, packet_info *pinfo, mi->is_duplicate = TRUE; if (check_col(pinfo->cinfo, COL_INFO)) { col_append_fstr(pinfo->cinfo, COL_INFO, - ", Duplicate Response %ld",mi->transid); + ", Duplicate Response %u",mi->transid); if (tree) { proto_tree_add_uint_hidden(tree, hf_mgcp_dup, tvb, 0,0, mi->transid); @@ -1222,7 +1223,7 @@ static void dissect_mgcp_firstline(tvbuff_t *tvb, packet_info *pinfo, mi->is_duplicate = TRUE; if (check_col(pinfo->cinfo, COL_INFO)) { col_append_fstr(pinfo->cinfo, COL_INFO, - ", Duplicate Request %ld",mi->transid); + ", Duplicate Request %u",mi->transid); if (tree) { proto_tree_add_uint_hidden(tree, hf_mgcp_dup, tvb, 0,0, mi->transid); |