diff options
| author | Guy Harris <guy@alum.mit.edu> | 2003-04-15 09:23:42 +0000 |
|---|---|---|
| committer | Guy Harris <guy@alum.mit.edu> | 2003-04-15 09:23:42 +0000 |
| commit | e04f6f760ae14ab52c36164a67ba37b21840b54a (patch) | |
| tree | d76694490c1fa12791644d12cbddacb57ffc1658 /packet-smb-pipe.c | |
| parent | 79ac2b53bd2c2a01465559ef453bf195c823144c (diff) | |
| download | wireshark-e04f6f760ae14ab52c36164a67ba37b21840b54a.tar.gz wireshark-e04f6f760ae14ab52c36164a67ba37b21840b54a.tar.bz2 wireshark-e04f6f760ae14ab52c36164a67ba37b21840b54a.zip | |
Put in a comment noting that the reassembly code assumes subdissectors
are idempotent, which isn't necessarily the case.
svn path=/trunk/; revision=7462
Diffstat (limited to 'packet-smb-pipe.c')
| -rw-r--r-- | packet-smb-pipe.c | 10 |
1 files changed, 8 insertions, 2 deletions
diff --git a/packet-smb-pipe.c b/packet-smb-pipe.c index 7ec7c930cf..fec3aff5a9 100644 --- a/packet-smb-pipe.c +++ b/packet-smb-pipe.c @@ -8,7 +8,7 @@ XXX Fixme : shouldnt show [malformed frame] for long packets * significant rewrite to tvbuffify the dissector, Ronnie Sahlberg and * Guy Harris 2001 * - * $Id: packet-smb-pipe.c,v 1.92 2003/04/14 20:48:31 guy Exp $ + * $Id: packet-smb-pipe.c,v 1.93 2003/04/15 09:23:42 guy Exp $ * * Ethereal - Network traffic analyzer * By Gerald Combs <gerald@ethereal.com> @@ -3278,7 +3278,13 @@ dissect_pipe_dcerpc(tvbuff_t *d_tvb, packet_info *pinfo, proto_tree *parent_tree in this tvb. */ - /* first, just check if it looks like dcerpc or not */ + /* + * First, just check if it looks like dcerpc or not. + * + * XXX - this assumes that the dissector is idempotent, + * as it's doing a "trial" dissection building no + * tree; that's not necessarily the case. + */ result = dissector_try_heuristic(smb_transact_heur_subdissector_list, d_tvb, pinfo, NULL); /* no this didnt look like something we know */ |