diff options
author | Laurent Deniel <laurent.deniel@free.fr> | 2000-08-13 14:09:15 +0000 |
---|---|---|
committer | Laurent Deniel <laurent.deniel@free.fr> | 2000-08-13 14:09:15 +0000 |
commit | cc36f0b9312fc36778bf227cbaaf02c89baf09b3 (patch) | |
tree | 0aff9b70a00a628a713030dc9000f3b5492d492b /packet-rsh.c | |
parent | db31ba13c8b9f82c1b96b5444fe3b7e8ff109ce1 (diff) | |
download | wireshark-cc36f0b9312fc36778bf227cbaaf02c89baf09b3.tar.gz wireshark-cc36f0b9312fc36778bf227cbaaf02c89baf09b3.tar.bz2 wireshark-cc36f0b9312fc36778bf227cbaaf02c89baf09b3.zip |
Add the "Edit:Protocols..." feature which currently only implements
the following:
It is now possible to enable/disable a particular protocol decoding
(i.e. the protocol dissector is void or not). When a protocol
is disabled, it is displayed as Data and of course, all linked
sub-protocols are disabled as well.
Disabling a protocol could be interesting:
- in case of buggy dissectors
- in case of wrong heuristics
- for performance reasons
- to decode the data as another protocol (TODO)
Currently (if I am not wrong), all dissectors but NFS can be disabled
(and dissectors that do not register protocols :-)
I do not like the way the RPC sub-dissectors are disabled (in the
sub-dissectors) since this could be done in the RPC dissector itself,
knowing the sub-protocol hfinfo entry (this is why, I've not modified
the NFS one yet).
Two functions are added in proto.c :
gboolean proto_is_protocol_enabled(int n);
void proto_set_decoding(int n, gboolean enabled);
and two MACROs which can be used in dissectors:
OLD_CHECK_DISPLAY_AS_DATA(index, pd, offset, fd, tree)
CHECK_DISPLAY_AS_DATA(index, tvb, pinfo, tree)
See also the XXX in proto_dlg.c and proto.c around the new functions.
svn path=/trunk/; revision=2267
Diffstat (limited to 'packet-rsh.c')
-rw-r--r-- | packet-rsh.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/packet-rsh.c b/packet-rsh.c index 9491001385..298412ae8f 100644 --- a/packet-rsh.c +++ b/packet-rsh.c @@ -4,7 +4,7 @@ * Robert Tsai <rtsai@netapp.com> * Liberally copied from packet-http.c, by Guy Harris <guy@alum.mit.edu> * - * $Id: packet-rsh.c,v 1.2 2000/08/12 12:56:23 deniel Exp $ + * $Id: packet-rsh.c,v 1.3 2000/08/13 14:08:43 deniel Exp $ * * Ethereal - Network traffic analyzer * By Gerald Combs <gerald@zing.org> @@ -55,6 +55,8 @@ dissect_rsh(const u_char *pd, int offset, frame_data *fd, proto_tree *tree) const u_char *lineend, *eol; int linelen; + OLD_CHECK_DISPLAY_AS_DATA(proto_rsh, pd, offset, fd, tree); + data = &pd[offset]; dataend = data + END_OF_FRAME; |