aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-fcp.c
diff options
context:
space:
mode:
authorRonnie Sahlberg <ronnie_sahlberg@ozemail.com.au>2006-04-06 02:04:22 +0000
committerRonnie Sahlberg <ronnie_sahlberg@ozemail.com.au>2006-04-06 02:04:22 +0000
commitec77d1cc28e0e94a21781ddfd15a001a5c8be04b (patch)
treeb995f0f5ed432e3fe36076f8ca1644eb49bacb13 /epan/dissectors/packet-fcp.c
parentdd62a0f45832261d20e8c87420860da8c4eb9a49 (diff)
downloadwireshark-ec77d1cc28e0e94a21781ddfd15a001a5c8be04b.tar.gz
wireshark-ec77d1cc28e0e94a21781ddfd15a001a5c8be04b.tar.bz2
wireshark-ec77d1cc28e0e94a21781ddfd15a001a5c8be04b.zip
remove another field from a structure that we never use.
svn path=/trunk/; revision=17824
Diffstat (limited to 'epan/dissectors/packet-fcp.c')
-rw-r--r--epan/dissectors/packet-fcp.c24
1 files changed, 2 insertions, 22 deletions
diff --git a/epan/dissectors/packet-fcp.c b/epan/dissectors/packet-fcp.c
index 8a71f8dafc..74ac4a8582 100644
--- a/epan/dissectors/packet-fcp.c
+++ b/epan/dissectors/packet-fcp.c
@@ -141,7 +141,6 @@ typedef struct _fcp_conv_key {
} fcp_conv_key_t;
typedef struct _fcp_conv_data {
- guint32 fcp_dl;
gint32 fcp_lun;
} fcp_conv_data_t;
@@ -472,27 +471,12 @@ dissect_fcp_cmnd(tvbuff_t *tvb, packet_info *pinfo, proto_tree *parent_tree, pro
* XXX - the fetch of the fcp_dl value will throw an exception on
* a short frame before we get a chance to dissect the stuff before
* it.
- *
- * XXX - this doesn't appear to store the data length with the
- * FCP packet with the data, so this might not work correctly
- * if you select a command packet, select the corresponding data
- * packet, and then select another data packet with a different
- * length.
*/
- if (cdata) {
- /* Since we never free the memory used by an exchange, this maybe a
- * case of another request using the same exchange as a previous
- * req.
- */
- cdata->fcp_dl = tvb_get_ntohl (tvb, offset+12+16+add_len);
- }
- else {
+ if (!cdata) {
req_key = se_alloc (sizeof(fcp_conv_key_t));
req_key->conv_idx = conversation->index;
cdata = se_alloc (sizeof(fcp_conv_data_t));
- cdata->fcp_dl = tvb_get_ntohl (tvb, offset+12+16+add_len);
-
g_hash_table_insert (fcp_req_hash, req_key, cdata);
}
@@ -719,15 +703,11 @@ dissect_fcp_xfer_rdy(tvbuff_t *tvb, packet_info *pinfo, proto_tree *parent_tree,
cdata = (fcp_conv_data_t *)g_hash_table_lookup (fcp_req_hash,
&ckey);
- if (cdata) {
- cdata->fcp_dl = tvb_get_ntohl (tvb, offset+4);
- }
- else {
+ if (!cdata) {
req_key = se_alloc (sizeof(fcp_conv_key_t));
req_key->conv_idx = conversation->index;
cdata = se_alloc (sizeof(fcp_conv_data_t));
- cdata->fcp_dl = tvb_get_ntohl (tvb, offset+4);
cdata->fcp_lun = -1;
g_hash_table_insert (fcp_req_hash, req_key, cdata);