diff options
| author | Jaap Keuter <jaap.keuter@xs4all.nl> | 2007-01-26 17:12:00 +0000 |
|---|---|---|
| committer | Jaap Keuter <jaap.keuter@xs4all.nl> | 2007-01-26 17:12:00 +0000 |
| commit | e4e739a5caf033d2ae9c7885e914809acc13a746 (patch) | |
| tree | c21bd0831887e779d08139701ea749d5dfae9ea0 /doc | |
| parent | f8be165898b1931b2023c333bc954e77c5abff15 (diff) | |
| download | wireshark-e4e739a5caf033d2ae9c7885e914809acc13a746.tar.gz wireshark-e4e739a5caf033d2ae9c7885e914809acc13a746.tar.bz2 wireshark-e4e739a5caf033d2ae9c7885e914809acc13a746.zip | |
From Graham Bloice:
In the Developers Guide, Section 9.3, Example 9.17. Decompressing data
packets for dissection
The code calls tvb_set_free_cb() for the newly created next_tvb. This
is unnecessary as the call to tvb_set_child_real_data() adds next_tvb to
the chained list of tvb, thus ensuring that next_tvb is correctly
deleted. In fact when I had the call in, Visual Studio kept breaking
deep down in ntdll.dll, probably because of a double free every time the
main tvb was deleted.
In README.developer, para 2..2.7 The example conversation code doesn't
assign the result of conversation_new() back into the conversation variable.
svn path=/trunk/; revision=20569
Diffstat (limited to 'doc')
| -rw-r--r-- | doc/README.developer | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/doc/README.developer b/doc/README.developer index 6d603f968e..d713f6b14d 100644 --- a/doc/README.developer +++ b/doc/README.developer @@ -2809,7 +2809,7 @@ else { /* create the conversation with your data pointer */ - conversation_new(pinfo->fd->num, &pinfo->src, &pinfo->dst, pinfo->ptype, + conversation = conversation_new(pinfo->fd->num, &pinfo->src, &pinfo->dst, pinfo->ptype, pinfo->srcport, pinfo->destport, 0); conversation_add_proto_data(conversation, my_proto, (void *)data_ptr); } |