diff options
| author | Triton Circonflexe <triton@kumal.info> | 2021-04-23 19:34:54 +0200 |
|---|---|---|
| committer | Wireshark GitLab Utility <gerald+gitlab-utility@wireshark.org> | 2021-08-27 06:04:17 +0000 |
| commit | d4de52690f7565069377aad4bdd32c272dc576cc (patch) | |
| tree | c7a417dd7131cc73d281c8b88cebb1a3a10b91a2 /AUTHORS | |
| parent | b17f354304242ac14769f7b4f13b65b077b769a8 (diff) | |
| download | wireshark-d4de52690f7565069377aad4bdd32c272dc576cc.tar.gz wireshark-d4de52690f7565069377aad4bdd32c272dc576cc.tar.bz2 wireshark-d4de52690f7565069377aad4bdd32c272dc576cc.zip | |
Thrift: Complete handling of Binary & Compact protocols
- Make sure reassembly requests & errors are properly propagated from
any point in the PDU, no matter how many sub-structure levels.
- Handle the sub-dissection methods as well:
- Ensure the sub-dissection methods handle errors from previous calls.
- Reduce the error handling needed in sub-dissector implementations.
- Add missing sub-dissection methods for list, set, and map.
- Add the handling of sub-structure.
- Handle Compact protocol in addition to the existing binary protocol.
- Include and improve MR !3171
- Handle reassembly the same way as for binary protocol.
- Handle sub-dissection with the same functions.
=> Sub-dissectors only depend on .thrift files.
Additional changes:
- Use of constants instead of hard-coded values.
- Removed U64 support (never supported by thrift code generator, only
referenced in the C++ thrift library header but not supported in reality.
- Removed references to UTF-8 and UTF-16 string for the same reason.
- Replaced references to UTF-7 string with just string (same reason).
- Replaced references to byte with i8 as the documentation explicitly
states that byte is a compatibility name.
Documentation reference:
- https://thrift.apache.org/developers
- https://thrift.apache.org/docs/idl.html
- https://github.com/apache/thrift/blob/master/doc/specs/thrift-compact-protocol.md
- https://erikvanoosten.github.io/thrift-missing-specification/
- https://diwakergupta.github.io/thrift-missing-guide/
Closes #16244
Additional changes:
- Add authors and improve consistency
- Fix typo and clarify documentation
Diffstat (limited to 'AUTHORS')
| -rw-r--r-- | AUTHORS | 5 |
1 files changed, 3 insertions, 2 deletions
@@ -3989,9 +3989,10 @@ James Lynch <lynch007[AT]gmail.com> Chidambaram Arunachalam <carunach[AT]cisco.com> João Valverde <j[AT]v6e.pt> Benoît Canet <benoit[AT]scylladb.com> -Håkon Øye Amundsen <haakon.amundsen[AT]nordicsemi.no> +Håkon Øye Amundsen <haakon.amundsen[AT]nordicsemi.no> Jeffrey Wildman <jeffrey.wildman[AT]ll.mit.edu> Jan Schiefer <jan.schiefer[AT]keysight.com> +Triton Circonflexe <triton+enuiqr[AT]kumal.info> = From git log = @@ -5022,7 +5023,7 @@ Mattia Cazzola <mattiac[AT]alinet.it> provided a patch to the hex dump display r We use the exception module from Kazlib, a C library written by Kaz Kylheku <kaz[AT]kylheku.com>. Thanks go to him for his well-written library. The Kazlib home page can be found at http://www.kylheku.com/~kaz/kazlib.html -We use Lua BitOp, written by Mike Pall, for bitwise operations on numbers in Lua. The Lua BitOp home page can be found at https://bitop.luajit.org +We use Lua BitOp, written by Mike Pall, for bitwise operations on numbers in Lua. The Lua BitOp home page can be found at https://bitop.luajit.org/ snax <snax[AT]shmoo.com> gave permission to use his(?) weak key detection code from Airsnort. |