summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorNathan Harold <nharold@google.com>2016-10-10 11:15:21 -0700
committerNathan Harold <nharold@google.com>2016-10-10 18:02:00 -0700
commitc863521147c0fdf8497a10430f85c306e60f2084 (patch)
treeaaa418828eeadbb5964778fa822f22da1fec54ea
parent3731ea75489bb48c63b3661013d19b3b4d7607e5 (diff)
downloadplatform_hardware_ril-nougat-mr1.2-release.tar.gz
platform_hardware_ril-nougat-mr1.2-release.tar.bz2
platform_hardware_ril-nougat-mr1.2-release.zip
Update documentation to clarify RIL_REQUEST_GET_ACTIVITY_INFOandroid-cts-7.1_r9android-cts-7.1_r8android-cts-7.1_r7android-cts-7.1_r6android-cts-7.1_r5android-cts-7.1_r4android-cts-7.1_r3android-cts-7.1_r29android-cts-7.1_r28android-cts-7.1_r27android-cts-7.1_r26android-cts-7.1_r25android-cts-7.1_r24android-cts-7.1_r23android-cts-7.1_r22android-cts-7.1_r21android-cts-7.1_r20android-cts-7.1_r2android-cts-7.1_r19android-cts-7.1_r18android-cts-7.1_r17android-cts-7.1_r16android-cts-7.1_r15android-cts-7.1_r14android-cts-7.1_r13android-cts-7.1_r12android-cts-7.1_r11android-cts-7.1_r10android-cts-7.1_r1android-7.1.1_r9android-7.1.1_r8android-7.1.1_r7android-7.1.1_r6android-7.1.1_r53android-7.1.1_r52android-7.1.1_r51android-7.1.1_r50android-7.1.1_r49android-7.1.1_r48android-7.1.1_r47android-7.1.1_r46android-7.1.1_r45android-7.1.1_r44android-7.1.1_r43android-7.1.1_r42android-7.1.1_r41android-7.1.1_r40android-7.1.1_r4android-7.1.1_r39android-7.1.1_r38android-7.1.1_r35android-7.1.1_r33android-7.1.1_r32android-7.1.1_r31android-7.1.1_r3android-7.1.1_r28android-7.1.1_r27android-7.1.1_r26android-7.1.1_r25android-7.1.1_r24android-7.1.1_r23android-7.1.1_r22android-7.1.1_r21android-7.1.1_r20android-7.1.1_r2android-7.1.1_r17android-7.1.1_r16android-7.1.1_r15android-7.1.1_r14android-7.1.1_r13android-7.1.1_r12android-7.1.1_r11android-7.1.1_r10android-7.1.1_r1nougat-mr1.4-releasenougat-mr1.3-releasenougat-mr1.2-releasenougat-mr1-releasenougat-mr1-flounder-releasenougat-mr1-devnougat-mr1-cts-release
The documentation for RIL_REQUEST_GET_ACTIVITY_INFO allowed for critically disruptive behavior in the implementation of the API. This is a documentation update to ensure that there will be exactly one power state reported in each millisecond, which is important for proper power accounting in FDD. Bug: 32061813 Test: none Change-Id: I2835d5ad298eaa8cfea2e1a90342f290183f698d
-rw-r--r--include/telephony/ril.h27
1 files changed, 19 insertions, 8 deletions
diff --git a/include/telephony/ril.h b/include/telephony/ril.h
index 98aa7d3d..5fcd9015 100644
--- a/include/telephony/ril.h
+++ b/include/telephony/ril.h
@@ -1712,18 +1712,29 @@ typedef struct {
/* Tx Power Levels */
#define RIL_NUM_TX_POWER_LEVELS 5
+/**
+ * Aggregate modem activity information
+ */
typedef struct {
- /* period (in ms) when modem is power collapsed */
+ /* total time (in ms) when modem is in a low power or
+ * sleep state
+ */
uint32_t sleep_mode_time_ms;
- /* period (in ms) when modem is awake and in idle mode*/
+ /* total time (in ms) when modem is awake but neither
+ * the transmitter nor receiver are active/awake */
uint32_t idle_mode_time_ms;
- /* period (in ms) for which Tx is active */
+ /* total time (in ms) during which the transmitter is active/awake,
+ * subdivided by manufacturer-defined device-specific
+ * contiguous increasing ranges of transmit power between
+ * 0 and the transmitter's maximum transmit power.
+ */
uint32_t tx_mode_time_ms[RIL_NUM_TX_POWER_LEVELS];
- /* period (in ms) for which Rx is active */
+ /* total time (in ms) for which receiver is active/awake and
+ * the transmitter is inactive */
uint32_t rx_mode_time_ms;
} RIL_ActivityStatsInfo;
@@ -5101,11 +5112,11 @@ typedef struct {
/**
* RIL_REQUEST_GET_ACTIVITY_INFO
*
- * Get modem activity statisitics info.
+ * Get modem activity information for power consumption estimation.
*
- * There can be multiple RIL_REQUEST_GET_ACTIVITY_INFO calls to modem.
- * Once the response for the request is sent modem will clear
- * current statistics information.
+ * Request clear-on-read statistics information that is used for
+ * estimating the per-millisecond power consumption of the cellular
+ * modem.
*
* "data" is null
* "response" is const RIL_ActivityStatsInfo *