diff options
-rw-r--r-- | res/drawable-hdpi/empty_search_results.png | bin | 51332 -> 0 bytes | |||
-rw-r--r-- | res/drawable-mdpi/empty_search_results.png | bin | 40046 -> 0 bytes | |||
-rw-r--r-- | res/drawable-xhdpi/empty_search_results.png | bin | 60334 -> 0 bytes | |||
-rw-r--r-- | res/drawable-xxhdpi/empty_search_results.png | bin | 76829 -> 0 bytes | |||
-rw-r--r-- | res/drawable-xxxhdpi/empty_search_results.png | bin | 70660 -> 0 bytes | |||
-rw-r--r-- | res/drawable/empty_search_results.xml | 30 | ||||
-rw-r--r-- | res/layout/search_panel.xml | 4 | ||||
-rwxr-xr-x | res/values/config.xml | 3 | ||||
-rw-r--r-- | res/values/strings.xml | 8 | ||||
-rw-r--r-- | res/xml/development_prefs.xml | 4 | ||||
-rw-r--r-- | src/com/android/settings/development/CameraHalHdrplusPreferenceController.java | 105 | ||||
-rw-r--r-- | src/com/android/settings/development/DevelopmentSettings.java | 9 | ||||
-rw-r--r-- | tests/robotests/src/com/android/settings/bluetooth/BluetoothPairingDialogTest.java | 1 | ||||
-rw-r--r-- | tests/robotests/src/com/android/settings/development/CameraHalHdrplusPreferenceControllerTest.java | 146 |
14 files changed, 33 insertions, 277 deletions
diff --git a/res/drawable-hdpi/empty_search_results.png b/res/drawable-hdpi/empty_search_results.png Binary files differdeleted file mode 100644 index 6202a33022..0000000000 --- a/res/drawable-hdpi/empty_search_results.png +++ /dev/null diff --git a/res/drawable-mdpi/empty_search_results.png b/res/drawable-mdpi/empty_search_results.png Binary files differdeleted file mode 100644 index e418d7c56c..0000000000 --- a/res/drawable-mdpi/empty_search_results.png +++ /dev/null diff --git a/res/drawable-xhdpi/empty_search_results.png b/res/drawable-xhdpi/empty_search_results.png Binary files differdeleted file mode 100644 index a92f000edc..0000000000 --- a/res/drawable-xhdpi/empty_search_results.png +++ /dev/null diff --git a/res/drawable-xxhdpi/empty_search_results.png b/res/drawable-xxhdpi/empty_search_results.png Binary files differdeleted file mode 100644 index 4c549bcaec..0000000000 --- a/res/drawable-xxhdpi/empty_search_results.png +++ /dev/null diff --git a/res/drawable-xxxhdpi/empty_search_results.png b/res/drawable-xxxhdpi/empty_search_results.png Binary files differdeleted file mode 100644 index 1aed6ad18c..0000000000 --- a/res/drawable-xxxhdpi/empty_search_results.png +++ /dev/null diff --git a/res/drawable/empty_search_results.xml b/res/drawable/empty_search_results.xml new file mode 100644 index 0000000000..916210712b --- /dev/null +++ b/res/drawable/empty_search_results.xml @@ -0,0 +1,30 @@ +<?xml version="1.0" encoding="utf-8"?> +<!-- + ~ Copyright (C) 2017 The Android Open Source Project + ~ + ~ Licensed under the Apache License, Version 2.0 (the "License"); + ~ you may not use this file except in compliance with the License. + ~ You may obtain a copy of the License at + ~ + ~ http://www.apache.org/licenses/LICENSE-2.0 + ~ + ~ Unless required by applicable law or agreed to in writing, software + ~ distributed under the License is distributed on an "AS IS" BASIS, + ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + ~ See the License for the specific language governing permissions and + ~ limitations under the License. + --> + +<vector xmlns:android="http://schemas.android.com/apk/res/android" + android:width="96dp" + android:height="96dp" + android:viewportWidth="24" + android:viewportHeight="24" + android:tint="?android:attr/colorControlNormal"> + + <path + android:fillColor="#000000" + android:pathData="M15.5,14h-0.79l-0.28-0.27c1.2-1.4,1.82-3.31,1.48-5.34c-0.47-2.78-2.79-5-5.59-5.34c-4.23-0.52-7.79,3.04-7.27,7.27 +c0.34,2.8,2.56,5.12,5.34,5.59c2.03,0.34,3.94-0.28,5.34-1.48L14,14.71v0.79l5.2,5.19c0.41,0.41,1.07,0.41,1.48,0l0.01-0.01 +c0.41-0.41,0.41-1.07,0-1.48L15.5,14z M9.5,14C7.01,14,5,11.99,5,9.5S7.01,5,9.5,5S14,7.01,14,9.5S11.99,14,9.5,14z" /> +</vector>
\ No newline at end of file diff --git a/res/layout/search_panel.xml b/res/layout/search_panel.xml index 48a1d4ce1e..b8e7ae13b2 100644 --- a/res/layout/search_panel.xml +++ b/res/layout/search_panel.xml @@ -85,8 +85,8 @@ android:layout_height="?android:attr/actionBarSize"/> <ImageView - android:layout_height="160dp" - android:layout_width="160dp" + android:layout_height="wrap_content" + android:layout_width="wrap_content" android:layout_gravity="center_horizontal" android:src="@drawable/empty_search_results"/> diff --git a/res/values/config.xml b/res/values/config.xml index f964d5ee24..18a8264eb6 100755 --- a/res/values/config.xml +++ b/res/values/config.xml @@ -41,9 +41,6 @@ <!-- Whether to show TelphonyMonitor switch in Developer Options --> <bool name="config_show_telephony_monitor">false</bool> - <!-- Whether to show Camera HAL HDR+ switch in Developer Options --> - <bool name="config_show_camera_hal_hdrplus">false</bool> - <!-- Whether to show Camera laser sensor switch in Developer Options --> <bool name="config_show_camera_laser_sensor">false</bool> diff --git a/res/values/strings.xml b/res/values/strings.xml index 76e314b3d6..8265475a98 100644 --- a/res/values/strings.xml +++ b/res/values/strings.xml @@ -1471,7 +1471,7 @@ <string name="bluetooth_display_passkey_pin_msg">To pair with:<xliff:g id="bold1"><br><b></xliff:g><xliff:g id="device_name">%1$s</xliff:g><xliff:g id="end_bold1"></b><br><br></xliff:g>Type on it:<xliff:g id="bold2"><br><b></xliff:g><xliff:g id="passkey">%2$s</xliff:g><xliff:g id="end_bold2"></b></xliff:g>, then press Return or Enter.</string> <!-- Checkbox message in pairing dialogs. [CHAR LIMIT=NONE] --> - <string name="bluetooth_pairing_shares_phonebook">Allow <xliff:g id="device_name">%1$s</xliff:g> to access your contacts and call history</string> + <string name="bluetooth_pairing_shares_phonebook">Allow access to your contacts and call history</string> <!-- Title for BT error dialogs. --> <string name="bluetooth_error_title"></string> @@ -8237,12 +8237,6 @@ <!-- Toast message letting the user know the how to trigger telephony monitor --> <string name="telephony_monitor_toast">To apply telephony monitor change, reboot device</string> - <!-- Title for Camera HAL HDR+ switch [CHAR LIMIT=50] --> - <string name="camera_hal_hdrplus_switch">Camera HAL HDR+</string> - - <!-- Toast message letting the user know how to enable Camera HAL HDR+ --> - <string name="camera_hal_hdrplus_toast">To apply Camera HAL HDR+ change, reboot device</string> - <!-- Title for Camera laser sensor switch [CHAR LIMIT=NONE] --> <string name="camera_laser_sensor_switch">Camera Laser Sensor</string> diff --git a/res/xml/development_prefs.xml b/res/xml/development_prefs.xml index 147c5bcce7..bd91abdb52 100644 --- a/res/xml/development_prefs.xml +++ b/res/xml/development_prefs.xml @@ -167,10 +167,6 @@ android:key="camera_laser_sensor_switch" android:title="@string/camera_laser_sensor_switch" /> - <SwitchPreference - android:key="camera_hal_hdrplus_switch" - android:title="@string/camera_hal_hdrplus_switch" /> - </PreferenceCategory> <PreferenceCategory android:key="debug_networking_category" diff --git a/src/com/android/settings/development/CameraHalHdrplusPreferenceController.java b/src/com/android/settings/development/CameraHalHdrplusPreferenceController.java deleted file mode 100644 index 84836bc9bb..0000000000 --- a/src/com/android/settings/development/CameraHalHdrplusPreferenceController.java +++ /dev/null @@ -1,105 +0,0 @@ -/* - * Copyright (C) 2017 The Android Open Source Project - * - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ - -package com.android.settings.development; - -import android.content.Context; -import android.os.SystemProperties; -import android.support.v14.preference.SwitchPreference; -import android.support.v7.preference.Preference; -import android.support.v7.preference.PreferenceScreen; -import android.widget.Toast; - -import com.android.internal.annotations.VisibleForTesting; -import com.android.settings.R; -import com.android.settings.core.PreferenceControllerMixin; -import com.android.settingslib.core.AbstractPreferenceController; - -public class CameraHalHdrplusPreferenceController extends AbstractPreferenceController - implements PreferenceControllerMixin { - - private static final String KEY_CAMERA_HAL_HDRPLUS_SWITCH = "camera_hal_hdrplus_switch"; - @VisibleForTesting - static final String BUILD_TYPE = "ro.build.type"; - @VisibleForTesting - static final String PROPERTY_CAMERA_HAL_HDRPLUS = "persist.camera.hdrplus.enable"; - @VisibleForTesting - static final String ENABLED = "1"; - @VisibleForTesting - static final String DISABLED = "0"; - - private SwitchPreference mPreference; - - public CameraHalHdrplusPreferenceController(Context context) { - super(context); - } - - @Override - public void displayPreference(PreferenceScreen screen) { - super.displayPreference(screen); - if (isAvailable()) { - mPreference = (SwitchPreference) screen.findPreference(KEY_CAMERA_HAL_HDRPLUS_SWITCH); - mPreference.setChecked(isHalHdrplusEnabled()); - } - } - - @Override - public String getPreferenceKey() { - return KEY_CAMERA_HAL_HDRPLUS_SWITCH; - } - - @Override - public boolean isAvailable() { - return mContext.getResources().getBoolean(R.bool.config_show_camera_hal_hdrplus); - } - - @Override - public void updateState(Preference preference) { - updatePreference(); - } - - @Override - public boolean handlePreferenceTreeClick(Preference preference) { - if (KEY_CAMERA_HAL_HDRPLUS_SWITCH.equals(preference.getKey())) { - final SwitchPreference switchPreference = (SwitchPreference)preference; - SystemProperties.set(PROPERTY_CAMERA_HAL_HDRPLUS, - switchPreference.isChecked() ? ENABLED : DISABLED); - Toast.makeText(mContext, R.string.camera_hal_hdrplus_toast, - Toast.LENGTH_LONG).show(); - return true; - } - return false; - } - - public void enablePreference(boolean enabled) { - if (isAvailable()) { - mPreference.setEnabled(enabled); - } - } - - public boolean updatePreference() { - if (!isAvailable()) { - return false; - } - final boolean enabled = isHalHdrplusEnabled(); - mPreference.setChecked(enabled); - return enabled; - } - - private boolean isHalHdrplusEnabled() { - return SystemProperties.getBoolean(PROPERTY_CAMERA_HAL_HDRPLUS, false); - } -} diff --git a/src/com/android/settings/development/DevelopmentSettings.java b/src/com/android/settings/development/DevelopmentSettings.java index bfaed87b60..cce4fa6fe8 100644 --- a/src/com/android/settings/development/DevelopmentSettings.java +++ b/src/com/android/settings/development/DevelopmentSettings.java @@ -364,7 +364,6 @@ public class DevelopmentSettings extends RestrictedSettingsFragment private BugReportPreferenceController mBugReportController; private BugReportInPowerPreferenceController mBugReportInPowerController; private TelephonyMonitorPreferenceController mTelephonyMonitorController; - private CameraHalHdrplusPreferenceController mCameraHalHdrplusController; private CameraLaserSensorPreferenceController mCameraLaserSensorController; private BroadcastReceiver mEnableAdbReceiver; @@ -406,7 +405,6 @@ public class DevelopmentSettings extends RestrictedSettingsFragment mTelephonyMonitorController = new TelephonyMonitorPreferenceController(getActivity()); mWebViewAppPrefController = new WebViewAppPreferenceController(getActivity()); mVerifyAppsOverUsbController = new VerifyAppsOverUsbPreferenceController(getActivity()); - mCameraHalHdrplusController = new CameraHalHdrplusPreferenceController(getActivity()); mCameraLaserSensorController = new CameraLaserSensorPreferenceController(getActivity()); setIfOnlyAvailableForAdmins(true); @@ -440,7 +438,6 @@ public class DevelopmentSettings extends RestrictedSettingsFragment mBugReportInPowerController.displayPreference(getPreferenceScreen()); mTelephonyMonitorController.displayPreference(getPreferenceScreen()); mWebViewAppPrefController.displayPreference(getPreferenceScreen()); - mCameraHalHdrplusController.displayPreference(getPreferenceScreen()); mEnableAdbController.displayPreference(getPreferenceScreen()); mCameraLaserSensorController.displayPreference(getPreferenceScreen()); @@ -663,7 +660,6 @@ public class DevelopmentSettings extends RestrictedSettingsFragment mBugReportInPowerController.enablePreference(enabled); mTelephonyMonitorController.enablePreference(enabled); mWebViewAppPrefController.enablePreference(enabled); - mCameraHalHdrplusController.enablePreference(enabled); mCameraLaserSensorController.enablePreference(enabled); updateAllOptions(); } @@ -798,7 +794,6 @@ public class DevelopmentSettings extends RestrictedSettingsFragment } mHaveDebugSettings |= mBugReportInPowerController.updatePreference(); mHaveDebugSettings |= mTelephonyMonitorController.updatePreference(); - mHaveDebugSettings |= mCameraHalHdrplusController.updatePreference(); mHaveDebugSettings |= mCameraLaserSensorController.updatePreference(); updateSwitchPreference(mKeepScreenOn, Settings.Global.getInt(cr, Settings.Global.STAY_ON_WHILE_PLUGGED_IN, 0) != 0); @@ -2469,10 +2464,6 @@ public class DevelopmentSettings extends RestrictedSettingsFragment return true; } - if (mCameraHalHdrplusController.handlePreferenceTreeClick(preference)) { - return true; - } - if (mEnableAdbController.handlePreferenceTreeClick(preference)) { return true; } diff --git a/tests/robotests/src/com/android/settings/bluetooth/BluetoothPairingDialogTest.java b/tests/robotests/src/com/android/settings/bluetooth/BluetoothPairingDialogTest.java index fba11de806..80b4810625 100644 --- a/tests/robotests/src/com/android/settings/bluetooth/BluetoothPairingDialogTest.java +++ b/tests/robotests/src/com/android/settings/bluetooth/BluetoothPairingDialogTest.java @@ -290,7 +290,6 @@ public class BluetoothPairingDialogTest { CheckBox sharingCheckbox = (CheckBox) frag.getmDialog() .findViewById(R.id.phonebook_sharing_message_confirm_pin); assertThat(sharingCheckbox.getVisibility()).isEqualTo(View.VISIBLE); - assertThat(sharingCheckbox.getText().toString().contains(FAKE_DEVICE_NAME)).isTrue(); } @Test diff --git a/tests/robotests/src/com/android/settings/development/CameraHalHdrplusPreferenceControllerTest.java b/tests/robotests/src/com/android/settings/development/CameraHalHdrplusPreferenceControllerTest.java deleted file mode 100644 index f5ef38fef6..0000000000 --- a/tests/robotests/src/com/android/settings/development/CameraHalHdrplusPreferenceControllerTest.java +++ /dev/null @@ -1,146 +0,0 @@ -/* - * Copyright (C) 2017 The Android Open Source Project - * - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ - -package com.android.settings.development; - -import android.content.Context; -import android.os.SystemProperties; -import android.support.v14.preference.SwitchPreference; -import android.support.v7.preference.PreferenceScreen; - -import com.android.settings.R; -import com.android.settings.testutils.SettingsRobolectricTestRunner; -import com.android.settings.TestConfig; -import com.android.settings.testutils.shadow.SettingsShadowSystemProperties; - -import org.junit.After; -import org.junit.Before; -import org.junit.Test; -import org.junit.runner.RunWith; -import org.mockito.Answers; -import org.mockito.Mock; -import org.mockito.MockitoAnnotations; -import org.robolectric.annotation.Config; -import org.robolectric.RuntimeEnvironment; - -import static com.google.common.truth.Truth.assertThat; -import static org.mockito.Mockito.verify; -import static org.mockito.Mockito.when; - -@RunWith(SettingsRobolectricTestRunner.class) -@Config(manifest = TestConfig.MANIFEST_PATH, sdk = TestConfig.SDK_VERSION, - shadows = {SettingsShadowSystemProperties.class}) -public class CameraHalHdrplusPreferenceControllerTest { - - @Mock(answer = Answers.RETURNS_DEEP_STUBS) - private Context mContext; - @Mock - private PreferenceScreen mScreen; - @Mock - private SwitchPreference mPreference; - - static final String USERDEBUG_BUILD = "userdebug"; - - private CameraHalHdrplusPreferenceController mController; - - @Before - public void setUp() { - MockitoAnnotations.initMocks(this); - mController = new CameraHalHdrplusPreferenceController(mContext); - when(mScreen.findPreference(mController.getPreferenceKey())).thenReturn(mPreference); - when(mPreference.getKey()).thenReturn(mController.getPreferenceKey()); - } - - @After - public void tearDown() { - SettingsShadowSystemProperties.clear(); - } - - @Test - public void isAvailable_withConfigNoShow_shouldReturnFalse() { - when(mContext.getResources().getBoolean(R.bool.config_show_camera_hal_hdrplus)) - .thenReturn(false); - assertThat(mController.isAvailable()).isFalse(); - } - - @Test - public void displayPreference_cameraHalHdrplusEnabled_shouldCheckedPreference() { - when(mContext.getResources().getBoolean(R.bool.config_show_camera_hal_hdrplus)) - .thenReturn(true); - - SettingsShadowSystemProperties.set( - CameraHalHdrplusPreferenceController.PROPERTY_CAMERA_HAL_HDRPLUS, - CameraHalHdrplusPreferenceController.ENABLED); - SettingsShadowSystemProperties.set( - CameraHalHdrplusPreferenceController.BUILD_TYPE, USERDEBUG_BUILD); - - mController.displayPreference(mScreen); - - verify(mPreference).setChecked(true); - } - - @Test - public void displayPreference_cameraHalHdrplusEnabled_shouldUncheckedPreference() { - when(mContext.getResources().getBoolean(R.bool.config_show_camera_hal_hdrplus)) - .thenReturn(true); - - SettingsShadowSystemProperties.set( - CameraHalHdrplusPreferenceController.PROPERTY_CAMERA_HAL_HDRPLUS, - CameraHalHdrplusPreferenceController.DISABLED); - SettingsShadowSystemProperties.set( - CameraHalHdrplusPreferenceController.BUILD_TYPE, USERDEBUG_BUILD); - - mController.displayPreference(mScreen); - - verify(mPreference).setChecked(false); - } - - @Test - public void handlePreferenceTreeClick_preferenceChecked_shouldEnableCameraHalHdrplus() { - when(mContext.getResources().getBoolean(R.bool.config_show_camera_hal_hdrplus)) - .thenReturn(true); - - when(mPreference.isChecked()).thenReturn(true); - - when(mContext.getResources().getString(R.string.camera_hal_hdrplus_toast)).thenReturn( - RuntimeEnvironment.application.getString(R.string.camera_hal_hdrplus_toast)); - - mController.handlePreferenceTreeClick(mPreference); - - assertThat(CameraHalHdrplusPreferenceController.ENABLED.equals( - SystemProperties.get( - CameraHalHdrplusPreferenceController.PROPERTY_CAMERA_HAL_HDRPLUS, - CameraHalHdrplusPreferenceController.DISABLED))).isTrue(); - } - - @Test - public void handlePreferenceTreeClick_preferenceUnchecked_shouldDisableCameraHalHdrplus() { - when(mContext.getResources().getBoolean(R.bool.config_show_camera_hal_hdrplus)) - .thenReturn(true); - - when(mPreference.isChecked()).thenReturn(false); - - when(mContext.getResources().getString(R.string.camera_hal_hdrplus_toast)).thenReturn( - RuntimeEnvironment.application.getString(R.string.camera_hal_hdrplus_toast)); - - mController.handlePreferenceTreeClick(mPreference); - - assertThat(CameraHalHdrplusPreferenceController.DISABLED.equals( - SystemProperties.get( - CameraHalHdrplusPreferenceController.PROPERTY_CAMERA_HAL_HDRPLUS, - CameraHalHdrplusPreferenceController.DISABLED))).isTrue(); - } -} |